From: Florian Fainelli <florian.fainelli@int-evry.fr>
To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Add support for Cobalt Server front LED
Date: Tue, 16 Jan 2007 00:33:06 +0100 [thread overview]
Message-ID: <200701160033.10947.florian.fainelli@int-evry.fr> (raw)
In-Reply-To: <20070116074205.0428449d.yoichi_yuasa@tripeaks.co.jp>
[-- Attachment #1: Type: text/plain, Size: 2018 bytes --]
Hi Yoichi,
I first used the COBALT_LED_PORT address but it did not work for a reason I
ignore. If I use the COBALT_LED_BASE as defined, which is taken from the CoLo
code, it works fine.
Do know you what could explain this difference ? Can you test it on your
boxes ?
Thank you very much in advance for your answer.
Le lundi 15 janvier 2007 23:42, Yoichi Yuasa a écrit :
> Hi,
>
> On Mon, 15 Jan 2007 19:36:52 +0100
>
> Florian Fainelli <florian.fainelli@int-evry.fr> wrote:
> > Hi all,
> >
> > This patch adds support for controlling the front LED on Cobalt Server.
> > It has been tested on Qube 2 with either no default trigger, or the
> > IDE-activity trigger. Both work fine. Please comment and test !
> >
> > Thanks
> >
> > Florian
> >
> > Signed-off-by: Florian Fainelli <florian.fainelli@int-evry.fr>
> >
> > diff -urN linux-2.6.19.1/include/asm-mips/mach-cobalt/cobalt.h
> > linux-2.6.19.1.led/include/asm-mips/mach-cobalt/cobalt.h
> > --- linux-2.6.19.1/include/asm-mips/mach-cobalt/cobalt.h
> > 2006-12-11 20:32:53.000000000 +0100
> > +++ linux-2.6.19.1.led/include/asm-mips/mach-cobalt/cobalt.h
> > 2007-01-15 19:29:07.000000000 +0100
> > @@ -97,6 +97,7 @@
> > (PCI_FUNC (devfn) << 8) | (where)), GT_PCI0_CFGADDR_OFS)
> >
> > #define COBALT_LED_PORT (*(volatile unsigned char *)
> > CKSEG1ADDR(0x1c000000))
> > +#define COBALT_LED_BASE 0xbc000000
>
> You don't need COBALT_LED_BASE.
> Because COBALT_LED_PORT is already defined.
>
> Yoichi
--
Cordialement, Florian Fainelli
---------------------------------------------
5, rue Charles Fourier
Chambre 1202
91011 Evry
http://www.alphacore.net
(+33) 01 60 76 64 21
(+33) 06 09 02 64 95
---------------------------------------------
Association MiNET
http://www.minet.net
---------------------------------------------
Institut National des Télécommunication
http://www.int-evry.fr/telecomint
---------------------------------------------
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-01-15 23:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-15 18:36 [PATCH] Add support for Cobalt Server front LED Florian Fainelli
2007-01-15 22:42 ` Yoichi Yuasa
2007-01-15 23:33 ` Florian Fainelli [this message]
2007-01-15 23:56 ` Florian Fainelli
2007-01-17 16:46 ` Ralf Baechle
2007-01-17 18:04 ` Florian Fainelli
2007-01-17 18:29 ` Ralf Baechle
2007-01-17 18:37 ` Florian Fainelli
2007-01-16 9:53 ` Peter Horton
2007-01-16 10:14 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701160033.10947.florian.fainelli@int-evry.fr \
--to=florian.fainelli@int-evry.fr \
--cc=linux-mips@linux-mips.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox