Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Peter Horton <phorton@bitbox.co.uk>
To: Florian Fainelli <florian.fainelli@int-evry.fr>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Add support for Cobalt Server front LED
Date: Tue, 16 Jan 2007 09:53:19 +0000	[thread overview]
Message-ID: <45ACA08F.8000203@bitbox.co.uk> (raw)
In-Reply-To: <200701151936.57738.florian.fainelli@int-evry.fr>

Florian Fainelli wrote:
> 
> This patch adds support for controlling the front LED on Cobalt Server. It has 
> been tested on Qube 2 with either no default trigger, or the IDE-activity 
> trigger. Both work fine. Please comment and test !
>

Why did you add COBALT_LED_BASE when there was already a COBALT_LED_PORT 
define on the line above ?

All your

	*(volatile uint8_t *) COBALT_LED_BASE = n;

can be replaced by

	COBALT_LED_PORT = n;

P.

  parent reply	other threads:[~2007-01-16  9:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-15 18:36 [PATCH] Add support for Cobalt Server front LED Florian Fainelli
2007-01-15 22:42 ` Yoichi Yuasa
2007-01-15 23:33   ` Florian Fainelli
2007-01-15 23:56     ` Florian Fainelli
2007-01-17 16:46       ` Ralf Baechle
2007-01-17 18:04         ` Florian Fainelli
2007-01-17 18:29           ` Ralf Baechle
2007-01-17 18:37             ` Florian Fainelli
2007-01-16  9:53 ` Peter Horton [this message]
2007-01-16 10:14   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45ACA08F.8000203@bitbox.co.uk \
    --to=phorton@bitbox.co.uk \
    --cc=florian.fainelli@int-evry.fr \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox