From: Florian Fainelli <florian.fainelli@int-evry.fr>
To: Peter Horton <phorton@bitbox.co.uk>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Add support for Cobalt Server front LED
Date: Tue, 16 Jan 2007 11:14:55 +0100 [thread overview]
Message-ID: <200701161114.59117.florian.fainelli@int-evry.fr> (raw)
In-Reply-To: <45ACA08F.8000203@bitbox.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]
Hi Peter,
The patch I resend last night is using COBALT_LED_PORT. Is there anything else
that needs to be changed ? Thank you in advance for your answer
Le mardi 16 janvier 2007 10:53, Peter Horton a écrit :
> Florian Fainelli wrote:
> > This patch adds support for controlling the front LED on Cobalt Server.
> > It has been tested on Qube 2 with either no default trigger, or the
> > IDE-activity trigger. Both work fine. Please comment and test !
>
> Why did you add COBALT_LED_BASE when there was already a COBALT_LED_PORT
> define on the line above ?
>
> All your
>
> *(volatile uint8_t *) COBALT_LED_BASE = n;
>
> can be replaced by
>
> COBALT_LED_PORT = n;
>
> P.
--
Cordialement, Florian Fainelli
---------------------------------------------
5, rue Charles Fourier
Chambre 1202
91011 Evry
http://www.alphacore.net
(+33) 01 60 76 64 21
(+33) 06 09 02 64 95
---------------------------------------------
Association MiNET
http://www.minet.net
---------------------------------------------
Institut National des Télécommunication
http://www.int-evry.fr/telecomint
---------------------------------------------
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2007-01-16 10:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-15 18:36 [PATCH] Add support for Cobalt Server front LED Florian Fainelli
2007-01-15 22:42 ` Yoichi Yuasa
2007-01-15 23:33 ` Florian Fainelli
2007-01-15 23:56 ` Florian Fainelli
2007-01-17 16:46 ` Ralf Baechle
2007-01-17 18:04 ` Florian Fainelli
2007-01-17 18:29 ` Ralf Baechle
2007-01-17 18:37 ` Florian Fainelli
2007-01-16 9:53 ` Peter Horton
2007-01-16 10:14 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701161114.59117.florian.fainelli@int-evry.fr \
--to=florian.fainelli@int-evry.fr \
--cc=linux-mips@linux-mips.org \
--cc=phorton@bitbox.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox