* [PATCH 1/6] mips: irix_getcontext will always fail EFAULT [not found] <exportbomb.1187270320@pinky> @ 2007-08-16 13:18 ` Andy Whitcroft 2007-08-16 13:18 ` Andy Whitcroft 2007-08-22 22:35 ` Ralf Baechle 0 siblings, 2 replies; 3+ messages in thread From: Andy Whitcroft @ 2007-08-16 13:18 UTC (permalink / raw) To: linux-kernel Cc: Randy Dunlap, Andrew Morton, Andy Whitcroft, Andy Whitcroft, Ralf Baechle, linux-mips Seems that a trailing ';' has slipped onto the end of the access_ok check here, such that we will always return -EFAULT. Signed-off-by: Andy Whitcroft <apw@shadowen.org> Cc: Ralf Baechle <ralf@linux-mips.org> Cc: linux-mips@linux-mips.org --- arch/mips/kernel/irixsig.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/mips/kernel/irixsig.c b/arch/mips/kernel/irixsig.c index 6980deb..28b2a8f 100644 --- a/arch/mips/kernel/irixsig.c +++ b/arch/mips/kernel/irixsig.c @@ -725,7 +725,7 @@ asmlinkage int irix_getcontext(struct pt_regs *regs) current->comm, current->pid, ctx); #endif - if (!access_ok(VERIFY_WRITE, ctx, sizeof(*ctx))); + if (!access_ok(VERIFY_WRITE, ctx, sizeof(*ctx))) return -EFAULT; error = __put_user(current->thread.irix_oldctx, &ctx->link); ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/6] mips: irix_getcontext will always fail EFAULT 2007-08-16 13:18 ` [PATCH 1/6] mips: irix_getcontext will always fail EFAULT Andy Whitcroft @ 2007-08-16 13:18 ` Andy Whitcroft 2007-08-22 22:35 ` Ralf Baechle 1 sibling, 0 replies; 3+ messages in thread From: Andy Whitcroft @ 2007-08-16 13:18 UTC (permalink / raw) To: linux-kernel; +Cc: Randy Dunlap, Andrew Morton, Andy Whitcroft Seems that a trailing ';' has slipped onto the end of the access_ok check here, such that we will always return -EFAULT. Signed-off-by: Andy Whitcroft <apw@shadowen.org> Cc: Ralf Baechle <ralf@linux-mips.org> Cc: linux-mips@linux-mips.org --- arch/mips/kernel/irixsig.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/mips/kernel/irixsig.c b/arch/mips/kernel/irixsig.c index 6980deb..28b2a8f 100644 --- a/arch/mips/kernel/irixsig.c +++ b/arch/mips/kernel/irixsig.c @@ -725,7 +725,7 @@ asmlinkage int irix_getcontext(struct pt_regs *regs) current->comm, current->pid, ctx); #endif - if (!access_ok(VERIFY_WRITE, ctx, sizeof(*ctx))); + if (!access_ok(VERIFY_WRITE, ctx, sizeof(*ctx))) return -EFAULT; error = __put_user(current->thread.irix_oldctx, &ctx->link); ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/6] mips: irix_getcontext will always fail EFAULT 2007-08-16 13:18 ` [PATCH 1/6] mips: irix_getcontext will always fail EFAULT Andy Whitcroft 2007-08-16 13:18 ` Andy Whitcroft @ 2007-08-22 22:35 ` Ralf Baechle 1 sibling, 0 replies; 3+ messages in thread From: Ralf Baechle @ 2007-08-22 22:35 UTC (permalink / raw) To: Andy Whitcroft; +Cc: linux-kernel, Randy Dunlap, Andrew Morton, linux-mips On Thu, Aug 16, 2007 at 02:18:45PM +0100, Andy Whitcroft wrote: > Seems that a trailing ';' has slipped onto the end of the access_ok > check here, such that we will always return -EFAULT. Ilpo Järvinen has sent an identical patch earlier which I have already applied. Thanks anyway, Ralf ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-23 12:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <exportbomb.1187270320@pinky>
2007-08-16 13:18 ` [PATCH 1/6] mips: irix_getcontext will always fail EFAULT Andy Whitcroft
2007-08-16 13:18 ` Andy Whitcroft
2007-08-22 22:35 ` Ralf Baechle
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox