* tlbex.c
@ 2007-08-27 15:22 bo y
2007-08-29 12:04 ` tlbex.c Maciej W. Rozycki
0 siblings, 1 reply; 4+ messages in thread
From: bo y @ 2007-08-27 15:22 UTC (permalink / raw)
To: linux-mips
Should the following instruction field masks to be 0x3f ?
#define OP_MASK 0x2f
#define FUNC_MASK 0x2f
I do not see OP_MASK is used but FUNC_MASK is used in the same file.
Bo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: tlbex.c
2007-08-27 15:22 tlbex.c bo y
@ 2007-08-29 12:04 ` Maciej W. Rozycki
2007-09-05 11:11 ` tlbex.c Thiemo Seufer
0 siblings, 1 reply; 4+ messages in thread
From: Maciej W. Rozycki @ 2007-08-29 12:04 UTC (permalink / raw)
To: bo y; +Cc: linux-mips
On Mon, 27 Aug 2007, bo y wrote:
> Should the following instruction field masks to be 0x3f ?
>
> #define OP_MASK 0x2f
> #define FUNC_MASK 0x2f
>
> I do not see OP_MASK is used but FUNC_MASK is used in the same file.
Yes. Send a patch.
Maciej
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: tlbex.c
2007-08-29 12:04 ` tlbex.c Maciej W. Rozycki
@ 2007-09-05 11:11 ` Thiemo Seufer
2007-09-05 12:13 ` tlbex.c Ralf Baechle
0 siblings, 1 reply; 4+ messages in thread
From: Thiemo Seufer @ 2007-09-05 11:11 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: bo y, linux-mips, ralf
Maciej W. Rozycki wrote:
> On Mon, 27 Aug 2007, bo y wrote:
>
> > Should the following instruction field masks to be 0x3f ?
> >
> > #define OP_MASK 0x2f
> > #define FUNC_MASK 0x2f
> >
> > I do not see OP_MASK is used but FUNC_MASK is used in the same file.
>
> Yes. Send a patch.
Appended, please apply.
Thiemo
Signed-Off-By: Thiemo Seufer <ths@networkno.de>
diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
index 4ec0964..9cb3964 100644
--- a/arch/mips/mm/tlbex.c
+++ b/arch/mips/mm/tlbex.c
@@ -78,7 +78,7 @@ enum fields
SET = 0x200
};
-#define OP_MASK 0x2f
+#define OP_MASK 0x3f
#define OP_SH 26
#define RS_MASK 0x1f
#define RS_SH 21
@@ -92,7 +92,7 @@ enum fields
#define IMM_SH 0
#define JIMM_MASK 0x3ffffff
#define JIMM_SH 0
-#define FUNC_MASK 0x2f
+#define FUNC_MASK 0x3f
#define FUNC_SH 0
#define SET_MASK 0x7
#define SET_SH 0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: tlbex.c
2007-09-05 11:11 ` tlbex.c Thiemo Seufer
@ 2007-09-05 12:13 ` Ralf Baechle
0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2007-09-05 12:13 UTC (permalink / raw)
To: Thiemo Seufer; +Cc: Maciej W. Rozycki, bo y, linux-mips
On Wed, Sep 05, 2007 at 12:11:22PM +0100, Thiemo Seufer wrote:
> > > Should the following instruction field masks to be 0x3f ?
> > >
> > > #define OP_MASK 0x2f
> > > #define FUNC_MASK 0x2f
> > >
> > > I do not see OP_MASK is used but FUNC_MASK is used in the same file.
> >
> > Yes. Send a patch.
>
> Appended, please apply.
Applied, thanks.
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-09-05 12:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-27 15:22 tlbex.c bo y
2007-08-29 12:04 ` tlbex.c Maciej W. Rozycki
2007-09-05 11:11 ` tlbex.c Thiemo Seufer
2007-09-05 12:13 ` tlbex.c Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox