[tglx@linutronix.de: [PATCH] clockevents: fix bogus next_event reset for oneshot broadcast devices]

[tglx@linutronix.de: [PATCH] clockevents: fix bogus next_event reset for oneshot broadcast devices]

[Ralf Baechle]

----- Forwarded message from Thomas Gleixner <tglx@linutronix.de> -----

From: Thomas Gleixner <tglx@linutronix.de>
Date: Fri, 28 Sep 2007 00:17:04 +0200
To: LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH] clockevents: fix bogus next_event reset for oneshot
	broadcast devices
Content-Type: text/plain

In periodic broadcast mode the next_event member of the broadcast device
structure is set to KTIME_MAX in the interrupt handler. This is wrong,
as we calculate the next periodic interrupt with this variable.

Remove it.

Noticed by Ralf. MIPS is the first user of this mode, it does not affect
existing users.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-and-tested-by: Ralf Baechle <ralf@linux-mips.org>
---

diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
index 0962e05..acf15b4 100644
--- a/kernel/time/tick-broadcast.c
+++ b/kernel/time/tick-broadcast.c
@@ -176,8 +176,6 @@ static void tick_do_periodic_broadcast(void)
  */
 static void tick_handle_periodic_broadcast(struct clock_event_device *dev)
 {
-	dev->next_event.tv64 = KTIME_MAX;
-
 	tick_do_periodic_broadcast();
 
 	/*


----- End forwarded message -----

  Ralf

Re: [tglx@linutronix.de: [PATCH] clockevents: fix bogus next_event reset for oneshot broadcast devices]

[Ralf Baechle]

On Thu, Sep 27, 2007 at 11:19:56PM +0100, Ralf Baechle wrote:

> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Fri, 28 Sep 2007 00:17:04 +0200
> To: LKML <linux-kernel@vger.kernel.org>
> Cc: Andrew Morton <akpm@osdl.org>, Ralf Baechle <ralf@linux-mips.org>
> Subject: [PATCH] clockevents: fix bogus next_event reset for oneshot
> 	broadcast devices
> Content-Type: text/plain
> 
> In periodic broadcast mode the next_event member of the broadcast device
> structure is set to KTIME_MAX in the interrupt handler. This is wrong,
> as we calculate the next periodic interrupt with this variable.
> 
> Remove it.
> 
> Noticed by Ralf. MIPS is the first user of this mode, it does not affect
> existing users.

Which is a different from what I was using, so that throws somewhat of a
wrench into some of the MIPS dyntick mechanics.  But it doesn't change
the fact that this fix is correct.

  Ralf