From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: tsbogend@alpha.franken.de (Thomas Bogendoerfer)
Cc: Matteo Croce <technoboy85@gmail.com>,
linux-mips@linux-mips.org, Florian Fainelli <florian@openwrt.org>,
Felix Fietkau <nbd@openwrt.org>, Nicolas Thill <nico@openwrt.org>,
linux-serial@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH][MIPS][5/6]: AR7: serial hack
Date: Tue, 18 Mar 2008 14:01:33 +0000 [thread overview]
Message-ID: <20080318140133.3d41fd87@core> (raw)
In-Reply-To: <20080318133015.GA7239@alpha.franken.de>
> Is there a good reason, why we don't check for BOTH_EMPTY in
> serial8250_console_putchar() ? To match the 2.6.10 behaviour we
A very good one - we have at least 1 byte of FIFO and the serial-ethernet
magic console devices also use that fifo emptying entirely to deduce when
to send a new packet.
> would need that and this would fix the AR7 case without any
> special handling.
If the AR7 is an 8250 why does it need special handling? and indeed why
does serial work on it except for console - or does that fail too.
WARNING: multiple messages have this Message-ID (diff)
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Matteo Croce <technoboy85@gmail.com>,
linux-mips@linux-mips.org, Florian Fainelli <florian@openwrt.org>,
Felix Fietkau <nbd@openwrt.org>, Nicolas Thill <nico@openwrt.org>,
linux-serial@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH][MIPS][5/6]: AR7: serial hack
Date: Tue, 18 Mar 2008 14:01:33 +0000 [thread overview]
Message-ID: <20080318140133.3d41fd87@core> (raw)
Message-ID: <20080318140133.UQTVI2KbzLl7DeyxT5LEnZBMc1RIa2yN5ZPGTtI70pc@z> (raw)
In-Reply-To: <20080318133015.GA7239@alpha.franken.de>
> Is there a good reason, why we don't check for BOTH_EMPTY in
> serial8250_console_putchar() ? To match the 2.6.10 behaviour we
A very good one - we have at least 1 byte of FIFO and the serial-ethernet
magic console devices also use that fifo emptying entirely to deduce when
to send a new packet.
> would need that and this would fix the AR7 case without any
> special handling.
If the AR7 is an 8250 why does it need special handling? and indeed why
does serial work on it except for console - or does that fail too.
next prev parent reply other threads:[~2008-03-18 14:17 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 1:21 [PATCH][MIPS][0/6]: AR7 final Matteo Croce
2008-03-12 1:25 ` [PATCH][MIPS][2/6]: AR7 mtd partition map Matteo Croce
2008-03-12 1:26 ` [PATCH][MIPS][3/6]: AR7: VLYNQ bus Matteo Croce
2008-03-29 9:59 ` Florian Lohoff
2008-04-02 12:56 ` Matteo Croce
2008-04-02 18:31 ` Florian Lohoff
2008-04-03 0:19 ` Matteo Croce
2008-04-03 6:08 ` Florian Lohoff
2008-04-02 13:57 ` Matteo Croce
2008-04-02 14:58 ` Matteo Croce
2008-03-12 1:28 ` [PATCH][MIPS][4/6]: AR7 gpio Matteo Croce
2008-03-12 1:30 ` [PATCH][MIPS][5/6]: AR7: serial hack Matteo Croce
2008-03-12 9:31 ` Thomas Bogendoerfer
2008-03-13 0:38 ` Matteo Croce
2008-03-13 8:45 ` Thomas Bogendoerfer
2008-03-14 15:46 ` Matteo Croce
2008-03-15 10:40 ` Thomas Bogendoerfer
2008-03-16 15:45 ` Matteo Croce
2008-03-18 13:30 ` Thomas Bogendoerfer
2008-03-18 13:43 ` Sergei Shtylyov
2008-03-18 13:49 ` Sergei Shtylyov
2008-03-18 14:01 ` Alan Cox [this message]
2008-03-18 14:01 ` Alan Cox
2008-03-18 15:28 ` Thomas Bogendoerfer
2008-03-21 1:55 ` Thomas Bogendoerfer
2008-03-27 21:14 ` Matteo Croce
2008-03-27 21:17 ` Matteo Croce
2008-03-15 11:38 ` Alan Cox
2008-03-12 11:16 ` Alan Cox
2008-03-13 0:31 ` Matteo Croce
2008-03-13 9:01 ` Thomas Bogendoerfer
2008-03-16 15:27 ` Matteo Croce
2008-03-16 15:49 ` Matteo Croce
2008-03-12 1:34 ` [PATCH][MIPS][6/6]: AR7 leds Matteo Croce
2008-03-13 0:34 ` Matteo Croce
2008-03-12 18:06 ` [PATCH][MIPS][1/6]: AR7: core Matteo Croce
2008-03-12 19:33 ` Ralf Baechle
2008-03-29 10:34 ` Florian Lohoff
-- strict thread matches above, loose matches on Subject: below --
2008-03-18 15:40 [PATCH][MIPS][5/6]: AR7: serial hack Nico Coesel
2008-03-18 15:40 ` Nico Coesel
2007-12-27 18:19 [PATCH][MIPS][0/6]: AR7 refresh Matteo Croce
2007-12-27 18:27 ` [PATCH][MIPS][5/6]: AR7: serial hack Matteo Croce
2007-12-28 12:13 ` Sergei Shtylyov
2007-10-11 0:48 [PATCH][MIPS][0/6] AR7: AR7 strikes back Matteo Croce
2007-10-11 0:59 ` [PATCH][MIPS][5/6] AR7: serial hack Matteo Croce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080318140133.3d41fd87@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=nbd@openwrt.org \
--cc=nico@openwrt.org \
--cc=technoboy85@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox