* [PATCH 3/6] rb532: do not KSEG1ADDR an already virtual address
@ 2008-08-21 22:14 Florian Fainelli
2008-08-22 9:41 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2008-08-21 22:14 UTC (permalink / raw)
To: linux-mips; +Cc: ralf
This patch removes the superfluous double KSEG1ADDR
against the base register in the setup code.
Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
diff --git a/arch/mips/rb532/setup.c b/arch/mips/rb532/setup.c
index 7aafa95..6d3286e 100644
--- a/arch/mips/rb532/setup.c
+++ b/arch/mips/rb532/setup.c
@@ -10,6 +10,7 @@
#include <linux/ioport.h>
#include <asm/mach-rc32434/rc32434.h>
+#include <asm/mach-rc32434/rb.h>
#include <asm/mach-rc32434/pci.h>
struct pci_reg __iomem *pci_reg;
@@ -27,7 +28,7 @@ static struct resource pci0_res[] = {
static void rb_machine_restart(char *command)
{
/* just jump to the reset vector */
- writel(0x80000001, (void *)KSEG1ADDR(RC32434_REG_BASE + RC32434_RST));
+ writel(0x80000001, (void *)KSEG1ADDR(REG_BASE + RC32434_RST));
((void (*)(void)) KSEG1ADDR(0x1FC00000u))();
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 3/6] rb532: do not KSEG1ADDR an already virtual address
2008-08-21 22:14 [PATCH 3/6] rb532: do not KSEG1ADDR an already virtual address Florian Fainelli
@ 2008-08-22 9:41 ` Sergei Shtylyov
2008-08-22 14:45 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2008-08-22 9:41 UTC (permalink / raw)
To: Florian Fainelli; +Cc: linux-mips, ralf
Hello.
Florian Fainelli wrote:
> This patch removes the superfluous double KSEG1ADDR
> against the base register in the setup code.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/arch/mips/rb532/setup.c b/arch/mips/rb532/setup.c
> index 7aafa95..6d3286e 100644
> --- a/arch/mips/rb532/setup.c
> +++ b/arch/mips/rb532/setup.c
> @@ -10,6 +10,7 @@
> #include <linux/ioport.h>
>
> #include <asm/mach-rc32434/rc32434.h>
> +#include <asm/mach-rc32434/rb.h>
> #include <asm/mach-rc32434/pci.h>
>
> struct pci_reg __iomem *pci_reg;
> @@ -27,7 +28,7 @@ static struct resource pci0_res[] = {
> static void rb_machine_restart(char *command)
> {
> /* just jump to the reset vector */
> - writel(0x80000001, (void *)KSEG1ADDR(RC32434_REG_BASE + RC32434_RST));
> + writel(0x80000001, (void *)KSEG1ADDR(REG_BASE + RC32434_RST));
>
Why not just leave RC32434_REG_BASE + RC32434_RST and remove
KSEG1ADDR? BTW, the cast could be removed as well, since it's already a
part of RC32434_REG_BASE...
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 3/6] rb532: do not KSEG1ADDR an already virtual address
2008-08-22 9:41 ` Sergei Shtylyov
@ 2008-08-22 14:45 ` Florian Fainelli
0 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2008-08-22 14:45 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-mips, ralf
Hi Sergei,
Le Friday 22 August 2008 11:41:16 Sergei Shtylyov, vous avez écrit :
> Why not just leave RC32434_REG_BASE + RC32434_RST and remove
> KSEG1ADDR? BTW, the cast could be removed as well, since it's already a
> part of RC32434_REG_BASE...
In fact,I need to cleanup other headers, so I will just drop this one for now.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-08-22 14:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-21 22:14 [PATCH 3/6] rb532: do not KSEG1ADDR an already virtual address Florian Fainelli
2008-08-22 9:41 ` Sergei Shtylyov
2008-08-22 14:45 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox