[patch 2/3] drivers/rtc/rtc-ds1286.c is borked

[patch 2/3] drivers/rtc/rtc-ds1286.c is borked

[akpm]

From: Andrew Morton <akpm@linux-foundation.org>

drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl'
drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel'
drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap'
drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast
drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'

Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Alessandro Zummo <alessandro.zummo@towertech.it>
Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/rtc/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff -puN drivers/rtc/Kconfig~drivers-rtc-rtc-ds1286c-is-borked drivers/rtc/Kconfig
--- a/drivers/rtc/Kconfig~drivers-rtc-rtc-ds1286c-is-borked
+++ a/drivers/rtc/Kconfig
@@ -373,6 +373,7 @@ config RTC_DRV_DS1216
 
 config RTC_DRV_DS1286
 	tristate "Dallas DS1286"
+	depends on MIPS
 	help
 	  If you say yes here you get support for the Dallas DS1286 RTC chips.
 
_

Re: [patch 2/3] drivers/rtc/rtc-ds1286.c is borked

[Ralf Baechle]

On Wed, Oct 29, 2008 at 02:21:33PM -0700, akpm@linux-foundation.org wrote:
> From: akpm@linux-foundation.org
> Date: Wed, 29 Oct 2008 14:21:33 -0700
> To: ralf@linux-mips.org
> Cc: linux-mips@linux-mips.org, akpm@linux-foundation.org,
> 	alessandro.zummo@towertech.it, tsbogend@alpha.franken.de
> Subject: [patch 2/3] drivers/rtc/rtc-ds1286.c is borked
> 
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
> drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl'
> drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
> drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel'
> drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
> drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap'
> drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast
> drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'

Geert's patch commit ID d7a6119f457f48a94985fdbdc400cbb03e136a76 should
have solved this so you can drop this one.

  Ralf

Re: [patch 2/3] drivers/rtc/rtc-ds1286.c is borked

[Sergei Shtylyov]

Hello.

akpm@linux-foundation.org wrote:

> From: Andrew Morton <akpm@linux-foundation.org>
>
> drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
> drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl'
> drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
> drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel'
> drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
> drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap'
> drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast
> drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'
>   

   Again, on which architecture this happens?

WBR, Sergei

Re: [patch 2/3] drivers/rtc/rtc-ds1286.c is borked

[Sergei Shtylyov]

Hello, I wrote:

>> From: Andrew Morton <akpm@linux-foundation.org>
>>
>> drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
>> drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function 
>> '__raw_readl'
>> drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
>> drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function 
>> '__raw_writel'
>> drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
>> drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 
>> 'ioremap'
>> drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from 
>> integer without a cast
>> drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 
>> 'iounmap'
>>   
>
>   Again, on which architecture this happens?

   Nevermind. I was looking at already fixed drivers...

WBR, Sergei

Re: [patch 2/3] drivers/rtc/rtc-ds1286.c is borked

[Ralf Baechle]

On Thu, Oct 30, 2008 at 02:10:54PM +0300, Sergei Shtylyov wrote:
> From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Date: Thu, 30 Oct 2008 14:10:54 +0300
> To: akpm@linux-foundation.org
> Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
> 	alessandro.zummo@towertech.it, tsbogend@alpha.franken.de
> Subject: Re: [patch 2/3] drivers/rtc/rtc-ds1286.c is borked
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
> 
> Hello.
>
> akpm@linux-foundation.org wrote:
>
>> From: Andrew Morton <akpm@linux-foundation.org>
>>
>> drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
>> drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl'
>> drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
>> drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel'
>> drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
>> drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap'
>> drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast
>> drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'
>>   
>
>   Again, on which architecture this happens?

On non-MIPS.  <linux/io.h> is required to build the two files in question
but wasn't getting included explicitly.  On MIPS we were lucky; io.h
was getting dragged in indirectly through another header so things just
happened to work.

  Ralf