* [PATCH 2/3] WATCHDOG: mtx1-wdt: request gpio before using it
@ 2011-06-02 12:54 Florian Fainelli
2011-06-07 9:58 ` Jamie Iles
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2011-06-02 12:54 UTC (permalink / raw)
To: Wim Van Sebroeck, linux-mips, linux-watchdog, Manuel Lauss; +Cc: stable
Otherwise, the gpiolib autorequest feature will produce a WARN_ON():
WARNING: at drivers/gpio/gpiolib.c:101 0x8020ec6c()
autorequest GPIO-215
[...]
CC: stable@kernel.org
Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
index 63df28c..16086f8 100644
--- a/drivers/watchdog/mtx-1_wdt.c
+++ b/drivers/watchdog/mtx-1_wdt.c
@@ -214,6 +214,11 @@ static int __devinit mtx1_wdt_probe(struct platform_device *pdev)
int ret;
mtx1_wdt_device.gpio = pdev->resource[0].start;
+ ret = gpio_request(mtx1_wdt_device.gpio, "mtx1-wdt");
+ if (ret < 0) {
+ dev_err(&pdev->dev, "failed to request gpio");
+ return ret;
+ }
spin_lock_init(&mtx1_wdt_device.lock);
init_completion(&mtx1_wdt_device.stop);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] WATCHDOG: mtx1-wdt: request gpio before using it
2011-06-02 12:54 [PATCH 2/3] WATCHDOG: mtx1-wdt: request gpio before using it Florian Fainelli
@ 2011-06-07 9:58 ` Jamie Iles
2011-06-10 15:34 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Jamie Iles @ 2011-06-07 9:58 UTC (permalink / raw)
To: Florian Fainelli
Cc: Wim Van Sebroeck, linux-mips, linux-watchdog, Manuel Lauss,
stable
On Thu, Jun 02, 2011 at 02:54:20PM +0200, Florian Fainelli wrote:
> Otherwise, the gpiolib autorequest feature will produce a WARN_ON():
>
> WARNING: at drivers/gpio/gpiolib.c:101 0x8020ec6c()
> autorequest GPIO-215
> [...]
>
> CC: stable@kernel.org
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
> index 63df28c..16086f8 100644
> --- a/drivers/watchdog/mtx-1_wdt.c
> +++ b/drivers/watchdog/mtx-1_wdt.c
> @@ -214,6 +214,11 @@ static int __devinit mtx1_wdt_probe(struct platform_device *pdev)
> int ret;
>
> mtx1_wdt_device.gpio = pdev->resource[0].start;
> + ret = gpio_request(mtx1_wdt_device.gpio, "mtx1-wdt");
> + if (ret < 0) {
> + dev_err(&pdev->dev, "failed to request gpio");
> + return ret;
> + }
Could you use gpio_request_one() here to make sure the GPIO is in the
correct direction first?
Jamie
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] WATCHDOG: mtx1-wdt: request gpio before using it
2011-06-07 9:58 ` Jamie Iles
@ 2011-06-10 15:34 ` Florian Fainelli
0 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2011-06-10 15:34 UTC (permalink / raw)
To: Jamie Iles
Cc: Wim Van Sebroeck, linux-mips, linux-watchdog, Manuel Lauss,
stable
Hello Jamie,
On Tuesday 07 June 2011 11:58:47 Jamie Iles wrote:
> On Thu, Jun 02, 2011 at 02:54:20PM +0200, Florian Fainelli wrote:
> > Otherwise, the gpiolib autorequest feature will produce a WARN_ON():
> >
> > WARNING: at drivers/gpio/gpiolib.c:101 0x8020ec6c()
> > autorequest GPIO-215
> > [...]
> >
> > CC: stable@kernel.org
> > Signed-off-by: Florian Fainelli <florian@openwrt.org>
> > ---
> > diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
> > index 63df28c..16086f8 100644
> > --- a/drivers/watchdog/mtx-1_wdt.c
> > +++ b/drivers/watchdog/mtx-1_wdt.c
> > @@ -214,6 +214,11 @@ static int __devinit mtx1_wdt_probe(struct
> > platform_device *pdev)
> >
> > int ret;
> >
> > mtx1_wdt_device.gpio = pdev->resource[0].start;
> >
> > + ret = gpio_request(mtx1_wdt_device.gpio, "mtx1-wdt");
> > + if (ret < 0) {
> > + dev_err(&pdev->dev, "failed to request gpio");
> > + return ret;
> > + }
>
> Could you use gpio_request_one() here to make sure the GPIO is in the
> correct direction first?
Makes sense, I will respin a v2 of these.
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-10 15:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-02 12:54 [PATCH 2/3] WATCHDOG: mtx1-wdt: request gpio before using it Florian Fainelli
2011-06-07 9:58 ` Jamie Iles
2011-06-10 15:34 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox