From: James Hogan <james.hogan@imgtec.com>
To: John Crispin <john@phrozen.org>
Cc: Ralf Baechle <ralf@linux-mips.org>, <linux-mips@linux-mips.org>,
Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH] arch: mips: ralink: fix typo in pinctrl lna_g_func
Date: Thu, 23 Feb 2017 12:58:08 +0000 [thread overview]
Message-ID: <20170223125808.GA2878@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <1487582851-39806-1-git-send-email-john@phrozen.org>
[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]
Hi John,
On Mon, Feb 20, 2017 at 10:27:31AM +0100, John Crispin wrote:
> There is a copy & paste error in the definition of the 5GHz LNA pinmux.
>
> Tested-by: John Crispin <john@phrozen.org>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Can I have your signed off too please.
> ---
> arch/mips/ralink/rt3883.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ralink/rt3883.c b/arch/mips/ralink/rt3883.c
> index c4ffd43..f9025a0 100644
> --- a/arch/mips/ralink/rt3883.c
> +++ b/arch/mips/ralink/rt3883.c
> @@ -35,7 +35,7 @@
> static struct rt2880_pmx_func jtag_func[] = { FUNC("jtag", 0, 17, 5) };
> static struct rt2880_pmx_func mdio_func[] = { FUNC("mdio", 0, 22, 2) };
> static struct rt2880_pmx_func lna_a_func[] = { FUNC("lna a", 0, 32, 3) };
> -static struct rt2880_pmx_func lna_g_func[] = { FUNC("lna a", 0, 35, 3) };
> +static struct rt2880_pmx_func lna_g_func[] = { FUNC("lna g", 0, 35, 3) };
> static struct rt2880_pmx_func pci_func[] = {
> FUNC("pci-dev", 0, 40, 32),
> FUNC("pci-host2", 1, 40, 32),
There is at least 1 other typo in this file from that same commit:
static struct rt2880_pmx_func ge2_func[] = { FUNC("ge1", 0, 84, 12) };
Care to fix that one too?
Thanks
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: John Crispin <john@phrozen.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH] arch: mips: ralink: fix typo in pinctrl lna_g_func
Date: Thu, 23 Feb 2017 12:58:08 +0000 [thread overview]
Message-ID: <20170223125808.GA2878@jhogan-linux.le.imgtec.org> (raw)
Message-ID: <20170223125808.9tyccRdixFWibWxEhsbvlwYjiVYRwda9cSF6-BNrG5k@z> (raw)
In-Reply-To: <1487582851-39806-1-git-send-email-john@phrozen.org>
[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]
Hi John,
On Mon, Feb 20, 2017 at 10:27:31AM +0100, John Crispin wrote:
> There is a copy & paste error in the definition of the 5GHz LNA pinmux.
>
> Tested-by: John Crispin <john@phrozen.org>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Can I have your signed off too please.
> ---
> arch/mips/ralink/rt3883.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ralink/rt3883.c b/arch/mips/ralink/rt3883.c
> index c4ffd43..f9025a0 100644
> --- a/arch/mips/ralink/rt3883.c
> +++ b/arch/mips/ralink/rt3883.c
> @@ -35,7 +35,7 @@
> static struct rt2880_pmx_func jtag_func[] = { FUNC("jtag", 0, 17, 5) };
> static struct rt2880_pmx_func mdio_func[] = { FUNC("mdio", 0, 22, 2) };
> static struct rt2880_pmx_func lna_a_func[] = { FUNC("lna a", 0, 32, 3) };
> -static struct rt2880_pmx_func lna_g_func[] = { FUNC("lna a", 0, 35, 3) };
> +static struct rt2880_pmx_func lna_g_func[] = { FUNC("lna g", 0, 35, 3) };
> static struct rt2880_pmx_func pci_func[] = {
> FUNC("pci-dev", 0, 40, 32),
> FUNC("pci-host2", 1, 40, 32),
There is at least 1 other typo in this file from that same commit:
static struct rt2880_pmx_func ge2_func[] = { FUNC("ge1", 0, 84, 12) };
Care to fix that one too?
Thanks
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-02-23 12:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 9:27 [PATCH] arch: mips: ralink: fix typo in pinctrl lna_g_func John Crispin
2017-02-23 12:58 ` James Hogan [this message]
2017-02-23 12:58 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223125808.GA2878@jhogan-linux.le.imgtec.org \
--to=james.hogan@imgtec.com \
--cc=daniel@makrotopia.org \
--cc=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox