* [PATCH] arch: mips: ralink: fix typo in pinctrl lna_g_func
@ 2017-02-20 9:27 John Crispin
2017-02-23 12:58 ` James Hogan
0 siblings, 1 reply; 3+ messages in thread
From: John Crispin @ 2017-02-20 9:27 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, John Crispin, Daniel Golle
There is a copy & paste error in the definition of the 5GHz LNA pinmux.
Tested-by: John Crispin <john@phrozen.org>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
arch/mips/ralink/rt3883.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/ralink/rt3883.c b/arch/mips/ralink/rt3883.c
index c4ffd43..f9025a0 100644
--- a/arch/mips/ralink/rt3883.c
+++ b/arch/mips/ralink/rt3883.c
@@ -35,7 +35,7 @@
static struct rt2880_pmx_func jtag_func[] = { FUNC("jtag", 0, 17, 5) };
static struct rt2880_pmx_func mdio_func[] = { FUNC("mdio", 0, 22, 2) };
static struct rt2880_pmx_func lna_a_func[] = { FUNC("lna a", 0, 32, 3) };
-static struct rt2880_pmx_func lna_g_func[] = { FUNC("lna a", 0, 35, 3) };
+static struct rt2880_pmx_func lna_g_func[] = { FUNC("lna g", 0, 35, 3) };
static struct rt2880_pmx_func pci_func[] = {
FUNC("pci-dev", 0, 40, 32),
FUNC("pci-host2", 1, 40, 32),
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arch: mips: ralink: fix typo in pinctrl lna_g_func
2017-02-20 9:27 [PATCH] arch: mips: ralink: fix typo in pinctrl lna_g_func John Crispin
@ 2017-02-23 12:58 ` James Hogan
2017-02-23 12:58 ` James Hogan
0 siblings, 1 reply; 3+ messages in thread
From: James Hogan @ 2017-02-23 12:58 UTC (permalink / raw)
To: John Crispin; +Cc: Ralf Baechle, linux-mips, Daniel Golle
[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]
Hi John,
On Mon, Feb 20, 2017 at 10:27:31AM +0100, John Crispin wrote:
> There is a copy & paste error in the definition of the 5GHz LNA pinmux.
>
> Tested-by: John Crispin <john@phrozen.org>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Can I have your signed off too please.
> ---
> arch/mips/ralink/rt3883.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ralink/rt3883.c b/arch/mips/ralink/rt3883.c
> index c4ffd43..f9025a0 100644
> --- a/arch/mips/ralink/rt3883.c
> +++ b/arch/mips/ralink/rt3883.c
> @@ -35,7 +35,7 @@
> static struct rt2880_pmx_func jtag_func[] = { FUNC("jtag", 0, 17, 5) };
> static struct rt2880_pmx_func mdio_func[] = { FUNC("mdio", 0, 22, 2) };
> static struct rt2880_pmx_func lna_a_func[] = { FUNC("lna a", 0, 32, 3) };
> -static struct rt2880_pmx_func lna_g_func[] = { FUNC("lna a", 0, 35, 3) };
> +static struct rt2880_pmx_func lna_g_func[] = { FUNC("lna g", 0, 35, 3) };
> static struct rt2880_pmx_func pci_func[] = {
> FUNC("pci-dev", 0, 40, 32),
> FUNC("pci-host2", 1, 40, 32),
There is at least 1 other typo in this file from that same commit:
static struct rt2880_pmx_func ge2_func[] = { FUNC("ge1", 0, 84, 12) };
Care to fix that one too?
Thanks
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arch: mips: ralink: fix typo in pinctrl lna_g_func
2017-02-23 12:58 ` James Hogan
@ 2017-02-23 12:58 ` James Hogan
0 siblings, 0 replies; 3+ messages in thread
From: James Hogan @ 2017-02-23 12:58 UTC (permalink / raw)
To: John Crispin; +Cc: Ralf Baechle, linux-mips, Daniel Golle
[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]
Hi John,
On Mon, Feb 20, 2017 at 10:27:31AM +0100, John Crispin wrote:
> There is a copy & paste error in the definition of the 5GHz LNA pinmux.
>
> Tested-by: John Crispin <john@phrozen.org>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Can I have your signed off too please.
> ---
> arch/mips/ralink/rt3883.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ralink/rt3883.c b/arch/mips/ralink/rt3883.c
> index c4ffd43..f9025a0 100644
> --- a/arch/mips/ralink/rt3883.c
> +++ b/arch/mips/ralink/rt3883.c
> @@ -35,7 +35,7 @@
> static struct rt2880_pmx_func jtag_func[] = { FUNC("jtag", 0, 17, 5) };
> static struct rt2880_pmx_func mdio_func[] = { FUNC("mdio", 0, 22, 2) };
> static struct rt2880_pmx_func lna_a_func[] = { FUNC("lna a", 0, 32, 3) };
> -static struct rt2880_pmx_func lna_g_func[] = { FUNC("lna a", 0, 35, 3) };
> +static struct rt2880_pmx_func lna_g_func[] = { FUNC("lna g", 0, 35, 3) };
> static struct rt2880_pmx_func pci_func[] = {
> FUNC("pci-dev", 0, 40, 32),
> FUNC("pci-host2", 1, 40, 32),
There is at least 1 other typo in this file from that same commit:
static struct rt2880_pmx_func ge2_func[] = { FUNC("ge1", 0, 84, 12) };
Care to fix that one too?
Thanks
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-23 12:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-20 9:27 [PATCH] arch: mips: ralink: fix typo in pinctrl lna_g_func John Crispin
2017-02-23 12:58 ` James Hogan
2017-02-23 12:58 ` James Hogan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox