* [PATCH v2] bcma: Prevent build of PCI host features in module
@ 2018-03-01 9:58 Matt Redfearn
2018-03-01 9:58 ` Matt Redfearn
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Matt Redfearn @ 2018-03-01 9:58 UTC (permalink / raw)
To: kvalo; +Cc: zajec5, linux-wireless, linux-mips, jhogan, Matt Redfearn
Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in
a build error due to use of symbols not exported from vmlinux:
ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined!
ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
To prevent this, don't allow the host mode feature to be built if
CONFIG_BCMA=m
Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>
---
Changes in v2:
Rebase on v4.16-rc1
drivers/bcma/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index ba8acca036df..cb0f1aad20b7 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
@@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI
config BCMA_DRIVER_PCI_HOSTMODE
bool "Driver for PCI core working in hostmode"
- depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY
+ depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY && BCMA = y
help
PCI core hostmode operation (external PCI bus).
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2] bcma: Prevent build of PCI host features in module 2018-03-01 9:58 [PATCH v2] bcma: Prevent build of PCI host features in module Matt Redfearn @ 2018-03-01 9:58 ` Matt Redfearn 2018-03-01 10:45 ` Kalle Valo 2018-03-13 16:48 ` [v2] " Kalle Valo 2 siblings, 0 replies; 10+ messages in thread From: Matt Redfearn @ 2018-03-01 9:58 UTC (permalink / raw) To: kvalo; +Cc: zajec5, linux-wireless, linux-mips, jhogan, Matt Redfearn Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in a build error due to use of symbols not exported from vmlinux: ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined! ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined! make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 To prevent this, don't allow the host mode feature to be built if CONFIG_BCMA=m Signed-off-by: Matt Redfearn <matt.redfearn@mips.com> --- Changes in v2: Rebase on v4.16-rc1 drivers/bcma/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig index ba8acca036df..cb0f1aad20b7 100644 --- a/drivers/bcma/Kconfig +++ b/drivers/bcma/Kconfig @@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI config BCMA_DRIVER_PCI_HOSTMODE bool "Driver for PCI core working in hostmode" - depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY + depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY && BCMA = y help PCI core hostmode operation (external PCI bus). -- 2.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] bcma: Prevent build of PCI host features in module 2018-03-01 9:58 [PATCH v2] bcma: Prevent build of PCI host features in module Matt Redfearn 2018-03-01 9:58 ` Matt Redfearn @ 2018-03-01 10:45 ` Kalle Valo 2018-03-01 10:45 ` Kalle Valo 2018-03-02 17:56 ` Larry Finger 2018-03-13 16:48 ` [v2] " Kalle Valo 2 siblings, 2 replies; 10+ messages in thread From: Kalle Valo @ 2018-03-01 10:45 UTC (permalink / raw) To: Matt Redfearn; +Cc: zajec5, linux-wireless, linux-mips, jhogan Matt Redfearn <matt.redfearn@mips.com> writes: > Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in > a build error due to use of symbols not exported from vmlinux: > > ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined! > ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 > > To prevent this, don't allow the host mode feature to be built if > CONFIG_BCMA=m > > Signed-off-by: Matt Redfearn <matt.redfearn@mips.com> > > --- > > Changes in v2: > Rebase on v4.16-rc1 > > drivers/bcma/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig > index ba8acca036df..cb0f1aad20b7 100644 > --- a/drivers/bcma/Kconfig > +++ b/drivers/bcma/Kconfig > @@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI > > config BCMA_DRIVER_PCI_HOSTMODE > bool "Driver for PCI core working in hostmode" > - depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY > + depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY && BCMA = y Due to the recent regression in bcma I would prefer extra careful review before I apply this. So does this look ok to everyone? -- Kalle Valo ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] bcma: Prevent build of PCI host features in module 2018-03-01 10:45 ` Kalle Valo @ 2018-03-01 10:45 ` Kalle Valo 2018-03-02 17:56 ` Larry Finger 1 sibling, 0 replies; 10+ messages in thread From: Kalle Valo @ 2018-03-01 10:45 UTC (permalink / raw) To: Matt Redfearn; +Cc: zajec5, linux-wireless, linux-mips, jhogan Matt Redfearn <matt.redfearn@mips.com> writes: > Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in > a build error due to use of symbols not exported from vmlinux: > > ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined! > ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 > > To prevent this, don't allow the host mode feature to be built if > CONFIG_BCMA=m > > Signed-off-by: Matt Redfearn <matt.redfearn@mips.com> > > --- > > Changes in v2: > Rebase on v4.16-rc1 > > drivers/bcma/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig > index ba8acca036df..cb0f1aad20b7 100644 > --- a/drivers/bcma/Kconfig > +++ b/drivers/bcma/Kconfig > @@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI > > config BCMA_DRIVER_PCI_HOSTMODE > bool "Driver for PCI core working in hostmode" > - depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY > + depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY && BCMA = y Due to the recent regression in bcma I would prefer extra careful review before I apply this. So does this look ok to everyone? -- Kalle Valo ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] bcma: Prevent build of PCI host features in module 2018-03-01 10:45 ` Kalle Valo 2018-03-01 10:45 ` Kalle Valo @ 2018-03-02 17:56 ` Larry Finger 2018-03-08 12:00 ` Matt Redfearn 1 sibling, 1 reply; 10+ messages in thread From: Larry Finger @ 2018-03-02 17:56 UTC (permalink / raw) To: Kalle Valo, Matt Redfearn; +Cc: zajec5, linux-wireless, linux-mips, jhogan On 03/01/2018 04:45 AM, Kalle Valo wrote: > Matt Redfearn <matt.redfearn@mips.com> writes: > >> Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in >> a build error due to use of symbols not exported from vmlinux: >> >> ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined! >> ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined! >> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 >> >> To prevent this, don't allow the host mode feature to be built if >> CONFIG_BCMA=m >> >> Signed-off-by: Matt Redfearn <matt.redfearn@mips.com> >> >> --- >> >> Changes in v2: >> Rebase on v4.16-rc1 >> >> drivers/bcma/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig >> index ba8acca036df..cb0f1aad20b7 100644 >> --- a/drivers/bcma/Kconfig >> +++ b/drivers/bcma/Kconfig >> @@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI >> >> config BCMA_DRIVER_PCI_HOSTMODE >> bool "Driver for PCI core working in hostmode" >> - depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY >> + depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY && BCMA = y > > Due to the recent regression in bcma I would prefer extra careful review > before I apply this. So does this look ok to everyone? I have a preference for wireless device drivers to be modules. For that reason, I would have submitted a patch exporting those two missing globals rather than forcing bcma to be built in. That said, it seems that the patch will do no further harm. Larry ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] bcma: Prevent build of PCI host features in module 2018-03-02 17:56 ` Larry Finger @ 2018-03-08 12:00 ` Matt Redfearn 2018-03-08 12:00 ` Matt Redfearn 2018-03-10 11:35 ` Jonas Gorski 0 siblings, 2 replies; 10+ messages in thread From: Matt Redfearn @ 2018-03-08 12:00 UTC (permalink / raw) To: Larry Finger, Kalle Valo; +Cc: zajec5, linux-wireless, linux-mips, jhogan Hi, On 02/03/18 17:56, Larry Finger wrote: > On 03/01/2018 04:45 AM, Kalle Valo wrote: >> Matt Redfearn <matt.redfearn@mips.com> writes: >> >>> Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in >>> a build error due to use of symbols not exported from vmlinux: >>> >>> ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined! >>> ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined! >>> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 >>> >>> To prevent this, don't allow the host mode feature to be built if >>> CONFIG_BCMA=m >>> >>> Signed-off-by: Matt Redfearn <matt.redfearn@mips.com> >>> >>> --- >>> >>> Changes in v2: >>> Rebase on v4.16-rc1 >>> >>> drivers/bcma/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig >>> index ba8acca036df..cb0f1aad20b7 100644 >>> --- a/drivers/bcma/Kconfig >>> +++ b/drivers/bcma/Kconfig >>> @@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI >>> config BCMA_DRIVER_PCI_HOSTMODE >>> bool "Driver for PCI core working in hostmode" >>> - depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY >>> + depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY && BCMA >>> = y >> >> Due to the recent regression in bcma I would prefer extra careful review >> before I apply this. So does this look ok to everyone? > > I have a preference for wireless device drivers to be modules. For that > reason, I would have submitted a patch exporting those two missing > globals rather than forcing bcma to be built in. That said, it seems > that the patch will do no further harm. This patch was purely intended to fix the build breakage caused by attempting to build host-mode PCI into a module, which fails due to necessary symbols not being exported by the kernel for use by modules. Making it possible to build the driver including host mode may not be as trivial as "lets just export the symbols", and testing that it works correctly once it can be built as a module will require hardware with this device present (which I don't have). So I would propose that this patch be merged as is, since as you say, it does no further harm - it should just fix build breakage - and if the driver, including this host mode feature, is really required as a module, perhaps someone with access to the hardware could spin a patch to implement that. Thanks, Matt > > Larry > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] bcma: Prevent build of PCI host features in module 2018-03-08 12:00 ` Matt Redfearn @ 2018-03-08 12:00 ` Matt Redfearn 2018-03-10 11:35 ` Jonas Gorski 1 sibling, 0 replies; 10+ messages in thread From: Matt Redfearn @ 2018-03-08 12:00 UTC (permalink / raw) To: Larry Finger, Kalle Valo; +Cc: zajec5, linux-wireless, linux-mips, jhogan Hi, On 02/03/18 17:56, Larry Finger wrote: > On 03/01/2018 04:45 AM, Kalle Valo wrote: >> Matt Redfearn <matt.redfearn@mips.com> writes: >> >>> Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in >>> a build error due to use of symbols not exported from vmlinux: >>> >>> ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined! >>> ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined! >>> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 >>> >>> To prevent this, don't allow the host mode feature to be built if >>> CONFIG_BCMA=m >>> >>> Signed-off-by: Matt Redfearn <matt.redfearn@mips.com> >>> >>> --- >>> >>> Changes in v2: >>> Rebase on v4.16-rc1 >>> >>> drivers/bcma/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig >>> index ba8acca036df..cb0f1aad20b7 100644 >>> --- a/drivers/bcma/Kconfig >>> +++ b/drivers/bcma/Kconfig >>> @@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI >>> config BCMA_DRIVER_PCI_HOSTMODE >>> bool "Driver for PCI core working in hostmode" >>> - depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY >>> + depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY && BCMA >>> = y >> >> Due to the recent regression in bcma I would prefer extra careful review >> before I apply this. So does this look ok to everyone? > > I have a preference for wireless device drivers to be modules. For that > reason, I would have submitted a patch exporting those two missing > globals rather than forcing bcma to be built in. That said, it seems > that the patch will do no further harm. This patch was purely intended to fix the build breakage caused by attempting to build host-mode PCI into a module, which fails due to necessary symbols not being exported by the kernel for use by modules. Making it possible to build the driver including host mode may not be as trivial as "lets just export the symbols", and testing that it works correctly once it can be built as a module will require hardware with this device present (which I don't have). So I would propose that this patch be merged as is, since as you say, it does no further harm - it should just fix build breakage - and if the driver, including this host mode feature, is really required as a module, perhaps someone with access to the hardware could spin a patch to implement that. Thanks, Matt > > Larry > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] bcma: Prevent build of PCI host features in module 2018-03-08 12:00 ` Matt Redfearn 2018-03-08 12:00 ` Matt Redfearn @ 2018-03-10 11:35 ` Jonas Gorski 1 sibling, 0 replies; 10+ messages in thread From: Jonas Gorski @ 2018-03-10 11:35 UTC (permalink / raw) To: Matt Redfearn Cc: Larry Finger, Kalle Valo, Rafał Miłecki, linux-wireless, MIPS Mailing List, James Hogan Hi, On 8 March 2018 at 13:00, Matt Redfearn <matt.redfearn@mips.com> wrote: > Hi, > > > On 02/03/18 17:56, Larry Finger wrote: >> >> On 03/01/2018 04:45 AM, Kalle Valo wrote: >>> >>> Matt Redfearn <matt.redfearn@mips.com> writes: >>> >>>> Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in >>>> a build error due to use of symbols not exported from vmlinux: >>>> >>>> ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined! >>>> ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined! >>>> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 >>>> >>>> To prevent this, don't allow the host mode feature to be built if >>>> CONFIG_BCMA=m >>>> >>>> Signed-off-by: Matt Redfearn <matt.redfearn@mips.com> >>>> >>>> --- >>>> >>>> Changes in v2: >>>> Rebase on v4.16-rc1 >>>> >>>> drivers/bcma/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig >>>> index ba8acca036df..cb0f1aad20b7 100644 >>>> --- a/drivers/bcma/Kconfig >>>> +++ b/drivers/bcma/Kconfig >>>> @@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI >>>> config BCMA_DRIVER_PCI_HOSTMODE >>>> bool "Driver for PCI core working in hostmode" >>>> - depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY >>>> + depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY && BCMA = >>>> y >>> >>> >>> Due to the recent regression in bcma I would prefer extra careful review >>> before I apply this. So does this look ok to everyone? >> >> >> I have a preference for wireless device drivers to be modules. For that >> reason, I would have submitted a patch exporting those two missing globals >> rather than forcing bcma to be built in. That said, it seems that the patch >> will do no further harm. > > > > This patch was purely intended to fix the build breakage caused by > attempting to build host-mode PCI into a module, which fails due to > necessary symbols not being exported by the kernel for use by modules. > > Making it possible to build the driver including host mode may not be as > trivial as "lets just export the symbols", and testing that it works > correctly once it can be built as a module will require hardware with this > device present (which I don't have). > > So I would propose that this patch be merged as is, since as you say, it > does no further harm - it should just fix build breakage - and if the > driver, including this host mode feature, is really required as a module, > perhaps someone with access to the hardware could spin a patch to implement > that. These aren't the actual wireless drivers, just the bus drivers. The actual wireless drivers (b43 / brcmsmac) can still be built as a module. Also those systems that use/need the pci host driver of ssb/bcma actually need ssb/bcma built-in anyway, as it also provides serial console, interrupt routing, flash access, and other early init stuff. At best one could rewrite the pci host core driver as a standalone bcma driver, and then one could allow it to be built as a module. But I'm not sure if it's worth it. Regards Jonas ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [v2] bcma: Prevent build of PCI host features in module 2018-03-01 9:58 [PATCH v2] bcma: Prevent build of PCI host features in module Matt Redfearn 2018-03-01 9:58 ` Matt Redfearn 2018-03-01 10:45 ` Kalle Valo @ 2018-03-13 16:48 ` Kalle Valo 2018-03-13 16:48 ` Kalle Valo 2 siblings, 1 reply; 10+ messages in thread From: Kalle Valo @ 2018-03-13 16:48 UTC (permalink / raw) To: Matt Redfearn; +Cc: zajec5, linux-wireless, linux-mips, jhogan, Matt Redfearn Matt Redfearn <matt.redfearn@mips.com> wrote: > Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in > a build error due to use of symbols not exported from vmlinux: > > ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined! > ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 > > To prevent this, don't allow the host mode feature to be built if > CONFIG_BCMA=m > > Signed-off-by: Matt Redfearn <matt.redfearn@mips.com> Patch applied to wireless-drivers-next.git, thanks. 79ca239a68f8 bcma: Prevent build of PCI host features in module -- https://patchwork.kernel.org/patch/10250739/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [v2] bcma: Prevent build of PCI host features in module 2018-03-13 16:48 ` [v2] " Kalle Valo @ 2018-03-13 16:48 ` Kalle Valo 0 siblings, 0 replies; 10+ messages in thread From: Kalle Valo @ 2018-03-13 16:48 UTC (permalink / raw) To: Matt Redfearn; +Cc: zajec5, linux-wireless, linux-mips, jhogan Matt Redfearn <matt.redfearn@mips.com> wrote: > Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in > a build error due to use of symbols not exported from vmlinux: > > ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined! > ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 > > To prevent this, don't allow the host mode feature to be built if > CONFIG_BCMA=m > > Signed-off-by: Matt Redfearn <matt.redfearn@mips.com> Patch applied to wireless-drivers-next.git, thanks. 79ca239a68f8 bcma: Prevent build of PCI host features in module -- https://patchwork.kernel.org/patch/10250739/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-03-13 16:48 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-03-01 9:58 [PATCH v2] bcma: Prevent build of PCI host features in module Matt Redfearn 2018-03-01 9:58 ` Matt Redfearn 2018-03-01 10:45 ` Kalle Valo 2018-03-01 10:45 ` Kalle Valo 2018-03-02 17:56 ` Larry Finger 2018-03-08 12:00 ` Matt Redfearn 2018-03-08 12:00 ` Matt Redfearn 2018-03-10 11:35 ` Jonas Gorski 2018-03-13 16:48 ` [v2] " Kalle Valo 2018-03-13 16:48 ` Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox