From: Serge Semin <fancer.lancer@gmail.com>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>,
Paul Cercueil <paul@crapouillou.net>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH 1/2] MIPS: Allow MIPS32R2 kernel to run on P5600 and M5150
Date: Tue, 30 May 2023 16:33:48 +0300 [thread overview]
Message-ID: <20230530133348.2jsrbkh6kixonwbm@mobilestation> (raw)
In-Reply-To: <5CC33034-4AF3-4522-9942-8BCCEF1086AE@flygoat.com>
On Tue, May 30, 2023 at 02:10:04PM +0100, Jiaxun Yang wrote:
>
>
> > 2023年5月30日 13:16，Maciej W. Rozycki <macro@orcam.me.uk> 写道：
> >
> > On Tue, 30 May 2023, Jiaxun Yang wrote:
> >
> >>> Sure, but this change is not needed for it. You just need to declare
> >>> which ISA revisions your platform supports and leave `__get_cpu_type'
> >>> alone. It has worked like that for a decade now.
> >>
> >> I’m afraid it won’t work as you expected.
> >>
> >> Actually I ran into a problem that `case CPU_P5600` in c-r4k.c is optimised out
> >> by compiler, because the codepath is marked as unreachable.
> >
> > Maybe there's a bug elsewhere then. Send me your .config and I'll try to
> > reproduce it.
>
> Ok I see the problem, after applying patch 2 the issue is gone.
> So actually only patch 2 is necessary.
>
> The unreachable mark here leads gcc to generate some confusing code
> and I misread it.
>
> Sorry for the noise.
Great! Indeed enabling the SYS_HAS_CPU_MIPS32_R5 config is enough to
stop the CPU_P5600 being optimized out. Thanks for your work. Let me
know if you need some tests on another instance of the P5600 hw.
-Serge(y)
>
> Thanks
> - Jiaxun
>
> >
> > Maciej
>
prev parent reply other threads:[~2023-05-30 13:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 13:52 [PATCH 1/2] MIPS: Allow MIPS32R2 kernel to run on P5600 and M5150 Jiaxun Yang
2023-05-29 13:52 ` [PATCH 2/2] MIPS: generic: Allow R5 CPUs to be selected Jiaxun Yang
2023-05-30 13:37 ` Serge Semin
2023-06-09 8:21 ` Thomas Bogendoerfer
2023-05-30 8:03 ` [PATCH 1/2] MIPS: Allow MIPS32R2 kernel to run on P5600 and M5150 Maciej W. Rozycki
2023-05-30 8:18 ` Paul Cercueil
2023-05-30 9:13 ` Maciej W. Rozycki
2023-05-30 10:11 ` Jiaxun Yang
2023-05-30 11:07 ` Maciej W. Rozycki
2023-05-30 11:54 ` Jiaxun Yang
2023-05-30 12:16 ` Maciej W. Rozycki
2023-05-30 12:41 ` Serge Semin
2023-05-30 12:51 ` Serge Semin
2023-05-30 12:57 ` Jiaxun Yang
2023-05-30 13:10 ` Jiaxun Yang
2023-05-30 13:14 ` Maciej W. Rozycki
2023-05-30 13:33 ` Serge Semin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530133348.2jsrbkh6kixonwbm@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=paul@crapouillou.net \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox