[PATCH] Au1xx0: really set KSEG0 to uncached on reboot

[PATCH] Au1xx0: really set KSEG0 to uncached on reboot

[Sergei Shtylylov]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

Hello.

    Just found really old buglet in AMD Au1xx0 restart code: instead of
modifying the whole CP0 Config.K0 field to 010b (meaning KSEG0 uncached) 
before flushing the caches and resetting a board, it only sets bit 1 of that 
reg. which is effectively a NOP since Config.K0 == 011b as the kernel sets it 
up (which is also its default value for Au1xx0).

WBR, Sergei


[-- Attachment #2: Au1xx0-make-KSEG0-uncached-on-reboot.patch --]
[-- Type: text/plain, Size: 415 bytes --]

diff --git a/arch/mips/au1000/common/reset.c b/arch/mips/au1000/common/reset.c
index 65b84db..4ffcced 100644
--- a/arch/mips/au1000/common/reset.c
+++ b/arch/mips/au1000/common/reset.c
@@ -151,7 +151,7 @@ void au1000_restart(char *command)
 	}
 
 	set_c0_status(ST0_BEV | ST0_ERL);
-	set_c0_config(CONF_CM_UNCACHED);
+	change_c0_config(CONF_CM_CMASK, CONF_CM_UNCACHED);
 	flush_cache_all();
 	write_c0_wired(0);
 

[PATCH] Au1xx0: really set KSEG0 to uncached on reboot

[Sergei Shtylylov]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

Hello.

     Resending with signoffs...

     Just found really old buglet in AMD Au1xx0 restart code: instead of
modifying the whole CP0 Config.K0 field to 010b (meaning KSEG0 uncached)
before flushing the caches and resetting a board, it only sets bit 1 of that
reg. which is effectively a NOP since Config.K0 == 011b as the kernel sets it
up (which is also its default value for Au1xx0).

WBR, Sergei

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>


[-- Attachment #2: Au1xx0-make-KSEG0-uncached-on-reboot.patch --]
[-- Type: text/plain, Size: 416 bytes --]

diff --git a/arch/mips/au1000/common/reset.c b/arch/mips/au1000/common/reset.c
index 65b84db..4ffcced 100644
--- a/arch/mips/au1000/common/reset.c
+++ b/arch/mips/au1000/common/reset.c
@@ -151,7 +151,7 @@ void au1000_restart(char *command)
 	}
 
 	set_c0_status(ST0_BEV | ST0_ERL);
-	set_c0_config(CONF_CM_UNCACHED);
+	change_c0_config(CONF_CM_CMASK, CONF_CM_UNCACHED);
 	flush_cache_all();
 	write_c0_wired(0);
 

[PATCH] Au1xx0: really set KSEG0 to uncached on reboot

[David Sanchez]

Hi,

The patch doesn't work for Au1550. Since I apply it my DbAu1550 frees on
restart.

David

[PATCH] Au1xx0: really set KSEG0 to uncached on reboot

[David Sanchez]

Hi,

The patch doesn't work for Au1550. Since I apply it my DbAu1550 frees on
restart.

David

Re: [PATCH] Au1xx0: really set KSEG0 to uncached on reboot

[Sergei Shtylylov]

Hello.

David Sanchez wrote:

> The patch doesn't work for Au1550. Since I apply it my DbAu1550 frees on
> restart.

    Just tried 'reboot' command on a fresh kernel with this patch and NFP 
userland -- it worked well.

> David

WBR, Sergei

RE: [PATCH] Au1xx0: really set KSEG0 to uncached on reboot

[David Sanchez]

Hi,

This is exactly what I did...
But I notice that sometimes it works and sometimes the kernel frees when 
"** Resetting Integrated Peripherals"

Regards,

David SANCHEZ
 LexBox, The Digital Evidence

Parc d'Activités de Basso Cambo
42, Avenue du Général de Croutte
31100 TOULOUSE / FRANCE

david.sanchez@lexbox.fr
Tél :     +33 (0)5 62 47 15 81
Fax :    +33 (0)5 62 47 15 84



-----Message d'origine-----
De : Sergei Shtylylov [mailto:sshtylyov@ru.mvista.com] 
Envoyé : samedi 4 février 2006 01:30
À : David Sanchez
Cc : linux-mips@linux-mips.org
Objet : Re: [PATCH] Au1xx0: really set KSEG0 to uncached on reboot

Hello.

David Sanchez wrote:

> The patch doesn't work for Au1550. Since I apply it my DbAu1550 frees on
> restart.

    Just tried 'reboot' command on a fresh kernel with this patch and NFP 
userland -- it worked well.

> David

WBR, Sergei

RE: [PATCH] Au1xx0: really set KSEG0 to uncached on reboot

[David Sanchez]

Hi,

This is exactly what I did...
But I notice that sometimes it works and sometimes the kernel frees when 
"** Resetting Integrated Peripherals"

Regards,

David SANCHEZ
 LexBox, The Digital Evidence

Parc d'Activités de Basso Cambo
42, Avenue du Général de Croutte
31100 TOULOUSE / FRANCE

david.sanchez@lexbox.fr
Tél :     +33 (0)5 62 47 15 81
Fax :    +33 (0)5 62 47 15 84



-----Message d'origine-----
De : Sergei Shtylylov [mailto:sshtylyov@ru.mvista.com] 
Envoyé : samedi 4 février 2006 01:30
À : David Sanchez
Cc : linux-mips@linux-mips.org
Objet : Re: [PATCH] Au1xx0: really set KSEG0 to uncached on reboot

Hello.

David Sanchez wrote:

> The patch doesn't work for Au1550. Since I apply it my DbAu1550 frees on
> restart.

    Just tried 'reboot' command on a fresh kernel with this patch and NFP 
userland -- it worked well.

> David

WBR, Sergei