* Add errno definition to pm.h
@ 2007-07-30 15:38 Songmao Tian
2007-07-30 15:45 ` Steven J. Hill
0 siblings, 1 reply; 3+ messages in thread
From: Songmao Tian @ 2007-07-30 15:38 UTC (permalink / raw)
To: linux-mips
commit 296699de6bdc717189a331ab6bbe90e05c94db06 add
static inline int pm_suspend(suspend_state_t state) { return -ENOSYS; }
which need errno definition
Signed-off-by: Songmao Tian <tiansm@lemote.com>
diff --git a/include/linux/pm.h b/include/linux/pm.h
index e52f6f8..48b71ba 100644
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -25,6 +25,7 @@
#include <linux/list.h>
#include <asm/atomic.h>
+#include <asm/errno.h>
/*
* Power management requests... these are passed to pm_send_all() and
friends.
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: Add errno definition to pm.h
2007-07-30 15:38 Add errno definition to pm.h Songmao Tian
@ 2007-07-30 15:45 ` Steven J. Hill
2007-07-31 0:46 ` Songmao Tian
0 siblings, 1 reply; 3+ messages in thread
From: Steven J. Hill @ 2007-07-30 15:45 UTC (permalink / raw)
To: Songmao Tian; +Cc: linux-mips
On Mon, Jul 30, 2007 at 11:38:06PM +0800, Songmao Tian wrote:
> commit 296699de6bdc717189a331ab6bbe90e05c94db06 add
> static inline int pm_suspend(suspend_state_t state) { return -ENOSYS; }
> which need errno definition
>
> Signed-off-by: Songmao Tian <tiansm@lemote.com>
>
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> index e52f6f8..48b71ba 100644
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -25,6 +25,7 @@
>
> #include <linux/list.h>
> #include <asm/atomic.h>
> +#include <asm/errno.h>
>
You should be including <linux/errno.h> which then includes the
architecture-specific file. This patch should be rejected.
-Steve
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Add errno definition to pm.h
2007-07-30 15:45 ` Steven J. Hill
@ 2007-07-31 0:46 ` Songmao Tian
0 siblings, 0 replies; 3+ messages in thread
From: Songmao Tian @ 2007-07-31 0:46 UTC (permalink / raw)
To: Steven J. Hill; +Cc: linux-mips
Steven J. Hill wrote:
> On Mon, Jul 30, 2007 at 11:38:06PM +0800, Songmao Tian wrote:
>
>> commit 296699de6bdc717189a331ab6bbe90e05c94db06 add
>> static inline int pm_suspend(suspend_state_t state) { return -ENOSYS; }
>> which need errno definition
>>
>> Signed-off-by: Songmao Tian <tiansm@lemote.com>
>>
>> diff --git a/include/linux/pm.h b/include/linux/pm.h
>> index e52f6f8..48b71ba 100644
>> --- a/include/linux/pm.h
>> +++ b/include/linux/pm.h
>> @@ -25,6 +25,7 @@
>>
>> #include <linux/list.h>
>> #include <asm/atomic.h>
>> +#include <asm/errno.h>
>>
>>
> You should be including <linux/errno.h> which then includes the
> architecture-specific file. This patch should be rejected.
>
> -Steve
>
>
>
>
Oh I see:)
Songmao Tian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-31 0:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-30 15:38 Add errno definition to pm.h Songmao Tian
2007-07-30 15:45 ` Steven J. Hill
2007-07-31 0:46 ` Songmao Tian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox