Linux MIPS Architecture development
 help / color / mirror / Atom feed
* [PATCH 0/3] Alchemy: consolidate board code, v2
@ 2008-11-08 12:08 Manuel Lauss
  2008-11-08 12:08 ` [PATCH 1/3] Alchemy: merge small board files into single files Manuel Lauss
                   ` (2 more replies)
  0 siblings, 3 replies; 19+ messages in thread
From: Manuel Lauss @ 2008-11-08 12:08 UTC (permalink / raw)
  To: Linux-MIPS; +Cc: Sergei Shtylyov, Florian Fainelli, Bruno Randolf, Manuel Lauss

Hello,

(CC'ing Florian and Bruno since they have shown interest in the MTX-1
 code in the past).

This is v2 of my attempts to consolidate Alchemy board code.  This
patchset mostly moves code around with no intented functional changes.

Changes v1->v2:
- amended 2/3 as per Sergeis suggestions,
- simplified 3/3:  now all boards can override the reset/poweroff hooks
  if they want to; no changes for all existing in-tree users.
  (although I'd still like to kill off alchemy/common/reset.c or at least
  move it away from the other CPU-specific code).  This should also
  alleviate all of Sergei's remaining points.


Patch overview:
1/3:	in all boards dirs, merge the irqmap.c/init.c files into
	board_setup.c.

2/3:	create a common subdirectory for Alchemy evalboards; extract
	the prom code which is (almost) identical for all of them.
	Also extract the code augmenting the commandline from
	alchemy/common and sprinkle existing board init code with it.
	Not every board should be forced to have a serial console on UART0.

3/3:	allow boards to override default alchemy reset/poweroff hooks.

All patches have been compile-tested with all Alchemy boards available
in KConfig and tested on Db1200.

Feedback and Testers welcome!

Thanks,
	Manuel Lauss


Manuel Lauss (3):
  Alchemy: merge small board files into single files
  Alchemy: Move evalboard code to common directory
  Alchemy: allow boards to override default reset/poweroff functions.

 arch/mips/Makefile                             |   24 +-
 arch/mips/alchemy/common/setup.c               |   33 +---
 arch/mips/alchemy/db1x00/Makefile              |    8 -
 arch/mips/alchemy/db1x00/board_setup.c         |  108 ---------
 arch/mips/alchemy/db1x00/init.c                |   62 -----
 arch/mips/alchemy/db1x00/irqmap.c              |   86 -------
 arch/mips/alchemy/evalboards/Makefile          |   17 ++
 arch/mips/alchemy/evalboards/common.c          |   62 +++++
 arch/mips/alchemy/evalboards/db1x00.c          |  206 ++++++++++++++++
 arch/mips/alchemy/evalboards/pb1000.c          |  196 +++++++++++++++
 arch/mips/alchemy/evalboards/pb1100.c          |  150 ++++++++++++
 arch/mips/alchemy/evalboards/pb1200.c          |  301 ++++++++++++++++++++++++
 arch/mips/alchemy/evalboards/pb1200_platform.c |  166 +++++++++++++
 arch/mips/alchemy/evalboards/pb1500.c          |  156 ++++++++++++
 arch/mips/alchemy/evalboards/pb1550.c          |   86 +++++++
 arch/mips/alchemy/mtx-1/Makefile               |    2 +-
 arch/mips/alchemy/mtx-1/board_setup.c          |   60 +++++-
 arch/mips/alchemy/mtx-1/init.c                 |   60 -----
 arch/mips/alchemy/mtx-1/irqmap.c               |   52 ----
 arch/mips/alchemy/pb1000/Makefile              |    8 -
 arch/mips/alchemy/pb1000/board_setup.c         |  165 -------------
 arch/mips/alchemy/pb1000/init.c                |   57 -----
 arch/mips/alchemy/pb1000/irqmap.c              |   38 ---
 arch/mips/alchemy/pb1100/Makefile              |    8 -
 arch/mips/alchemy/pb1100/board_setup.c         |  109 ---------
 arch/mips/alchemy/pb1100/init.c                |   60 -----
 arch/mips/alchemy/pb1100/irqmap.c              |   40 ---
 arch/mips/alchemy/pb1200/Makefile              |    8 -
 arch/mips/alchemy/pb1200/board_setup.c         |  162 -------------
 arch/mips/alchemy/pb1200/init.c                |   58 -----
 arch/mips/alchemy/pb1200/irqmap.c              |  160 -------------
 arch/mips/alchemy/pb1200/platform.c            |  166 -------------
 arch/mips/alchemy/pb1500/Makefile              |    8 -
 arch/mips/alchemy/pb1500/board_setup.c         |  119 ----------
 arch/mips/alchemy/pb1500/init.c                |   58 -----
 arch/mips/alchemy/pb1500/irqmap.c              |   46 ----
 arch/mips/alchemy/pb1550/Makefile              |    8 -
 arch/mips/alchemy/pb1550/board_setup.c         |   58 -----
 arch/mips/alchemy/pb1550/init.c                |   58 -----
 arch/mips/alchemy/pb1550/irqmap.c              |   43 ----
 arch/mips/alchemy/xxs1500/Makefile             |    2 +-
 arch/mips/alchemy/xxs1500/board_setup.c        |   59 +++++-
 arch/mips/alchemy/xxs1500/init.c               |   58 -----
 arch/mips/alchemy/xxs1500/irqmap.c             |   49 ----
 44 files changed, 1473 insertions(+), 1967 deletions(-)
 delete mode 100644 arch/mips/alchemy/db1x00/Makefile
 delete mode 100644 arch/mips/alchemy/db1x00/board_setup.c
 delete mode 100644 arch/mips/alchemy/db1x00/init.c
 delete mode 100644 arch/mips/alchemy/db1x00/irqmap.c
 create mode 100644 arch/mips/alchemy/evalboards/Makefile
 create mode 100644 arch/mips/alchemy/evalboards/common.c
 create mode 100644 arch/mips/alchemy/evalboards/db1x00.c
 create mode 100644 arch/mips/alchemy/evalboards/pb1000.c
 create mode 100644 arch/mips/alchemy/evalboards/pb1100.c
 create mode 100644 arch/mips/alchemy/evalboards/pb1200.c
 create mode 100644 arch/mips/alchemy/evalboards/pb1200_platform.c
 create mode 100644 arch/mips/alchemy/evalboards/pb1500.c
 create mode 100644 arch/mips/alchemy/evalboards/pb1550.c
 delete mode 100644 arch/mips/alchemy/mtx-1/init.c
 delete mode 100644 arch/mips/alchemy/mtx-1/irqmap.c
 delete mode 100644 arch/mips/alchemy/pb1000/Makefile
 delete mode 100644 arch/mips/alchemy/pb1000/board_setup.c
 delete mode 100644 arch/mips/alchemy/pb1000/init.c
 delete mode 100644 arch/mips/alchemy/pb1000/irqmap.c
 delete mode 100644 arch/mips/alchemy/pb1100/Makefile
 delete mode 100644 arch/mips/alchemy/pb1100/board_setup.c
 delete mode 100644 arch/mips/alchemy/pb1100/init.c
 delete mode 100644 arch/mips/alchemy/pb1100/irqmap.c
 delete mode 100644 arch/mips/alchemy/pb1200/Makefile
 delete mode 100644 arch/mips/alchemy/pb1200/board_setup.c
 delete mode 100644 arch/mips/alchemy/pb1200/init.c
 delete mode 100644 arch/mips/alchemy/pb1200/irqmap.c
 delete mode 100644 arch/mips/alchemy/pb1200/platform.c
 delete mode 100644 arch/mips/alchemy/pb1500/Makefile
 delete mode 100644 arch/mips/alchemy/pb1500/board_setup.c
 delete mode 100644 arch/mips/alchemy/pb1500/init.c
 delete mode 100644 arch/mips/alchemy/pb1500/irqmap.c
 delete mode 100644 arch/mips/alchemy/pb1550/Makefile
 delete mode 100644 arch/mips/alchemy/pb1550/board_setup.c
 delete mode 100644 arch/mips/alchemy/pb1550/init.c
 delete mode 100644 arch/mips/alchemy/pb1550/irqmap.c
 delete mode 100644 arch/mips/alchemy/xxs1500/init.c
 delete mode 100644 arch/mips/alchemy/xxs1500/irqmap.c

^ permalink raw reply	[flat|nested] 19+ messages in thread
* [PATCH 0/3] Alchemy: consolidate board code
@ 2008-11-07 18:41 Manuel Lauss
  2008-11-07 18:41 ` [PATCH 1/3] Alchemy: merge small board files into single files Manuel Lauss
  0 siblings, 1 reply; 19+ messages in thread
From: Manuel Lauss @ 2008-11-07 18:41 UTC (permalink / raw)
  To: Linux-MIPS; +Cc: Manuel Lauss

The following 3 patches aim to consolidate the alchemy board code
at bit.  The patched basically only move code around; no functional
changes (and tons of checkpatch warnings from the original code).

1/3:	in all evalboard dirs, merge the irqmap.c/init.c files into
	board_setup.c
2/3:	create a common subdirectory for Alchemy evalboards.
3/3:	extract remaining reset/init code from common/ subdir and move
	it to evalboard/.  I added reboot hook initialization to
	the mtx-1 and xxs1500 boards since the removal of common/reset.c
	their reboot functions no longer get called automagically.

All patches have been compile-tested with all Alchemy boards available
for selection in KConfig and tested on Db1200.

I have a few other patched which overhaul Alchemy IRQ code, so I'd like
to get this out of the way first.

Feedback and Testers welcome!

Thanks,
	Manuel Lauss

--- 

Manuel Lauss (3):
  Alchemy: merge small board files into single files
  Alchemy: Move evalboard code to common directory
  Alchemy: common reset code is evalboard code.

 arch/mips/Makefile                             |   24 +-
 arch/mips/alchemy/common/Makefile              |    2 +-
 arch/mips/alchemy/common/reset.c               |  189 ---------------
 arch/mips/alchemy/common/setup.c               |   39 ---
 arch/mips/alchemy/db1x00/Makefile              |    8 -
 arch/mips/alchemy/db1x00/board_setup.c         |  108 ---------
 arch/mips/alchemy/db1x00/init.c                |   62 -----
 arch/mips/alchemy/db1x00/irqmap.c              |   86 -------
 arch/mips/alchemy/evalboards/Makefile          |   17 ++
 arch/mips/alchemy/evalboards/common.c          |  253 ++++++++++++++++++++
 arch/mips/alchemy/evalboards/db1x00.c          |  182 +++++++++++++++
 arch/mips/alchemy/evalboards/pb1000.c          |  181 +++++++++++++++
 arch/mips/alchemy/evalboards/pb1100.c          |  127 ++++++++++
 arch/mips/alchemy/evalboards/pb1200.c          |  296 ++++++++++++++++++++++++
 arch/mips/alchemy/evalboards/pb1200_platform.c |  166 +++++++++++++
 arch/mips/alchemy/evalboards/pb1500.c          |  143 ++++++++++++
 arch/mips/alchemy/evalboards/pb1550.c          |   79 +++++++
 arch/mips/alchemy/mtx-1/Makefile               |    2 +-
 arch/mips/alchemy/mtx-1/board_setup.c          |   57 +++++-
 arch/mips/alchemy/mtx-1/init.c                 |   60 -----
 arch/mips/alchemy/mtx-1/irqmap.c               |   52 ----
 arch/mips/alchemy/pb1000/Makefile              |    8 -
 arch/mips/alchemy/pb1000/board_setup.c         |  165 -------------
 arch/mips/alchemy/pb1000/init.c                |   57 -----
 arch/mips/alchemy/pb1000/irqmap.c              |   38 ---
 arch/mips/alchemy/pb1100/Makefile              |    8 -
 arch/mips/alchemy/pb1100/board_setup.c         |  109 ---------
 arch/mips/alchemy/pb1100/init.c                |   60 -----
 arch/mips/alchemy/pb1100/irqmap.c              |   40 ----
 arch/mips/alchemy/pb1200/Makefile              |    8 -
 arch/mips/alchemy/pb1200/board_setup.c         |  162 -------------
 arch/mips/alchemy/pb1200/init.c                |   58 -----
 arch/mips/alchemy/pb1200/irqmap.c              |  160 -------------
 arch/mips/alchemy/pb1200/platform.c            |  166 -------------
 arch/mips/alchemy/pb1500/Makefile              |    8 -
 arch/mips/alchemy/pb1500/board_setup.c         |  119 ----------
 arch/mips/alchemy/pb1500/init.c                |   58 -----
 arch/mips/alchemy/pb1500/irqmap.c              |   46 ----
 arch/mips/alchemy/pb1550/Makefile              |    8 -
 arch/mips/alchemy/pb1550/board_setup.c         |   58 -----
 arch/mips/alchemy/pb1550/init.c                |   58 -----
 arch/mips/alchemy/pb1550/irqmap.c              |   43 ----
 arch/mips/alchemy/xxs1500/Makefile             |    2 +-
 arch/mips/alchemy/xxs1500/board_setup.c        |   55 ++++-
 arch/mips/alchemy/xxs1500/init.c               |   58 -----
 arch/mips/alchemy/xxs1500/irqmap.c             |   49 ----
 46 files changed, 1565 insertions(+), 2169 deletions(-)
 delete mode 100644 arch/mips/alchemy/common/reset.c
 delete mode 100644 arch/mips/alchemy/db1x00/Makefile
 delete mode 100644 arch/mips/alchemy/db1x00/board_setup.c
 delete mode 100644 arch/mips/alchemy/db1x00/init.c
 delete mode 100644 arch/mips/alchemy/db1x00/irqmap.c
 create mode 100644 arch/mips/alchemy/evalboards/Makefile
 create mode 100644 arch/mips/alchemy/evalboards/common.c
 create mode 100644 arch/mips/alchemy/evalboards/db1x00.c
 create mode 100644 arch/mips/alchemy/evalboards/pb1000.c
 create mode 100644 arch/mips/alchemy/evalboards/pb1100.c
 create mode 100644 arch/mips/alchemy/evalboards/pb1200.c
 create mode 100644 arch/mips/alchemy/evalboards/pb1200_platform.c
 create mode 100644 arch/mips/alchemy/evalboards/pb1500.c
 create mode 100644 arch/mips/alchemy/evalboards/pb1550.c
 delete mode 100644 arch/mips/alchemy/mtx-1/init.c
 delete mode 100644 arch/mips/alchemy/mtx-1/irqmap.c
 delete mode 100644 arch/mips/alchemy/pb1000/Makefile
 delete mode 100644 arch/mips/alchemy/pb1000/board_setup.c
 delete mode 100644 arch/mips/alchemy/pb1000/init.c
 delete mode 100644 arch/mips/alchemy/pb1000/irqmap.c
 delete mode 100644 arch/mips/alchemy/pb1100/Makefile
 delete mode 100644 arch/mips/alchemy/pb1100/board_setup.c
 delete mode 100644 arch/mips/alchemy/pb1100/init.c
 delete mode 100644 arch/mips/alchemy/pb1100/irqmap.c
 delete mode 100644 arch/mips/alchemy/pb1200/Makefile
 delete mode 100644 arch/mips/alchemy/pb1200/board_setup.c
 delete mode 100644 arch/mips/alchemy/pb1200/init.c
 delete mode 100644 arch/mips/alchemy/pb1200/irqmap.c
 delete mode 100644 arch/mips/alchemy/pb1200/platform.c
 delete mode 100644 arch/mips/alchemy/pb1500/Makefile
 delete mode 100644 arch/mips/alchemy/pb1500/board_setup.c
 delete mode 100644 arch/mips/alchemy/pb1500/init.c
 delete mode 100644 arch/mips/alchemy/pb1500/irqmap.c
 delete mode 100644 arch/mips/alchemy/pb1550/Makefile
 delete mode 100644 arch/mips/alchemy/pb1550/board_setup.c
 delete mode 100644 arch/mips/alchemy/pb1550/init.c
 delete mode 100644 arch/mips/alchemy/pb1550/irqmap.c
 delete mode 100644 arch/mips/alchemy/xxs1500/init.c
 delete mode 100644 arch/mips/alchemy/xxs1500/irqmap.c

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2008-11-12 16:20 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-08 12:08 [PATCH 0/3] Alchemy: consolidate board code, v2 Manuel Lauss
2008-11-08 12:08 ` [PATCH 1/3] Alchemy: merge small board files into single files Manuel Lauss
2008-11-12  3:54   ` Kevin Hickey
2008-11-12  6:05     ` Manuel Lauss
2008-11-08 12:08 ` [PATCH 2/3] Alchemy: Move evalboard code to common directory Manuel Lauss
2008-11-12  4:00   ` Kevin Hickey
2008-11-12  6:06     ` Manuel Lauss
2008-11-12 10:38       ` Sergei Shtylyov
2008-11-12 10:55         ` Sergei Shtylyov
2008-11-12 10:35     ` Sergei Shtylyov
2008-11-12 12:05       ` Manuel Lauss
2008-11-12 13:39         ` Kevin Hickey
2008-11-12 13:38       ` Kevin Hickey
2008-11-12 15:45         ` Maciej W. Rozycki
2008-11-12 15:52           ` Sergei Shtylyov
2008-11-12 16:16             ` Maciej W. Rozycki
2008-11-12 16:20               ` Sergei Shtylyov
2008-11-08 12:08 ` [PATCH 3/3] Alchemy: allow boards to override default reset/poweroff functions Manuel Lauss
  -- strict thread matches above, loose matches on Subject: below --
2008-11-07 18:41 [PATCH 0/3] Alchemy: consolidate board code Manuel Lauss
2008-11-07 18:41 ` [PATCH 1/3] Alchemy: merge small board files into single files Manuel Lauss
     [not found]   ` <cover.1226083170.git.mano@roarinelk.homelinux.net>
2008-11-07 18:41     ` [PATCH 2/3] Alchemy: Move evalboard code to common directory Manuel Lauss

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox