Re: [PATCH] OF: MIPS: sead3: Implement OF support.

[John Crispin <john@phrozen.org>]

Hi,

>   obj-y				+= sead3-i2c-dev.o sead3-i2c.o \
> @@ -17,3 +19,11 @@ obj-y				+= sead3-i2c-dev.o sead3-i2c.o \
>
>   obj-$(CONFIG_EARLY_PRINTK)	+= sead3-console.o
>   obj-$(CONFIG_USB_EHCI_HCD)	+= sead3-ehci.o
> +
> +DTS_FILES = sead3.dts
> +DTB_FILES = $(patsubst %.dts, %.dtb, $(DTS_FILES))
> +
> +obj-y += $(patsubst %.dts, %.dtb.o, $(DTS_FILES))
> +
> +$(obj)/%.dtb: $(obj)/%.dts FORCE
> +	$(call if_changed_dep,dtc)

there is a patch already in -next that obseletes this


> +void __init device_tree_init(void)
> +{
> +	unsigned long base, size;
> +
> +	if (!initial_boot_params)
> +		return;
> +
> +	base = virt_to_phys((void *)initial_boot_params);
> +	size = be32_to_cpu(initial_boot_params->totalsize);
> +
> +	/* Before we do anything, lets reserve the dt blob */
> +	reserve_bootmem(base, size, BOOTMEM_DEFAULT);
> +
> +	unflatten_device_tree();
> +
> +	/* free the space reserved for the dt blob */
> +	free_bootmem(base, size);

this free is one free too many. it will kill the devcietree. the code 
where you copied this from has been fixed in -next



John