From: Florian Fainelli <florian@openwrt.org>
To: "Steven J. Hill" <sjhill@mips.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH] OF: MIPS: sead3: Implement OF support.
Date: Wed, 12 Dec 2012 15:29:40 +0100 [thread overview]
Message-ID: <50C894D4.4090008@openwrt.org> (raw)
In-Reply-To: <1354857297-28863-1-git-send-email-sjhill@mips.com>
Hello Steven,
Le 12/07/12 06:14, Steven J. Hill a écrit :
[snip]
> +/ {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "mips,sead-3";
> +
> + cpus {
> + cpu@0 {
> + compatible = "mips,mips14Kc,mips14KEc";
> + };
You probably want this the other way around:
mips14KEc,mips14Kc,mips
you should always have the left-most string being the most descriptive
about the hardware and the last one being the less descriptive and thus
less "specializing" in order to be backward compatible.
> + };
> +
> + chosen {
> + bootargs = "console=ttyS1,38400 rootdelay=10 root=/dev/sda3";
> + };
> +
> + memory {
> + device_type = "memory";
> + reg = <0x0 0x08000000>;
> + };
> +};
>
next prev parent reply other threads:[~2012-12-12 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 5:14 [PATCH] OF: MIPS: sead3: Implement OF support Steven J. Hill
2012-12-07 7:40 ` John Crispin
2012-12-12 14:29 ` Florian Fainelli [this message]
2012-12-12 14:53 ` Lars-Peter Clausen
2012-12-12 14:55 ` Ralf Baechle
2012-12-12 15:01 ` Florian Fainelli
2012-12-12 15:12 ` Ralf Baechle
2012-12-12 15:15 ` Florian Fainelli
2012-12-12 14:56 ` Florian Fainelli
2012-12-14 5:02 ` Hill, Steven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C894D4.4090008@openwrt.org \
--to=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sjhill@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox