From: Florian Fainelli <florian@openwrt.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: "Steven J. Hill" <sjhill@mips.com>,
linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH] OF: MIPS: sead3: Implement OF support.
Date: Wed, 12 Dec 2012 15:56:44 +0100 [thread overview]
Message-ID: <50C89B2C.1070903@openwrt.org> (raw)
In-Reply-To: <50C89A6C.705@metafoo.de>
Le 12/12/12 15:53, Lars-Peter Clausen a écrit :
> On 12/12/2012 03:29 PM, Florian Fainelli wrote:
>> Hello Steven,
>>
>> Le 12/07/12 06:14, Steven J. Hill a écrit :
>> [snip]
>>
>>> +/ {
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + compatible = "mips,sead-3";
>>> +
>>> + cpus {
>>> + cpu@0 {
>>> + compatible = "mips,mips14Kc,mips14KEc";
>>> + };
>> You probably want this the other way around:
>>
>> mips14KEc,mips14Kc,mips
>>
>> you should always have the left-most string being the most descriptive about
>> the hardware and the last one being the less descriptive and thus less
>> "specializing" in order to be backward compatible.
> This is one compatible string though, what you describe is for when use
> multiple compatible string. E.g.
> compatible = "mips14KEc", "mips14Kc", "mips";
>
> The "mips" in Stevens patch is probably the vendor prefix. Maybe a more
> correct compatible would be.
>
> compatible = "mips,mips14KEc", "mips,mips14Kc";
Right, this should be the proper compatible string. Steven's patch does
not make any use of this compatible string right now anyway.
>
> But in anyway the patch should also add documentation under
> Documentation/devicetree/bindings describing the binding.
>
Obviously
--
Florian
next prev parent reply other threads:[~2012-12-12 14:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 5:14 [PATCH] OF: MIPS: sead3: Implement OF support Steven J. Hill
2012-12-07 7:40 ` John Crispin
2012-12-12 14:29 ` Florian Fainelli
2012-12-12 14:53 ` Lars-Peter Clausen
2012-12-12 14:55 ` Ralf Baechle
2012-12-12 15:01 ` Florian Fainelli
2012-12-12 15:12 ` Ralf Baechle
2012-12-12 15:15 ` Florian Fainelli
2012-12-12 14:56 ` Florian Fainelli [this message]
2012-12-14 5:02 ` Hill, Steven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C89B2C.1070903@openwrt.org \
--to=florian@openwrt.org \
--cc=lars@metafoo.de \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sjhill@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox