From: Gabor Juhos <juhosg@openwrt.org>
To: John Crispin <blogic@openwrt.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH V2 09/16] MIPS: ralink: adds support for RT2880 SoC family
Date: Fri, 12 Apr 2013 19:03:15 +0200 [thread overview]
Message-ID: <51683E53.8040208@openwrt.org> (raw)
In-Reply-To: <5167EDAE.4020000@openwrt.org>
2013.04.12. 13:19 keltezéssel, John Crispin írta:
> On 12/04/13 13:12, Gabor Juhos wrote:
>> The commit log says that the code registers the pinmux settings. However the
>> patch only contains the definitions of the pinmux groups without doing anything
>> with those. Additionally, the structures and the 'rt288x_wdt_reset' function
>> should be static.
>>
>> However converting them to static would cause compiler warnings about unused
>> variables/functions. So it would be simpler to remove these. You have removed
>> the pinmux driver from the series anyway, and this part can't be used without
>> that.
>
>
> the same was done for rt305x and causes no harm, so I really don't see a problem
> with adding these now.
You are right, it causes no harm explicitly. Simply it adds dead code which will
be built into the kernel and it will never run.
> i will address the "static" bit for the next series
Don't bother with that. Adding static declaration for unused variables/functions
give us nothing but compiler warnings.
-Gabor
next prev parent reply other threads:[~2013-04-12 17:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 7:27 [PATCH V2 01/16] MIPS: ralink: add PCI IRQ handling John Crispin
2013-04-12 7:27 ` [PATCH V2 02/16] MIPS: ralink: fix RT305x clock setup John Crispin
2013-04-12 8:22 ` Gabor Juhos
2013-04-12 8:21 ` John Crispin
2013-04-12 13:00 ` Sergei Shtylyov
2013-04-12 7:27 ` [PATCH V2 03/16] MIPS: ralink: add missing comment in irq driver John Crispin
2013-04-12 8:24 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 04/16] MIPS: ralink: add RT5350 sdram register defines John Crispin
2013-04-12 8:29 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 05/16] MIPS: ralink: add RT3352 usb " John Crispin
2013-04-12 8:47 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 06/16] MIPS: ralink: extend RT3050 dtsi file John Crispin
2013-04-12 9:22 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 07/16] MIPS: ralink: add RT5350 " John Crispin
2013-04-12 9:25 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 08/16] MIPS: ralink: make early_printk work on RT2880 John Crispin
2013-04-12 9:28 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 09/16] MIPS: ralink: adds support for RT2880 SoC family John Crispin
2013-04-12 11:12 ` Gabor Juhos
2013-04-12 11:19 ` John Crispin
2013-04-12 17:03 ` Gabor Juhos [this message]
2013-04-12 7:27 ` [PATCH V2 10/16] MIPS: ralink: add rt2880 dts files John Crispin
2013-04-12 7:27 ` [PATCH V2 11/16] MIPS: ralink: adds support for RT3883 SoC family John Crispin
2013-04-12 11:13 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 12/16] MIPS: ralink: add rt3883 dts files John Crispin
2013-04-12 7:27 ` [PATCH V2 13/16] MIPS: ralink: adds support for MT7620 SoC family John Crispin
2013-04-12 7:27 ` [PATCH V2 14/16] MIPS: ralink: add MT7620 dts files John Crispin
2013-04-12 7:27 ` [PATCH V2 15/16] MIPS: ralink: add support for periodic timer irq John Crispin
2013-04-12 16:35 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 16/16] MIPS: ralink: add cpu-feature-overrides.h John Crispin
2013-04-12 17:20 ` Gabor Juhos
2013-04-12 8:21 ` [PATCH V2 01/16] MIPS: ralink: add PCI IRQ handling Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51683E53.8040208@openwrt.org \
--to=juhosg@openwrt.org \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox