* [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency
@ 2013-04-13 9:39 John Crispin
2013-04-13 9:39 ` [PATCH 2/2] tty: serial: ralink: select SERIAL_8250_RT288X when ralink kernel is built John Crispin
2013-04-15 18:15 ` [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency Greg Kroah-Hartman
0 siblings, 2 replies; 5+ messages in thread
From: John Crispin @ 2013-04-13 9:39 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-mips, linux-serial, John Crispin
With every Ralink SoC that we add, we would need to extend the dependency. In
order to make life easier we make the symbol depend on MIPS & RALINK and then
select it from within arch/mips/ralink/.
Signed-off-by: John Crispin <blogic@openwrt.org>
---
These 2 patches in this series should be merged via the mips tree. Patch 1/2
requires an Ack from the tty maintainer.
drivers/tty/serial/8250/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index 80fe91e..24ea3c8 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -295,8 +295,8 @@ config SERIAL_8250_EM
If unsure, say N.
config SERIAL_8250_RT288X
- bool "Ralink RT288x/RT305x/RT3662/RT3883 serial port support"
- depends on SERIAL_8250 && (SOC_RT288X || SOC_RT305X || SOC_RT3883)
+ bool
+ depends on SERIAL_8250 && MIPS && RALINK
help
If you have a Ralink RT288x/RT305x SoC based board and want to use the
serial port, say Y to this option. The driver can handle up to 2 serial
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] tty: serial: ralink: select SERIAL_8250_RT288X when ralink kernel is built
2013-04-13 9:39 [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency John Crispin
@ 2013-04-13 9:39 ` John Crispin
2013-04-15 18:15 ` [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency Greg Kroah-Hartman
1 sibling, 0 replies; 5+ messages in thread
From: John Crispin @ 2013-04-13 9:39 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-mips, linux-serial, John Crispin
We need to select SERIAL_8250_RT288X to make the uart work on ralink SoC.
Signed-off-by: John Crispin <blogic@openwrt.org>
---
arch/mips/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index b237c50..da9fd66 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -444,6 +444,7 @@ config RALINK
select HAVE_MACH_CLKDEV
select CLKDEV_LOOKUP
select ARCH_REQUIRE_GPIOLIB
+ select SERIAL_8250_RT288X
config SGI_IP22
bool "SGI IP22 (Indy/Indigo2)"
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency
2013-04-13 9:39 [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency John Crispin
2013-04-13 9:39 ` [PATCH 2/2] tty: serial: ralink: select SERIAL_8250_RT288X when ralink kernel is built John Crispin
@ 2013-04-15 18:15 ` Greg Kroah-Hartman
2013-04-16 3:57 ` John Crispin
1 sibling, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2013-04-15 18:15 UTC (permalink / raw)
To: John Crispin; +Cc: linux-mips, linux-serial
On Sat, Apr 13, 2013 at 11:39:32AM +0200, John Crispin wrote:
> With every Ralink SoC that we add, we would need to extend the dependency. In
> order to make life easier we make the symbol depend on MIPS & RALINK and then
> select it from within arch/mips/ralink/.
>
> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
>
> These 2 patches in this series should be merged via the mips tree. Patch 1/2
> requires an Ack from the tty maintainer.
>
> drivers/tty/serial/8250/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
> index 80fe91e..24ea3c8 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -295,8 +295,8 @@ config SERIAL_8250_EM
> If unsure, say N.
>
> config SERIAL_8250_RT288X
> - bool "Ralink RT288x/RT305x/RT3662/RT3883 serial port support"
> - depends on SERIAL_8250 && (SOC_RT288X || SOC_RT305X || SOC_RT3883)
> + bool
> + depends on SERIAL_8250 && MIPS && RALINK
This patch doesn't create a select anywhere, so how can a user know what
to do here?
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency
2013-04-15 18:15 ` [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency Greg Kroah-Hartman
@ 2013-04-16 3:57 ` John Crispin
2013-04-16 4:08 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: John Crispin @ 2013-04-16 3:57 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-mips, linux-serial
On 15/04/13 20:15, Greg Kroah-Hartman wrote:
> On Sat, Apr 13, 2013 at 11:39:32AM +0200, John Crispin wrote:
>> With every Ralink SoC that we add, we would need to extend the dependency. In
>> order to make life easier we make the symbol depend on MIPS& RALINK and then
>> select it from within arch/mips/ralink/.
>>
>> Signed-off-by: John Crispin<blogic@openwrt.org>
>> ---
>>
>> These 2 patches in this series should be merged via the mips tree. Patch 1/2
>> requires an Ack from the tty maintainer.
>>
>> drivers/tty/serial/8250/Kconfig | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
>> index 80fe91e..24ea3c8 100644
>> --- a/drivers/tty/serial/8250/Kconfig
>> +++ b/drivers/tty/serial/8250/Kconfig
>> @@ -295,8 +295,8 @@ config SERIAL_8250_EM
>> If unsure, say N.
>>
>> config SERIAL_8250_RT288X
>> - bool "Ralink RT288x/RT305x/RT3662/RT3883 serial port support"
>> - depends on SERIAL_8250&& (SOC_RT288X || SOC_RT305X || SOC_RT3883)
>> + bool
>> + depends on SERIAL_8250&& MIPS&& RALINK
>
> This patch doesn't create a select anywhere, so how can a user know what
> to do here?
>
> greg k-h
Hi Greg,
The select happens in patch 2/2. i split it up as it touches a different
subsystem. I can put both changes into the same patch. would that be
acceptable ?
John
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency
2013-04-16 3:57 ` John Crispin
@ 2013-04-16 4:08 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2013-04-16 4:08 UTC (permalink / raw)
To: John Crispin; +Cc: linux-mips, linux-serial
On Tue, Apr 16, 2013 at 05:57:26AM +0200, John Crispin wrote:
> On 15/04/13 20:15, Greg Kroah-Hartman wrote:
> >On Sat, Apr 13, 2013 at 11:39:32AM +0200, John Crispin wrote:
> >>With every Ralink SoC that we add, we would need to extend the dependency. In
> >>order to make life easier we make the symbol depend on MIPS& RALINK and then
> >>select it from within arch/mips/ralink/.
> >>
> >>Signed-off-by: John Crispin<blogic@openwrt.org>
> >>---
> >>
> >>These 2 patches in this series should be merged via the mips tree. Patch 1/2
> >>requires an Ack from the tty maintainer.
> >>
> >> drivers/tty/serial/8250/Kconfig | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >>diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
> >>index 80fe91e..24ea3c8 100644
> >>--- a/drivers/tty/serial/8250/Kconfig
> >>+++ b/drivers/tty/serial/8250/Kconfig
> >>@@ -295,8 +295,8 @@ config SERIAL_8250_EM
> >> If unsure, say N.
> >>
> >> config SERIAL_8250_RT288X
> >>- bool "Ralink RT288x/RT305x/RT3662/RT3883 serial port support"
> >>- depends on SERIAL_8250&& (SOC_RT288X || SOC_RT305X || SOC_RT3883)
> >>+ bool
> >>+ depends on SERIAL_8250&& MIPS&& RALINK
> >
> >This patch doesn't create a select anywhere, so how can a user know what
> >to do here?
> >
> >greg k-h
>
> Hi Greg,
>
> The select happens in patch 2/2. i split it up as it touches a
> different subsystem. I can put both changes into the same patch.
> would that be acceptable ?
That would make more sense, don't you think?
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-16 4:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-13 9:39 [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency John Crispin
2013-04-13 9:39 ` [PATCH 2/2] tty: serial: ralink: select SERIAL_8250_RT288X when ralink kernel is built John Crispin
2013-04-15 18:15 ` [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency Greg Kroah-Hartman
2013-04-16 3:57 ` John Crispin
2013-04-16 4:08 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox