* [PATCH 1/2] MIPS: Move CPU topology macros to topology.h
@ 2014-08-08 3:16 Huacai Chen
2014-08-08 3:16 ` [PATCH 2/2] MIPS: Loongson: Fix COP2 usage for preemptible kernel Huacai Chen
2014-08-08 13:47 ` [PATCH 1/2] MIPS: Move CPU topology macros to topology.h Ralf Baechle
0 siblings, 2 replies; 12+ messages in thread
From: Huacai Chen @ 2014-08-08 3:16 UTC (permalink / raw)
To: Ralf Baechle
Cc: John Crispin, Steven J. Hill, Aurelien Jarno, linux-mips,
Fuxin Zhang, Zhangjin Wu, Huacai Chen, Jayachandran C.
This fix macros redefinition problems for Netlogic.
Signed-off-by: Huacai Chen <chenhc@lemote.com>
Cc: Jayachandran C. <jchandra@broadcom.com>
---
arch/mips/include/asm/smp.h | 5 -----
arch/mips/include/asm/topology.h | 13 +++++++++++++
2 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/arch/mips/include/asm/smp.h b/arch/mips/include/asm/smp.h
index 1e0f20a..eacf865 100644
--- a/arch/mips/include/asm/smp.h
+++ b/arch/mips/include/asm/smp.h
@@ -37,11 +37,6 @@ extern int __cpu_logical_map[NR_CPUS];
#define NO_PROC_ID (-1)
-#define topology_physical_package_id(cpu) (cpu_data[cpu].package)
-#define topology_core_id(cpu) (cpu_data[cpu].core)
-#define topology_core_cpumask(cpu) (&cpu_core_map[cpu])
-#define topology_thread_cpumask(cpu) (&cpu_sibling_map[cpu])
-
#define SMP_RESCHEDULE_YOURSELF 0x1 /* XXX braindead */
#define SMP_CALL_FUNCTION 0x2
/* Octeon - Tell another core to flush its icache */
diff --git a/arch/mips/include/asm/topology.h b/arch/mips/include/asm/topology.h
index 20ea485..2a0f04b 100644
--- a/arch/mips/include/asm/topology.h
+++ b/arch/mips/include/asm/topology.h
@@ -10,4 +10,17 @@
#include <topology.h>
+#ifndef topology_physical_package_id
+#define topology_physical_package_id(cpu) (cpu_data[cpu].package)
+#endif
+#ifndef topology_core_id
+#define topology_core_id(cpu) (cpu_data[cpu].core)
+#endif
+#ifndef topology_core_cpumask
+#define topology_core_cpumask(cpu) (&cpu_core_map[cpu])
+#endif
+#ifndef topology_thread_cpumask
+#define topology_thread_cpumask(cpu) (&cpu_sibling_map[cpu])
+#endif
+
#endif /* __ASM_TOPOLOGY_H */
--
1.7.7.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] MIPS: Loongson: Fix COP2 usage for preemptible kernel
2014-08-08 3:16 [PATCH 1/2] MIPS: Move CPU topology macros to topology.h Huacai Chen
@ 2014-08-08 3:16 ` Huacai Chen
2014-08-08 12:12 ` Sergei Shtylyov
2014-08-08 13:47 ` [PATCH 1/2] MIPS: Move CPU topology macros to topology.h Ralf Baechle
1 sibling, 1 reply; 12+ messages in thread
From: Huacai Chen @ 2014-08-08 3:16 UTC (permalink / raw)
To: Ralf Baechle
Cc: John Crispin, Steven J. Hill, Aurelien Jarno, linux-mips,
Fuxin Zhang, Zhangjin Wu, Huacai Chen
In preemptible kernel, only TIF_USEDFPU flag is reliable to distinguish
whether _init_fpu()/_restore_fp() is needed. Because the value of the
CP0_Status.CU1 isn't changed during preemption.
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
arch/mips/loongson/loongson-3/cop2-ex.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/mips/loongson/loongson-3/cop2-ex.c b/arch/mips/loongson/loongson-3/cop2-ex.c
index 9182e8d..c1e9503 100644
--- a/arch/mips/loongson/loongson-3/cop2-ex.c
+++ b/arch/mips/loongson/loongson-3/cop2-ex.c
@@ -22,13 +22,13 @@
static int loongson_cu2_call(struct notifier_block *nfb, unsigned long action,
void *data)
{
- int fpu_enabled;
+ int fpu_owned;
int fr = !test_thread_flag(TIF_32BIT_FPREGS);
switch (action) {
case CU2_EXCEPTION:
preempt_disable();
- fpu_enabled = read_c0_status() & ST0_CU1;
+ fpu_owned = __is_fpu_owner();
if (!fr)
set_c0_status(ST0_CU1 | ST0_CU2);
else
@@ -39,8 +39,8 @@ static int loongson_cu2_call(struct notifier_block *nfb, unsigned long action,
KSTK_STATUS(current) |= ST0_FR;
else
KSTK_STATUS(current) &= ~ST0_FR;
- /* If FPU is enabled, we needn't init or restore fp */
- if(!fpu_enabled) {
+ /* If FPU is owned, we needn't init or restore fp */
+ if(!fpu_owned) {
set_thread_flag(TIF_USEDFPU);
if (!used_math()) {
_init_fpu();
--
1.7.7.3
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] MIPS: Loongson: Fix COP2 usage for preemptible kernel
2014-08-08 3:16 ` [PATCH 2/2] MIPS: Loongson: Fix COP2 usage for preemptible kernel Huacai Chen
@ 2014-08-08 12:12 ` Sergei Shtylyov
0 siblings, 0 replies; 12+ messages in thread
From: Sergei Shtylyov @ 2014-08-08 12:12 UTC (permalink / raw)
To: Huacai Chen, Ralf Baechle
Cc: John Crispin, Steven J. Hill, Aurelien Jarno, linux-mips,
Fuxin Zhang, Zhangjin Wu
Hello.
On 8/8/2014 7:16 AM, Huacai Chen wrote:
> In preemptible kernel, only TIF_USEDFPU flag is reliable to distinguish
> whether _init_fpu()/_restore_fp() is needed. Because the value of the
> CP0_Status.CU1 isn't changed during preemption.
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
> arch/mips/loongson/loongson-3/cop2-ex.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
> diff --git a/arch/mips/loongson/loongson-3/cop2-ex.c b/arch/mips/loongson/loongson-3/cop2-ex.c
> index 9182e8d..c1e9503 100644
> --- a/arch/mips/loongson/loongson-3/cop2-ex.c
> +++ b/arch/mips/loongson/loongson-3/cop2-ex.c
[...]
> @@ -39,8 +39,8 @@ static int loongson_cu2_call(struct notifier_block *nfb, unsigned long action,
> KSTK_STATUS(current) |= ST0_FR;
> else
> KSTK_STATUS(current) &= ~ST0_FR;
> - /* If FPU is enabled, we needn't init or restore fp */
> - if(!fpu_enabled) {
> + /* If FPU is owned, we needn't init or restore fp */
> + if(!fpu_owned) {
Space is needed after *if*, high time to fix this.
WBR, Sergei
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] MIPS: Move CPU topology macros to topology.h
2014-08-08 3:16 [PATCH 1/2] MIPS: Move CPU topology macros to topology.h Huacai Chen
2014-08-08 3:16 ` [PATCH 2/2] MIPS: Loongson: Fix COP2 usage for preemptible kernel Huacai Chen
@ 2014-08-08 13:47 ` Ralf Baechle
2014-08-13 0:18 ` Jayachandran C.
1 sibling, 1 reply; 12+ messages in thread
From: Ralf Baechle @ 2014-08-08 13:47 UTC (permalink / raw)
To: Huacai Chen
Cc: John Crispin, Steven J. Hill, Aurelien Jarno, linux-mips,
Fuxin Zhang, Zhangjin Wu, Jayachandran C.
Jayachandran,
could you convert the netlogic platforms to use this scheme, too?
We then could drop the #ifdefs introduced by this patch.
Ralf
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] MIPS: Move CPU topology macros to topology.h
2014-08-08 13:47 ` [PATCH 1/2] MIPS: Move CPU topology macros to topology.h Ralf Baechle
@ 2014-08-13 0:18 ` Jayachandran C.
2014-08-13 0:18 ` Jayachandran C.
2014-08-20 3:57 ` Huacai Chen
0 siblings, 2 replies; 12+ messages in thread
From: Jayachandran C. @ 2014-08-13 0:18 UTC (permalink / raw)
To: Ralf Baechle
Cc: Huacai Chen, John Crispin, Steven J. Hill, Aurelien Jarno,
linux-mips, Fuxin Zhang, Zhangjin Wu
On Fri, Aug 08, 2014 at 03:47:38PM +0200, Ralf Baechle wrote:
> Jayachandran,
>
> could you convert the netlogic platforms to use this scheme, too?
> We then could drop the #ifdefs introduced by this patch.
The same sequence is used by ip27 platform as well, so I think the
ifndef may still be needed. This is the same ifndef pattern we use
for all our mach-generic/*.h vs. mach-<platform>/*.h
On second thought, I am not sure if the changes in Huacai's patch
has to be in asm/topology.h, probably this has to be in
mach-generic/topology.h
JC.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] MIPS: Move CPU topology macros to topology.h
2014-08-13 0:18 ` Jayachandran C.
@ 2014-08-13 0:18 ` Jayachandran C.
2014-08-20 3:57 ` Huacai Chen
1 sibling, 0 replies; 12+ messages in thread
From: Jayachandran C. @ 2014-08-13 0:18 UTC (permalink / raw)
To: Ralf Baechle
Cc: Huacai Chen, John Crispin, Steven J. Hill, Aurelien Jarno,
linux-mips, Fuxin Zhang, Zhangjin Wu
On Fri, Aug 08, 2014 at 03:47:38PM +0200, Ralf Baechle wrote:
> Jayachandran,
>
> could you convert the netlogic platforms to use this scheme, too?
> We then could drop the #ifdefs introduced by this patch.
The same sequence is used by ip27 platform as well, so I think the
ifndef may still be needed. This is the same ifndef pattern we use
for all our mach-generic/*.h vs. mach-<platform>/*.h
On second thought, I am not sure if the changes in Huacai's patch
has to be in asm/topology.h, probably this has to be in
mach-generic/topology.h
JC.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] MIPS: Move CPU topology macros to topology.h
2014-08-13 0:18 ` Jayachandran C.
2014-08-13 0:18 ` Jayachandran C.
@ 2014-08-20 3:57 ` Huacai Chen
2014-08-22 4:18 ` [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h Jayachandran C
1 sibling, 1 reply; 12+ messages in thread
From: Huacai Chen @ 2014-08-20 3:57 UTC (permalink / raw)
To: Jayachandran C.
Cc: Ralf Baechle, John Crispin, Steven J. Hill, Aurelien Jarno,
Linux MIPS Mailing List, Fuxin Zhang, Zhangjin Wu
Hi, Ralf,
Why this patch hasn't applied?
Huacai
On Wed, Aug 13, 2014 at 8:18 AM, Jayachandran C. <jchandra@broadcom.com> wrote:
> On Fri, Aug 08, 2014 at 03:47:38PM +0200, Ralf Baechle wrote:
>> Jayachandran,
>>
>> could you convert the netlogic platforms to use this scheme, too?
>> We then could drop the #ifdefs introduced by this patch.
>
> The same sequence is used by ip27 platform as well, so I think the
> ifndef may still be needed. This is the same ifndef pattern we use
> for all our mach-generic/*.h vs. mach-<platform>/*.h
>
> On second thought, I am not sure if the changes in Huacai's patch
> has to be in asm/topology.h, probably this has to be in
> mach-generic/topology.h
>
> JC.
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h
2014-08-20 3:57 ` Huacai Chen
@ 2014-08-22 4:18 ` Jayachandran C
2014-08-22 4:18 ` Jayachandran C
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Jayachandran C @ 2014-08-22 4:18 UTC (permalink / raw)
To: linux-mips; +Cc: Jayachandran C, ralf, chenhc
commit bda4584cd943 ("MIPS: Support CPU topology files in sysfs")
added topology related macros for all MIPS platforms. This causes
compile failure for Netlogic platforms with errors like:
arch/mips/include/asm/mach-netlogic/topology.h:14:0: error: "topology_physical_package_id" redefined [-Werror]
Fix this by dropping Netlogic specific topology.h and setting up package
field in cpu data.
Signed-off-by: Jayachandran C <jchandra@broadcom.com>
---
[Resending this, looks like linux-mips.org is down]
arch/mips/include/asm/mach-netlogic/topology.h | 22 ----------------------
arch/mips/netlogic/common/smp.c | 1 +
2 files changed, 1 insertion(+), 22 deletions(-)
delete mode 100644 arch/mips/include/asm/mach-netlogic/topology.h
diff --git a/arch/mips/include/asm/mach-netlogic/topology.h b/arch/mips/include/asm/mach-netlogic/topology.h
deleted file mode 100644
index ceeb1f5..0000000
--- a/arch/mips/include/asm/mach-netlogic/topology.h
+++ /dev/null
@@ -1,22 +0,0 @@
-/*
- * This file is subject to the terms and conditions of the GNU General Public
- * License. See the file "COPYING" in the main directory of this archive
- * for more details.
- *
- * Copyright (C) 2013 Broadcom Corporation
- */
-#ifndef _ASM_MACH_NETLOGIC_TOPOLOGY_H
-#define _ASM_MACH_NETLOGIC_TOPOLOGY_H
-
-#include <asm/mach-netlogic/multi-node.h>
-
-#ifdef CONFIG_SMP
-#define topology_physical_package_id(cpu) cpu_to_node(cpu)
-#define topology_core_id(cpu) (cpu_logical_map(cpu) / NLM_THREADS_PER_CORE)
-#define topology_thread_cpumask(cpu) (&cpu_sibling_map[cpu])
-#define topology_core_cpumask(cpu) cpumask_of_node(cpu_to_node(cpu))
-#endif
-
-#include <asm-generic/topology.h>
-
-#endif /* _ASM_MACH_NETLOGIC_TOPOLOGY_H */
diff --git a/arch/mips/netlogic/common/smp.c b/arch/mips/netlogic/common/smp.c
index 4fde7ac..f23fe22 100644
--- a/arch/mips/netlogic/common/smp.c
+++ b/arch/mips/netlogic/common/smp.c
@@ -120,6 +120,7 @@ static void nlm_init_secondary(void)
hwtid = hard_smp_processor_id();
current_cpu_data.core = hwtid / NLM_THREADS_PER_CORE;
+ current_cpu_data.package = nlm_cpuid_to_node(hwtid);
nlm_percpu_init(hwtid);
nlm_smp_irq_init(hwtid);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h
2014-08-22 4:18 ` [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h Jayachandran C
@ 2014-08-22 4:18 ` Jayachandran C
2014-08-22 4:18 ` [PATCH 2/2] MIPS: Move topology macros to topology.h Jayachandran C
2014-08-25 13:20 ` [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h Ralf Baechle
2 siblings, 0 replies; 12+ messages in thread
From: Jayachandran C @ 2014-08-22 4:18 UTC (permalink / raw)
To: linux-mips; +Cc: Jayachandran C, ralf, chenhc
commit bda4584cd943 ("MIPS: Support CPU topology files in sysfs")
added topology related macros for all MIPS platforms. This causes
compile failure for Netlogic platforms with errors like:
arch/mips/include/asm/mach-netlogic/topology.h:14:0: error: "topology_physical_package_id" redefined [-Werror]
Fix this by dropping Netlogic specific topology.h and setting up package
field in cpu data.
Signed-off-by: Jayachandran C <jchandra@broadcom.com>
---
[Resending this, looks like linux-mips.org is down]
arch/mips/include/asm/mach-netlogic/topology.h | 22 ----------------------
arch/mips/netlogic/common/smp.c | 1 +
2 files changed, 1 insertion(+), 22 deletions(-)
delete mode 100644 arch/mips/include/asm/mach-netlogic/topology.h
diff --git a/arch/mips/include/asm/mach-netlogic/topology.h b/arch/mips/include/asm/mach-netlogic/topology.h
deleted file mode 100644
index ceeb1f5..0000000
--- a/arch/mips/include/asm/mach-netlogic/topology.h
+++ /dev/null
@@ -1,22 +0,0 @@
-/*
- * This file is subject to the terms and conditions of the GNU General Public
- * License. See the file "COPYING" in the main directory of this archive
- * for more details.
- *
- * Copyright (C) 2013 Broadcom Corporation
- */
-#ifndef _ASM_MACH_NETLOGIC_TOPOLOGY_H
-#define _ASM_MACH_NETLOGIC_TOPOLOGY_H
-
-#include <asm/mach-netlogic/multi-node.h>
-
-#ifdef CONFIG_SMP
-#define topology_physical_package_id(cpu) cpu_to_node(cpu)
-#define topology_core_id(cpu) (cpu_logical_map(cpu) / NLM_THREADS_PER_CORE)
-#define topology_thread_cpumask(cpu) (&cpu_sibling_map[cpu])
-#define topology_core_cpumask(cpu) cpumask_of_node(cpu_to_node(cpu))
-#endif
-
-#include <asm-generic/topology.h>
-
-#endif /* _ASM_MACH_NETLOGIC_TOPOLOGY_H */
diff --git a/arch/mips/netlogic/common/smp.c b/arch/mips/netlogic/common/smp.c
index 4fde7ac..f23fe22 100644
--- a/arch/mips/netlogic/common/smp.c
+++ b/arch/mips/netlogic/common/smp.c
@@ -120,6 +120,7 @@ static void nlm_init_secondary(void)
hwtid = hard_smp_processor_id();
current_cpu_data.core = hwtid / NLM_THREADS_PER_CORE;
+ current_cpu_data.package = nlm_cpuid_to_node(hwtid);
nlm_percpu_init(hwtid);
nlm_smp_irq_init(hwtid);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/2] MIPS: Move topology macros to topology.h
2014-08-22 4:18 ` [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h Jayachandran C
2014-08-22 4:18 ` Jayachandran C
@ 2014-08-22 4:18 ` Jayachandran C
2014-08-22 4:18 ` Jayachandran C
2014-08-25 13:20 ` [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h Ralf Baechle
2 siblings, 1 reply; 12+ messages in thread
From: Jayachandran C @ 2014-08-22 4:18 UTC (permalink / raw)
To: linux-mips; +Cc: Jayachandran C, ralf, chenhc
commit bda4584cd943 ("MIPS: Support CPU topology files in sysfs")
added MIPS topology related macros to asm/smp.h. Move these to
asm/topology.h.
Signed-off-by: Jayachandran C <jchandra@broadcom.com>
---
[Resending this, looks like linux-mips.org is down]
arch/mips/include/asm/smp.h | 5 -----
arch/mips/include/asm/topology.h | 5 +++++
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/mips/include/asm/smp.h b/arch/mips/include/asm/smp.h
index 1e0f20a..eacf865 100644
--- a/arch/mips/include/asm/smp.h
+++ b/arch/mips/include/asm/smp.h
@@ -37,11 +37,6 @@ extern int __cpu_logical_map[NR_CPUS];
#define NO_PROC_ID (-1)
-#define topology_physical_package_id(cpu) (cpu_data[cpu].package)
-#define topology_core_id(cpu) (cpu_data[cpu].core)
-#define topology_core_cpumask(cpu) (&cpu_core_map[cpu])
-#define topology_thread_cpumask(cpu) (&cpu_sibling_map[cpu])
-
#define SMP_RESCHEDULE_YOURSELF 0x1 /* XXX braindead */
#define SMP_CALL_FUNCTION 0x2
/* Octeon - Tell another core to flush its icache */
diff --git a/arch/mips/include/asm/topology.h b/arch/mips/include/asm/topology.h
index 20ea485..e012429 100644
--- a/arch/mips/include/asm/topology.h
+++ b/arch/mips/include/asm/topology.h
@@ -10,4 +10,9 @@
#include <topology.h>
+#define topology_physical_package_id(cpu) (cpu_data[cpu].package)
+#define topology_core_id(cpu) (cpu_data[cpu].core)
+#define topology_core_cpumask(cpu) (&cpu_core_map[cpu])
+#define topology_thread_cpumask(cpu) (&cpu_sibling_map[cpu])
+
#endif /* __ASM_TOPOLOGY_H */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/2] MIPS: Move topology macros to topology.h
2014-08-22 4:18 ` [PATCH 2/2] MIPS: Move topology macros to topology.h Jayachandran C
@ 2014-08-22 4:18 ` Jayachandran C
0 siblings, 0 replies; 12+ messages in thread
From: Jayachandran C @ 2014-08-22 4:18 UTC (permalink / raw)
To: linux-mips; +Cc: Jayachandran C, ralf, chenhc
commit bda4584cd943 ("MIPS: Support CPU topology files in sysfs")
added MIPS topology related macros to asm/smp.h. Move these to
asm/topology.h.
Signed-off-by: Jayachandran C <jchandra@broadcom.com>
---
[Resending this, looks like linux-mips.org is down]
arch/mips/include/asm/smp.h | 5 -----
arch/mips/include/asm/topology.h | 5 +++++
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/mips/include/asm/smp.h b/arch/mips/include/asm/smp.h
index 1e0f20a..eacf865 100644
--- a/arch/mips/include/asm/smp.h
+++ b/arch/mips/include/asm/smp.h
@@ -37,11 +37,6 @@ extern int __cpu_logical_map[NR_CPUS];
#define NO_PROC_ID (-1)
-#define topology_physical_package_id(cpu) (cpu_data[cpu].package)
-#define topology_core_id(cpu) (cpu_data[cpu].core)
-#define topology_core_cpumask(cpu) (&cpu_core_map[cpu])
-#define topology_thread_cpumask(cpu) (&cpu_sibling_map[cpu])
-
#define SMP_RESCHEDULE_YOURSELF 0x1 /* XXX braindead */
#define SMP_CALL_FUNCTION 0x2
/* Octeon - Tell another core to flush its icache */
diff --git a/arch/mips/include/asm/topology.h b/arch/mips/include/asm/topology.h
index 20ea485..e012429 100644
--- a/arch/mips/include/asm/topology.h
+++ b/arch/mips/include/asm/topology.h
@@ -10,4 +10,9 @@
#include <topology.h>
+#define topology_physical_package_id(cpu) (cpu_data[cpu].package)
+#define topology_core_id(cpu) (cpu_data[cpu].core)
+#define topology_core_cpumask(cpu) (&cpu_core_map[cpu])
+#define topology_thread_cpumask(cpu) (&cpu_sibling_map[cpu])
+
#endif /* __ASM_TOPOLOGY_H */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h
2014-08-22 4:18 ` [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h Jayachandran C
2014-08-22 4:18 ` Jayachandran C
2014-08-22 4:18 ` [PATCH 2/2] MIPS: Move topology macros to topology.h Jayachandran C
@ 2014-08-25 13:20 ` Ralf Baechle
2 siblings, 0 replies; 12+ messages in thread
From: Ralf Baechle @ 2014-08-25 13:20 UTC (permalink / raw)
To: Jayachandran C; +Cc: linux-mips, chenhc, Guenter Roeck
On Fri, Aug 22, 2014 at 09:48:31AM +0530, Jayachandran C wrote:
> commit bda4584cd943 ("MIPS: Support CPU topology files in sysfs")
> added topology related macros for all MIPS platforms. This causes
> compile failure for Netlogic platforms with errors like:
>
> arch/mips/include/asm/mach-netlogic/topology.h:14:0: error: "topology_physical_package_id" redefined [-Werror]
>
> Fix this by dropping Netlogic specific topology.h and setting up package
> field in cpu data.
I've already applied Guenter Roeck's patch
https://patchwork.linux-mips.org/patch/7513/ as commit
bbbf6d8768f5cac3523c408917083a111b1f3ffe [MIPS: Netlogic: Use MIPS
topology.h] and the pull request for that one is out to Linus.
So if you think your solution is nicer, please send a followup patch,
> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
> ---
> [Resending this, looks like linux-mips.org is down]
Ironically the announcement of the new system also got affected by the
email woes and only went out after resending it ... By now things should
be all back to normal and I can't believe how much faster some operations
such as git push have become!
Ralf
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-08-25 13:20 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-08 3:16 [PATCH 1/2] MIPS: Move CPU topology macros to topology.h Huacai Chen
2014-08-08 3:16 ` [PATCH 2/2] MIPS: Loongson: Fix COP2 usage for preemptible kernel Huacai Chen
2014-08-08 12:12 ` Sergei Shtylyov
2014-08-08 13:47 ` [PATCH 1/2] MIPS: Move CPU topology macros to topology.h Ralf Baechle
2014-08-13 0:18 ` Jayachandran C.
2014-08-13 0:18 ` Jayachandran C.
2014-08-20 3:57 ` Huacai Chen
2014-08-22 4:18 ` [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h Jayachandran C
2014-08-22 4:18 ` Jayachandran C
2014-08-22 4:18 ` [PATCH 2/2] MIPS: Move topology macros to topology.h Jayachandran C
2014-08-22 4:18 ` Jayachandran C
2014-08-25 13:20 ` [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox