Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Tony Wu <tung7970@gmail.com>, <ralf@linux-mips.org>
Cc: Lars Persson <larper@axis.com>, <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: Fix syscall_trace_enter compilation error
Date: Thu, 12 Feb 2015 13:45:08 +0000	[thread overview]
Message-ID: <54DCAE64.5050901@imgtec.com> (raw)
In-Reply-To: <20150206004026-tung7970@googlemail.com>

On 02/05/2015 04:43 PM, Tony Wu wrote:
> Commit cf6ce084 (MIPS: Fix syscall_get_nr for the syscall exit
> tracing.) broke 3.13 and 3.14 stable tree due to the missing syscall
> argument. So, get the syscall from regs[2] before it's trashed.
> 
> This patch should go to the 3.13 and 3.14 stable tree.
> 
> Signed-off-by: Tony Wu <tung7970@gmail.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Lars Persson <larper@axis.com>
> Cc: linux-mips@linux-mips.org
> 
> diff --git a/arch/mips/kernel/ptrace.c b/arch/mips/kernel/ptrace.c
> index 64e18f9..01f1413 100644
> --- a/arch/mips/kernel/ptrace.c
> +++ b/arch/mips/kernel/ptrace.c
> @@ -799,7 +799,7 @@ asmlinkage void syscall_trace_enter(struct pt_regs *regs)
>  	long ret = 0;
>  	user_exit();
>  
> -	current_thread_info()->syscall = syscall;
> +	current_thread_info()->syscall = regs->regs[2];
>  
>  	/* do the secure computing check first */
>  	secure_computing_strict(regs->regs[2]);
> 

Hi,

Commit cf6ce084 (MIPS: Fix syscall_get_nr for the syscall exit..) is not
in the stable branches. How did it brake the 3.13 and 3.14 build?

-- 
markos

WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Tony Wu <tung7970@gmail.com>, ralf@linux-mips.org
Cc: Lars Persson <larper@axis.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Fix syscall_trace_enter compilation error
Date: Thu, 12 Feb 2015 13:45:08 +0000	[thread overview]
Message-ID: <54DCAE64.5050901@imgtec.com> (raw)
Message-ID: <20150212134508.irtKOQirgZ4YArRGEY7PUTGYtRzYfCZ1zGFsdFCwqJk@z> (raw)
In-Reply-To: <20150206004026-tung7970@googlemail.com>

On 02/05/2015 04:43 PM, Tony Wu wrote:
> Commit cf6ce084 (MIPS: Fix syscall_get_nr for the syscall exit
> tracing.) broke 3.13 and 3.14 stable tree due to the missing syscall
> argument. So, get the syscall from regs[2] before it's trashed.
> 
> This patch should go to the 3.13 and 3.14 stable tree.
> 
> Signed-off-by: Tony Wu <tung7970@gmail.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Lars Persson <larper@axis.com>
> Cc: linux-mips@linux-mips.org
> 
> diff --git a/arch/mips/kernel/ptrace.c b/arch/mips/kernel/ptrace.c
> index 64e18f9..01f1413 100644
> --- a/arch/mips/kernel/ptrace.c
> +++ b/arch/mips/kernel/ptrace.c
> @@ -799,7 +799,7 @@ asmlinkage void syscall_trace_enter(struct pt_regs *regs)
>  	long ret = 0;
>  	user_exit();
>  
> -	current_thread_info()->syscall = syscall;
> +	current_thread_info()->syscall = regs->regs[2];
>  
>  	/* do the secure computing check first */
>  	secure_computing_strict(regs->regs[2]);
> 

Hi,

Commit cf6ce084 (MIPS: Fix syscall_get_nr for the syscall exit..) is not
in the stable branches. How did it brake the 3.13 and 3.14 build?

-- 
markos

  reply	other threads:[~2015-02-12 13:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 16:43 [PATCH] MIPS: Fix syscall_trace_enter compilation error Tony Wu
2015-02-12 13:45 ` Markos Chandras [this message]
2015-02-12 13:45   ` Markos Chandras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DCAE64.5050901@imgtec.com \
    --to=markos.chandras@imgtec.com \
    --cc=larper@axis.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=tung7970@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox