Linux MIPS Architecture development
 help / color / mirror / Atom feed
* [PATCH] MIPS: Fix syscall_trace_enter compilation error
@ 2015-02-05 16:43 Tony Wu
  2015-02-12 13:45 ` Markos Chandras
  0 siblings, 1 reply; 3+ messages in thread
From: Tony Wu @ 2015-02-05 16:43 UTC (permalink / raw)
  To: ralf; +Cc: Lars Persson, linux-mips

Commit cf6ce084 (MIPS: Fix syscall_get_nr for the syscall exit
tracing.) broke 3.13 and 3.14 stable tree due to the missing syscall
argument. So, get the syscall from regs[2] before it's trashed.

This patch should go to the 3.13 and 3.14 stable tree.

Signed-off-by: Tony Wu <tung7970@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Lars Persson <larper@axis.com>
Cc: linux-mips@linux-mips.org

diff --git a/arch/mips/kernel/ptrace.c b/arch/mips/kernel/ptrace.c
index 64e18f9..01f1413 100644
--- a/arch/mips/kernel/ptrace.c
+++ b/arch/mips/kernel/ptrace.c
@@ -799,7 +799,7 @@ asmlinkage void syscall_trace_enter(struct pt_regs *regs)
 	long ret = 0;
 	user_exit();
 
-	current_thread_info()->syscall = syscall;
+	current_thread_info()->syscall = regs->regs[2];
 
 	/* do the secure computing check first */
 	secure_computing_strict(regs->regs[2]);

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: Fix syscall_trace_enter compilation error
  2015-02-05 16:43 [PATCH] MIPS: Fix syscall_trace_enter compilation error Tony Wu
@ 2015-02-12 13:45 ` Markos Chandras
  2015-02-12 13:45   ` Markos Chandras
  0 siblings, 1 reply; 3+ messages in thread
From: Markos Chandras @ 2015-02-12 13:45 UTC (permalink / raw)
  To: Tony Wu, ralf; +Cc: Lars Persson, linux-mips

On 02/05/2015 04:43 PM, Tony Wu wrote:
> Commit cf6ce084 (MIPS: Fix syscall_get_nr for the syscall exit
> tracing.) broke 3.13 and 3.14 stable tree due to the missing syscall
> argument. So, get the syscall from regs[2] before it's trashed.
> 
> This patch should go to the 3.13 and 3.14 stable tree.
> 
> Signed-off-by: Tony Wu <tung7970@gmail.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Lars Persson <larper@axis.com>
> Cc: linux-mips@linux-mips.org
> 
> diff --git a/arch/mips/kernel/ptrace.c b/arch/mips/kernel/ptrace.c
> index 64e18f9..01f1413 100644
> --- a/arch/mips/kernel/ptrace.c
> +++ b/arch/mips/kernel/ptrace.c
> @@ -799,7 +799,7 @@ asmlinkage void syscall_trace_enter(struct pt_regs *regs)
>  	long ret = 0;
>  	user_exit();
>  
> -	current_thread_info()->syscall = syscall;
> +	current_thread_info()->syscall = regs->regs[2];
>  
>  	/* do the secure computing check first */
>  	secure_computing_strict(regs->regs[2]);
> 

Hi,

Commit cf6ce084 (MIPS: Fix syscall_get_nr for the syscall exit..) is not
in the stable branches. How did it brake the 3.13 and 3.14 build?

-- 
markos

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: Fix syscall_trace_enter compilation error
  2015-02-12 13:45 ` Markos Chandras
@ 2015-02-12 13:45   ` Markos Chandras
  0 siblings, 0 replies; 3+ messages in thread
From: Markos Chandras @ 2015-02-12 13:45 UTC (permalink / raw)
  To: Tony Wu, ralf; +Cc: Lars Persson, linux-mips

On 02/05/2015 04:43 PM, Tony Wu wrote:
> Commit cf6ce084 (MIPS: Fix syscall_get_nr for the syscall exit
> tracing.) broke 3.13 and 3.14 stable tree due to the missing syscall
> argument. So, get the syscall from regs[2] before it's trashed.
> 
> This patch should go to the 3.13 and 3.14 stable tree.
> 
> Signed-off-by: Tony Wu <tung7970@gmail.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Lars Persson <larper@axis.com>
> Cc: linux-mips@linux-mips.org
> 
> diff --git a/arch/mips/kernel/ptrace.c b/arch/mips/kernel/ptrace.c
> index 64e18f9..01f1413 100644
> --- a/arch/mips/kernel/ptrace.c
> +++ b/arch/mips/kernel/ptrace.c
> @@ -799,7 +799,7 @@ asmlinkage void syscall_trace_enter(struct pt_regs *regs)
>  	long ret = 0;
>  	user_exit();
>  
> -	current_thread_info()->syscall = syscall;
> +	current_thread_info()->syscall = regs->regs[2];
>  
>  	/* do the secure computing check first */
>  	secure_computing_strict(regs->regs[2]);
> 

Hi,

Commit cf6ce084 (MIPS: Fix syscall_get_nr for the syscall exit..) is not
in the stable branches. How did it brake the 3.13 and 3.14 build?

-- 
markos

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-12 13:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-05 16:43 [PATCH] MIPS: Fix syscall_trace_enter compilation error Tony Wu
2015-02-12 13:45 ` Markos Chandras
2015-02-12 13:45   ` Markos Chandras

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox