Re: [PATCH v4 20/37] MIPS: JZ4740: support newer SoC interrupt controllers

[James Hogan <james.hogan@imgtec.com>]

[-- Attachment #1: Type: text/plain, Size: 1704 bytes --]

On 24/04/15 14:17, Paul Burton wrote:
> Allow the interrupt controllers of the JZ4770, JZ4775 & JZ4780 SoCs to
> be probed via devicetree, supporting the 64 interrupts they provide.
> 
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> ---
> Changes in v4:
>   - None.
> 
> Changes in v3:
>   - Support JZ4775, and use a more generic "2chip" probe function name
>     for doing so whilst sharing code with the JZ4780.
> 
> Changes in v2:
>   - None.
> ---
>  arch/mips/jz4740/irq.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/mips/jz4740/irq.c b/arch/mips/jz4740/irq.c
> index 65b27c8..5f4ec08 100644
> --- a/arch/mips/jz4740/irq.c
> +++ b/arch/mips/jz4740/irq.c
> @@ -161,3 +161,12 @@ static int __init intc_1chip_of_init(struct device_node *node,
>  	return ingenic_intc_of_init(node, 1);
>  }
>  IRQCHIP_DECLARE(jz4740_intc, "ingenic,jz4740-intc", intc_1chip_of_init);
> +
> +static int __init intc_2chip_of_init(struct device_node *node,
> +	struct device_node *parent)
> +{
> +	return ingenic_intc_of_init(node, 2);
> +}
> +IRQCHIP_DECLARE(jz4770_intc, "ingenic,jz4770-intc", intc_2chip_of_init);
> +IRQCHIP_DECLARE(jz4775_intc, "ingenic,jz4775-intc", intc_2chip_of_init);

I'm inclined to think the binding documentation should list the
supported compatible strings explicitly. If nothing else it helps with
grepping.

Cheers
James

> +IRQCHIP_DECLARE(jz4780_intc, "ingenic,jz4780-intc", intc_2chip_of_init);
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]