From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Tony Wu <tung7970@gmail.com>, <linux-mips@linux-mips.org>,
<ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: kernel: proc: Fix typo in proc.c
Date: Tue, 3 Nov 2015 16:42:38 +0000 [thread overview]
Message-ID: <5638E3FE.2010503@imgtec.com> (raw)
In-Reply-To: <20151103163943.GA49024@yggdrasil>
On 11/03/2015 04:39 PM, Tony Wu wrote:
> Fix typo introduced in commit 515a6393 (MIPS: kernel: proc: Add
> MIPS R6 support to /proc/cpuinfo), mips1 should be tested against
> cpu_has_mips_1, not cpu_has_mips_r1.
>
> Signed-off-by: Tony Wu <tung7970@gmail.com>
> Cc: Markos Chandras <markos.chandras@imgtec.com>
>
> diff --git a/arch/mips/kernel/proc.c b/arch/mips/kernel/proc.c
> index 211fcd4..3417ce0 100644
> --- a/arch/mips/kernel/proc.c
> +++ b/arch/mips/kernel/proc.c
> @@ -83,7 +83,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
> }
>
> seq_printf(m, "isa\t\t\t:");
> - if (cpu_has_mips_r1)
> + if (cpu_has_mips_1)
> seq_printf(m, " mips1");
> if (cpu_has_mips_2)
> seq_printf(m, "%s", " mips2");
>
Good catch. Might worth adding CC:stable #v4.0+ as well
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Tony Wu <tung7970@gmail.com>,
linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH] MIPS: kernel: proc: Fix typo in proc.c
Date: Tue, 3 Nov 2015 16:42:38 +0000 [thread overview]
Message-ID: <5638E3FE.2010503@imgtec.com> (raw)
Message-ID: <20151103164238.VAbuZhGz1PYjzuWJ-fhYddEOKLt5sVepZVUkrWN981s@z> (raw)
In-Reply-To: <20151103163943.GA49024@yggdrasil>
On 11/03/2015 04:39 PM, Tony Wu wrote:
> Fix typo introduced in commit 515a6393 (MIPS: kernel: proc: Add
> MIPS R6 support to /proc/cpuinfo), mips1 should be tested against
> cpu_has_mips_1, not cpu_has_mips_r1.
>
> Signed-off-by: Tony Wu <tung7970@gmail.com>
> Cc: Markos Chandras <markos.chandras@imgtec.com>
>
> diff --git a/arch/mips/kernel/proc.c b/arch/mips/kernel/proc.c
> index 211fcd4..3417ce0 100644
> --- a/arch/mips/kernel/proc.c
> +++ b/arch/mips/kernel/proc.c
> @@ -83,7 +83,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
> }
>
> seq_printf(m, "isa\t\t\t:");
> - if (cpu_has_mips_r1)
> + if (cpu_has_mips_1)
> seq_printf(m, " mips1");
> if (cpu_has_mips_2)
> seq_printf(m, "%s", " mips2");
>
Good catch. Might worth adding CC:stable #v4.0+ as well
--
markos
next prev parent reply other threads:[~2015-11-03 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 16:39 [PATCH] MIPS: kernel: proc: Fix typo in proc.c Tony Wu
2015-11-03 16:42 ` Markos Chandras [this message]
2015-11-03 16:42 ` Markos Chandras
2015-11-03 17:15 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5638E3FE.2010503@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=tung7970@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox