From: Florian Fainelli <f.fainelli@gmail.com>
To: "Maciej W. Rozycki" <macro@imgtec.com>,
Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <james.hogan@imgtec.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH 4/4] MIPS16e2: Provide feature overrides for non-MIPS16 systems
Date: Tue, 23 May 2017 12:06:26 -0700 [thread overview]
Message-ID: <5cb0253e-8523-bf57-722a-a5ea19873121@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1705230345530.2590@tp.orcam.me.uk>
On 05/23/2017 05:40 AM, Maciej W. Rozycki wrote:
> Hardcode the absence of the MIPS16e2 ASE for all the systems that do so
> for the MIPS16 ASE already, providing for code to be optimized away.
>
> Signed-off-by: Maciej W. Rozycki <macro@imgtec.com>
> ---
Could you switch to using git format-patch such that we have a diffstat
at the beginning of the patch which helps the reviewer figure out which
files are being touched?
It just occurred to me that a bunch of other platforms are lacking a
cpu-feature-overrides.h file, but presumably would never be able to
support mips16e2, like ar7, emma2rh, pnx833x and so on.
> linux-mips16e2-ase-optim.diff
> Index: linux-sfr-test/arch/mips/include/asm/mach-ath25/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-ath25/cpu-feature-overrides.h 2017-05-22 22:42:15.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-ath25/cpu-feature-overrides.h 2017-05-22 22:57:28.987400000 +0100
> @@ -40,6 +40,7 @@
> #endif
>
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_mdmx 0
> #define cpu_has_mips3d 0
> #define cpu_has_smartmips 0
> Index: linux-sfr-test/arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h 2017-05-22 22:42:15.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h 2017-05-22 22:57:28.991406000 +0100
> @@ -31,6 +31,7 @@
> #define cpu_has_ejtag 1
> #define cpu_has_llsc 1
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_mdmx 0
> #define cpu_has_mips3d 0
> #define cpu_has_smartmips 0
> Index: linux-sfr-test/arch/mips/include/asm/mach-bcm63xx/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-bcm63xx/cpu-feature-overrides.h 2017-05-22 22:42:15.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-bcm63xx/cpu-feature-overrides.h 2017-05-22 22:57:28.995412000 +0100
> @@ -19,6 +19,7 @@
> #define cpu_has_ejtag 1
> #define cpu_has_llsc 1
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_mdmx 0
> #define cpu_has_mips3d 0
> #define cpu_has_smartmips 0
And why not mach-bmips/cpu-features-overrides.h?
> Index: linux-sfr-test/arch/mips/include/asm/mach-cobalt/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-cobalt/cpu-feature-overrides.h 2017-05-22 22:42:15.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-cobalt/cpu-feature-overrides.h 2017-05-22 22:57:29.001406000 +0100
> @@ -37,6 +37,7 @@
> #endif
>
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_mdmx 0
> #define cpu_has_mips3d 0
> #define cpu_has_smartmips 0
> Index: linux-sfr-test/arch/mips/include/asm/mach-dec/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-dec/cpu-feature-overrides.h 2017-05-22 22:42:15.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-dec/cpu-feature-overrides.h 2017-05-22 22:57:29.006398000 +0100
> @@ -27,6 +27,7 @@
> #define cpu_has_mcheck 0
> #define cpu_has_ejtag 0
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_mdmx 0
> #define cpu_has_mips3d 0
> #define cpu_has_smartmips 0
> Index: linux-sfr-test/arch/mips/include/asm/mach-ip22/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-ip22/cpu-feature-overrides.h 2017-05-22 22:42:15.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-ip22/cpu-feature-overrides.h 2017-05-22 22:57:29.010397000 +0100
> @@ -19,6 +19,7 @@
> #define cpu_has_32fpr 1
> #define cpu_has_counter 1
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_divec 0
> #define cpu_has_cache_cdex_p 1
> #define cpu_has_prefetch 0
> Index: linux-sfr-test/arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h 2017-05-22 22:42:15.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h 2017-05-22 22:57:29.020398000 +0100
> @@ -43,6 +43,7 @@
> #define cpu_has_ejtag 0
> #define cpu_has_llsc 1
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_mdmx 0
> #define cpu_has_mips3d 0
> #define cpu_has_smartmips 0
> Index: linux-sfr-test/arch/mips/include/asm/mach-ip28/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-ip28/cpu-feature-overrides.h 2017-05-22 22:42:15.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-ip28/cpu-feature-overrides.h 2017-05-22 22:57:29.024398000 +0100
> @@ -16,6 +16,7 @@
> */
> #define cpu_has_watch 1
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_divec 0
> #define cpu_has_vce 0
> #define cpu_has_cache_cdex_p 0
> Index: linux-sfr-test/arch/mips/include/asm/mach-ip32/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-ip32/cpu-feature-overrides.h 2017-05-22 22:42:15.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-ip32/cpu-feature-overrides.h 2017-05-22 22:57:29.028408000 +0100
> @@ -29,6 +29,7 @@
> #define cpu_has_32fpr 1
> #define cpu_has_counter 1
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_vce 0
> #define cpu_has_cache_cdex_s 0
> #define cpu_has_mcheck 0
> Index: linux-sfr-test/arch/mips/include/asm/mach-jz4740/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-jz4740/cpu-feature-overrides.h 2017-05-22 22:42:15.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-jz4740/cpu-feature-overrides.h 2017-05-22 22:57:29.032407000 +0100
> @@ -23,6 +23,7 @@
> #define cpu_has_ejtag 1
> #define cpu_has_llsc 1
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_mdmx 0
> #define cpu_has_mips3d 0
> #define cpu_has_smartmips 0
> Index: linux-sfr-test/arch/mips/include/asm/mach-loongson64/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-loongson64/cpu-feature-overrides.h 2017-05-22 22:42:16.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-loongson64/cpu-feature-overrides.h 2017-05-22 22:57:29.043398000 +0100
> @@ -32,6 +32,7 @@
> #define cpu_has_mcheck 0
> #define cpu_has_mdmx 0
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_mips3d 0
> #define cpu_has_mipsmt 0
> #define cpu_has_smartmips 0
> Index: linux-sfr-test/arch/mips/include/asm/mach-netlogic/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-netlogic/cpu-feature-overrides.h 2017-05-22 22:42:16.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-netlogic/cpu-feature-overrides.h 2017-05-22 22:57:29.047397000 +0100
> @@ -13,6 +13,7 @@
> #define cpu_has_4k_cache 1
> #define cpu_has_watch 1
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_counter 1
> #define cpu_has_divec 1
> #define cpu_has_vce 0
> Index: linux-sfr-test/arch/mips/include/asm/mach-rc32434/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-rc32434/cpu-feature-overrides.h 2017-05-22 22:42:16.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-rc32434/cpu-feature-overrides.h 2017-05-22 22:57:29.051411000 +0100
> @@ -48,6 +48,7 @@
> #define cpu_has_llsc 1
>
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_mdmx 0
> #define cpu_has_mips3d 0
> #define cpu_has_smartmips 0
> Index: linux-sfr-test/arch/mips/include/asm/mach-rm/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-rm/cpu-feature-overrides.h 2017-05-22 22:42:16.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-rm/cpu-feature-overrides.h 2017-05-22 22:57:29.066402000 +0100
> @@ -17,6 +17,7 @@
> #define cpu_has_counter 1
> #define cpu_has_watch 0
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_divec 0
> #define cpu_has_cache_cdex_p 1
> #define cpu_has_prefetch 0
> Index: linux-sfr-test/arch/mips/include/asm/mach-sibyte/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-sibyte/cpu-feature-overrides.h 2017-05-22 22:42:16.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-sibyte/cpu-feature-overrides.h 2017-05-22 22:57:29.070404000 +0100
> @@ -13,6 +13,7 @@
> */
> #define cpu_has_watch 1
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_divec 1
> #define cpu_has_vce 0
> #define cpu_has_cache_cdex_p 0
> Index: linux-sfr-test/arch/mips/include/asm/mach-tx49xx/cpu-feature-overrides.h
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/include/asm/mach-tx49xx/cpu-feature-overrides.h 2017-05-22 22:42:16.000000000 +0100
> +++ linux-sfr-test/arch/mips/include/asm/mach-tx49xx/cpu-feature-overrides.h 2017-05-22 22:57:29.074404000 +0100
> @@ -6,6 +6,7 @@
> #define cpu_has_inclusive_pcaches 0
>
> #define cpu_has_mips16 0
> +#define cpu_has_mips16e2 0
> #define cpu_has_mdmx 0
> #define cpu_has_mips3d 0
> #define cpu_has_smartmips 0
>
--
Florian
next prev parent reply other threads:[~2017-05-23 19:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 12:36 [PATCH 0/4] MIPS16e2 ASE support Maciej W. Rozycki
2017-05-23 12:36 ` Maciej W. Rozycki
2017-05-23 12:37 ` [PATCH 1/4] MIPS16e2: Identify ASE presence Maciej W. Rozycki
2017-05-23 12:37 ` Maciej W. Rozycki
2017-07-03 18:32 ` James Hogan
2017-07-03 18:32 ` James Hogan
2017-05-23 12:38 ` [PATCH 2/4] MIPS16e2: Subdecode extended LWSP/SWSP instructions Maciej W. Rozycki
2017-05-23 12:38 ` Maciej W. Rozycki
2017-07-03 20:20 ` James Hogan
2017-07-03 20:20 ` James Hogan
2017-05-23 12:39 ` [PATCH 3/4] MIPS16e2: Report ASE presence in /proc/cpuinfo Maciej W. Rozycki
2017-05-23 12:39 ` Maciej W. Rozycki
2017-07-03 20:23 ` James Hogan
2017-07-03 20:23 ` James Hogan
2017-07-04 15:35 ` Maciej W. Rozycki
2017-07-04 15:35 ` Maciej W. Rozycki
2017-07-04 15:39 ` James Hogan
2017-07-04 15:39 ` James Hogan
2017-05-23 12:40 ` [PATCH 4/4] MIPS16e2: Provide feature overrides for non-MIPS16 systems Maciej W. Rozycki
2017-05-23 12:40 ` Maciej W. Rozycki
2017-05-23 19:06 ` Florian Fainelli [this message]
2017-05-23 22:21 ` Maciej W. Rozycki
2017-05-23 22:21 ` Maciej W. Rozycki
2017-07-03 20:32 ` James Hogan
2017-07-03 20:32 ` James Hogan
2017-07-04 15:50 ` Maciej W. Rozycki
2017-07-04 15:50 ` Maciej W. Rozycki
2017-07-04 16:51 ` James Hogan
2017-07-04 16:51 ` James Hogan
2017-07-03 17:22 ` [PING][PATCH 0/4] MIPS16e2 ASE support Maciej W. Rozycki
2017-07-03 17:22 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cb0253e-8523-bf57-722a-a5ea19873121@gmail.com \
--to=f.fainelli@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@imgtec.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox