Re: [PATCH 3/4] MIPS16e2: Report ASE presence in /proc/cpuinfo

[James Hogan <james.hogan@imgtec.com>]

[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]

On Tue, May 23, 2017 at 01:39:23PM +0100, Maciej W. Rozycki wrote:
> Signed-off-by: Maciej W. Rozycki <macro@imgtec.com>
> ---
>  Submitted third in the series so that the presence of "mips16e2" in 
> /proc/cpuinfo not only indicates the hardware feature, but our correct 
> unaligned emulation as well.

This should be mentioned in the commit description (not the 3rd in the
series bit, the "it indicates both the hw feature and unaligned
emulation" bit).

Otherwise
Reivewed-by: James Hogan <james.hogan@imgtec.com>

Cheers
James

> 
>  There's a `checkpatch.pl' error reported for the unusual formatting, 
> however it is consistent with surrounding code and I do not think we 
> want to make this statement an oddball.
> 
>   Maciej
> 
> linux-mips16e2-ase-report.diff
> Index: linux-sfr-test/arch/mips/kernel/proc.c
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/kernel/proc.c	2017-05-22 22:42:16.000000000 +0100
> +++ linux-sfr-test/arch/mips/kernel/proc.c	2017-05-22 22:56:31.000000000 +0100
> @@ -109,6 +109,7 @@ static int show_cpuinfo(struct seq_file 
>  
>  	seq_printf(m, "ASEs implemented\t:");
>  	if (cpu_has_mips16)	seq_printf(m, "%s", " mips16");
> +	if (cpu_has_mips16e2)	seq_printf(m, "%s", " mips16e2");
>  	if (cpu_has_mdmx)	seq_printf(m, "%s", " mdmx");
>  	if (cpu_has_mips3d)	seq_printf(m, "%s", " mips3d");
>  	if (cpu_has_smartmips)	seq_printf(m, "%s", " smartmips");

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]