[PATCH] minor fix in asm-mips/module.h

[PATCH] minor fix in asm-mips/module.h

[Franck]

This patch replaces an empty preprocessor condition #elif by #else. It
adds 4ksc and 4ksd as well.

Thanks.
--
               Franck

Re: [PATCH] minor fix in asm-mips/module.h

[Ralf Baechle]

On Mon, Sep 26, 2005 at 09:06:50AM +0200, Franck wrote:

> This patch replaces an empty preprocessor condition #elif by #else. It
> adds 4ksc and 4ksd as well.

You forgot to include the patch ...

  Ralf

Re: [PATCH] minor fix in asm-mips/module.h

[Franck]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

2005/9/26, Ralf Baechle <ralf@linux-mips.org>:
> On Mon, Sep 26, 2005 at 09:06:50AM +0200, Franck wrote:
>
> > This patch replaces an empty preprocessor condition #elif by #else. It
> > adds 4ksc and 4ksd as well.
>
> You forgot to include the patch ...

sorry for that, here it is...

Thanks
--
               Franck

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: module.patch --]
[-- Type: text/x-patch; name="module.patch", Size: 491 bytes --]

--- module.h~old	2005-09-26 14:02:32.000000000 +0200
+++ module.h	2005-09-26 09:54:08.000000000 +0200
@@ -113,7 +113,11 @@ search_module_dbetables(unsigned long ad
 #define MODULE_PROC_FAMILY "RM9000"
 #elif defined CONFIG_CPU_SB1
 #define MODULE_PROC_FAMILY "SB1"
-#elif
+#elif defined CONFIG_CPU_4KSC
+#define MODULE_PROC_FAMILY "4KSC"
+#elif defined CONFIG_CPU_4KSD
+#define MODULE_PROC_FAMILY "4KSD"
+#else
 #error MODULE_PROC_FAMILY undefined for your processor configuration
 #endif
 

Re: [PATCH] minor fix in asm-mips/module.h

[Ralf Baechle]

On Mon, Sep 26, 2005 at 02:05:36PM +0200, Franck wrote:

> 2005/9/26, Ralf Baechle <ralf@linux-mips.org>:
> > On Mon, Sep 26, 2005 at 09:06:50AM +0200, Franck wrote:
> >
> > > This patch replaces an empty preprocessor condition #elif by #else.

Thanks for noticing.

> > > It adds 4ksc and 4ksd as well.

--- module.h~old        2005-09-26 14:02:32.000000000 +0200
+++ module.h    2005-09-26 09:54:08.000000000 +0200
@@ -113,7 +113,11 @@ search_module_dbetables(unsigned long ad
 #define MODULE_PROC_FAMILY "RM9000"
 #elif defined CONFIG_CPU_SB1
 #define MODULE_PROC_FAMILY "SB1"
-#elif
+#elif defined CONFIG_CPU_4KSC
+#define MODULE_PROC_FAMILY "4KSC"
+#elif defined CONFIG_CPU_4KSD
+#define MODULE_PROC_FAMILY "4KSD"

There are no CONFIG_CPU_4KSC and CONFIG_CPU_4KSD configuration options.
Did you really create this patch against the linux module of the CVS
repository or was it a different tree?

Thanks,

  Ralf

Re: [PATCH] minor fix in asm-mips/module.h

[Franck]

Hi Ralf,

2005/9/30, Ralf Baechle <ralf@linux-mips.org>:
> There are no CONFIG_CPU_4KSC and CONFIG_CPU_4KSD configuration options.
> Did you really create this patch against the linux module of the CVS
> repository or was it a different tree?
>

The patch was created against linux-mips CVS repository. I added 4KSC
and 4KSD support in this tree. I thougth seeing reference of 4KSC
somewhere. Anyway, if you don't want to include them in your tree
that's ok.

Thanks
--
               Franck

Re: [PATCH] minor fix in asm-mips/module.h

[Ralf Baechle]

On Fri, Sep 30, 2005 at 02:36:01PM +0200, Franck wrote:

> 2005/9/30, Ralf Baechle <ralf@linux-mips.org>:
> > There are no CONFIG_CPU_4KSC and CONFIG_CPU_4KSD configuration options.
> > Did you really create this patch against the linux module of the CVS
> > repository or was it a different tree?
> >
> 
> The patch was created against linux-mips CVS repository. I added 4KSC
> and 4KSD support in this tree. I thougth seeing reference of 4KSC
> somewhere. Anyway, if you don't want to include them in your tree
> that's ok.

It's just that references to CONFIG_* symbols that are being defined
nowhere don't make sense.  If however you want to contribute improved
support for these processors, by all means I'm certainly going to appreciate
a patch!

  Ralf

Re: [PATCH] minor fix in asm-mips/module.h

[Franck]

2005/9/30, Ralf Baechle <ralf@linux-mips.org>:
> On Fri, Sep 30, 2005 at 02:36:01PM +0200, Franck wrote:
>
> > 2005/9/30, Ralf Baechle <ralf@linux-mips.org>:
> > > There are no CONFIG_CPU_4KSC and CONFIG_CPU_4KSD configuration options.
> > > Did you really create this patch against the linux module of the CVS
> > > repository or was it a different tree?
> > >
> >
> > The patch was created against linux-mips CVS repository. I added 4KSC
> > and 4KSD support in this tree. I thougth seeing reference of 4KSC
> > somewhere. Anyway, if you don't want to include them in your tree
> > that's ok.
>
> It's just that references to CONFIG_* symbols that are being defined
> nowhere don't make sense.  If however you want to contribute improved
> support for these processors, by all means I'm certainly going to appreciate
> a patch!
>

I'm surprised you're interested in added support for 4KSC and 4KSD
cpu...Anyway I could send a trivial patch to you if so.

Thanks
--
               Franck

Re: [PATCH] minor fix in asm-mips/module.h

[Ralf Baechle]

On Fri, Sep 30, 2005 at 05:44:01PM +0200, Franck wrote:

> > > 2005/9/30, Ralf Baechle <ralf@linux-mips.org>:
> > > > There are no CONFIG_CPU_4KSC and CONFIG_CPU_4KSD configuration options.
> > > > Did you really create this patch against the linux module of the CVS
> > > > repository or was it a different tree?
> > > >
> > >
> > > The patch was created against linux-mips CVS repository. I added 4KSC
> > > and 4KSD support in this tree. I thougth seeing reference of 4KSC
> > > somewhere. Anyway, if you don't want to include them in your tree
> > > that's ok.
> >
> > It's just that references to CONFIG_* symbols that are being defined
> > nowhere don't make sense.  If however you want to contribute improved
> > support for these processors, by all means I'm certainly going to appreciate
> > a patch!
> >
> 
> I'm surprised you're interested in added support for 4KSC and 4KSD
> cpu...Anyway I could send a trivial patch to you if so.

Yes, some people do strange things with Linux :-)

  Ralf