Re: [PATCH] samples/damon/prcl: add module parameter description for target_pid

Re: [PATCH] samples/damon/prcl: add module parameter description for target_pid

[SJ Park]

On Fri, 17 Jul 2026 16:46:26 +0800 Enze Li <lienze@kylinos.cn> wrote:

> 
> Hi SJ,
> 
> Thank you for your review.
> 
> On Thu, Jul 16 2026 at 06:54:37 AM -0700, SJ Park wrote:
> > Hello Enze,
> >
> >
> > Thank you for this patch!
> >
> > On Thu, 16 Jul 2026 17:14:44 +0800 Enze Li <lienze@kylinos.cn> wrote:
> >
> >> Document 'target_pid' via MODULE_PARM_DESC so its meaning is visible
> >> through kernel command line usage and sysfs interface.
> >
> > But...  It is a static module.  Is there a way to read this documentation from
> > the user space?  If there is no such a way, I don't really think this change is
> > needed.  If we want to document this, we could use comments.
> 
> AFAIK, MODULE_PARM_DESC() is for loadable modules.  For builtins, it’s
> effectively just a comment.

Thank you for clarifying, Enze.

> That said, if DAMON gains loadable module
> support later, having these descriptors in place means we won’t need to
> touch the code. WDYT？

I think it is not too late to add MODULE_PARM_DESC() when we add loadable
modules support.  As of now, no clear needs for loadable module support have
reported, though.


Thank,
SJ

[...]

Re: [PATCH] samples/damon/prcl: add module parameter description for target_pid

[SJ Park]

Hello Enze,


Thank you for this patch!

On Thu, 16 Jul 2026 17:14:44 +0800 Enze Li <lienze@kylinos.cn> wrote:

> Document 'target_pid' via MODULE_PARM_DESC so its meaning is visible
> through kernel command line usage and sysfs interface.

But...  It is a static module.  Is there a way to read this documentation from
the user space?  If there is no such a way, I don't really think this change is
needed.  If we want to document this, we could use comments.

I show 'enabled' parameter has MODULE_PARM_DESC().  If the inconsistency is a
problem, I think it might be better to consistently remove MODULE_PARM_DESC().
It may also be beneficial to comment why we don't have MODULE_PARM_DESC()s on
the module.  What do you think?


Thanks,
SJ

[...]