* [PATCH] mm: debug_page_alloc: fix type mismatch for debug_guardpage_minorder
@ 2026-08-05 9:31 Ye Liu
2026-08-05 16:49 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Ye Liu @ 2026-08-05 9:31 UTC (permalink / raw)
To: Andrew Morton, Vlastimil Babka
Cc: Ye Liu, Suren Baghdasaryan, Michal Hocko, Brendan Jackman,
Johannes Weiner, Zi Yan, linux-mm, linux-kernel
From: Ye Liu <liuye@kylinos.cn>
The _debug_guardpage_minorder variable is declared as unsigned int,
but the debug_guardpage_minorder_setup() function uses unsigned long
and kstrtoul() to parse the value.
Use kstrtouint() with unsigned int local variable to match the actual
type of _debug_guardpage_minorder. Also fix the format specifier
from %lu to %u accordingly.
Signed-off-by: Ye Liu <liuye@kylinos.cn>
---
mm/debug_page_alloc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/debug_page_alloc.c b/mm/debug_page_alloc.c
index 6a26eca546c3..41e3d1f1ad96 100644
--- a/mm/debug_page_alloc.c
+++ b/mm/debug_page_alloc.c
@@ -20,14 +20,14 @@ early_param("debug_pagealloc", early_debug_pagealloc);
static int __init debug_guardpage_minorder_setup(char *buf)
{
- unsigned long res;
+ unsigned int res;
- if (kstrtoul(buf, 10, &res) < 0 || res > MAX_PAGE_ORDER / 2) {
+ if (kstrtouint(buf, 10, &res) < 0 || res > MAX_PAGE_ORDER / 2) {
pr_err("Bad debug_guardpage_minorder value: %s\n", buf);
return 0;
}
_debug_guardpage_minorder = res;
- pr_info("Setting debug_guardpage_minorder to %lu\n", res);
+ pr_info("Setting debug_guardpage_minorder to %u\n", res);
return 0;
}
early_param("debug_guardpage_minorder", debug_guardpage_minorder_setup);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mm: debug_page_alloc: fix type mismatch for debug_guardpage_minorder
2026-08-05 9:31 [PATCH] mm: debug_page_alloc: fix type mismatch for debug_guardpage_minorder Ye Liu
@ 2026-08-05 16:49 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2026-08-05 16:49 UTC (permalink / raw)
To: Ye Liu
Cc: Vlastimil Babka, Ye Liu, Suren Baghdasaryan, Michal Hocko,
Brendan Jackman, Johannes Weiner, Zi Yan, linux-mm, linux-kernel
On Wed, 5 Aug 2026 17:31:07 +0800 Ye Liu <ye.liu@linux.dev> wrote:
>
> The _debug_guardpage_minorder variable is declared as unsigned int,
> but the debug_guardpage_minorder_setup() function uses unsigned long
> and kstrtoul() to parse the value.
>
> Use kstrtouint() with unsigned int local variable to match the actual
> type of _debug_guardpage_minorder. Also fix the format specifier
> from %lu to %u accordingly.
Fair enough, thanks.
AI review seems to have found a little pre-existing bug in there,
https://sashiko.dev/#/patchset/20260805093108.2352900-1-ye.liu@linux.dev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-05 16:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-05 9:31 [PATCH] mm: debug_page_alloc: fix type mismatch for debug_guardpage_minorder Ye Liu
2026-08-05 16:49 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox