[PATCH] mm/secretmem: Fix the enable parameter description

[PATCH] mm/secretmem: Fix the enable parameter description

[Karl Mehltretter]

The module parameter is enable, but its MODULE_PARM_DESC() names the
variable behind it, secretmem_enable, so modinfo describes a parameter
that does not exist and shows no description for the real one.

Use the parameter name in the description.

Fixes: 1507f51255c9 ("mm: introduce memfd_secret system call to create "secret" memory areas")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 mm/secretmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/secretmem.c b/mm/secretmem.c
index 384f5cfc457f..4e32bf55a599 100644
--- a/mm/secretmem.c
+++ b/mm/secretmem.c
@@ -39,7 +39,7 @@
 
 static bool secretmem_enable __ro_after_init = 1;
 module_param_named(enable, secretmem_enable, bool, 0400);
-MODULE_PARM_DESC(secretmem_enable,
+MODULE_PARM_DESC(enable,
 		 "Enable secretmem and memfd_secret(2) system call");
 
 static atomic_t secretmem_users;

base-commit: 986c24e0fe44f844b44d365b71ce831947f50298
-- 
2.53.0

Re: [PATCH] mm/secretmem: Fix the enable parameter description

[Mike Rapoport]

On Sun, Sep 06, 2026 at 07:15:23PM +0200, Karl Mehltretter wrote:
> The module parameter is enable, but its MODULE_PARM_DESC() names the
> variable behind it, secretmem_enable, so modinfo describes a parameter
> that does not exist and shows no description for the real one.

Hmm, does modinfo show secretmem description at all?
 
> Use the parameter name in the description.
> 
> Fixes: 1507f51255c9 ("mm: introduce memfd_secret system call to create "secret" memory areas")
> Assisted-by: LLM

Please use the form described in 

https://docs.kernel.org/process/coding-assistants.html#attribution

> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>

Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

> ---
>  mm/secretmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/secretmem.c b/mm/secretmem.c
> index 384f5cfc457f..4e32bf55a599 100644
> --- a/mm/secretmem.c
> +++ b/mm/secretmem.c
> @@ -39,7 +39,7 @@
>  
>  static bool secretmem_enable __ro_after_init = 1;
>  module_param_named(enable, secretmem_enable, bool, 0400);
> -MODULE_PARM_DESC(secretmem_enable,
> +MODULE_PARM_DESC(enable,
>  		 "Enable secretmem and memfd_secret(2) system call");
>  
>  static atomic_t secretmem_users;
> 
> base-commit: 986c24e0fe44f844b44d365b71ce831947f50298
> -- 
> 2.53.0
> 

-- 
Sincerely yours,
Mike.

Re: [PATCH] mm/secretmem: Fix the enable parameter description

[Karl Mehltretter]

On Sun, Sep 06, 2026 at 10:04:58PM +0100, Mike Rapoport wrote:
> > variable behind it, secretmem_enable, so modinfo describes a parameter
> > that does not exist and shows no description for the real one.
> 
> Hmm, does modinfo show secretmem description at all?

Good catch. I'll reword the changelog in v2 after waiting a bit for other 
feedback.

>  
> > Use the parameter name in the description.
> > 
> > Fixes: 1507f51255c9 ("mm: introduce memfd_secret system call to create "secret" memory areas")
> > Assisted-by: LLM
> 
> Please use the form described in 
> 
> https://docs.kernel.org/process/coding-assistants.html#attribution
> 

"Assisted-by: LLM" is the new updated form and is shown in the linked document.

Thanks,
Karl

[PATCH v2] mm/secretmem: Fix the enable parameter description

[Karl Mehltretter]

The module parameter is enable, but its MODULE_PARM_DESC() names the
variable behind it, secretmem_enable. secretmem is built in, so the
description only reaches modules.builtin.modinfo, where it is filed
under secretmem_enable while the parmtype line and
/sys/module/secretmem/parameters/ say enable.

Use the parameter name in the description.

Fixes: 1507f51255c9 ("mm: introduce memfd_secret system call to create "secret" memory areas")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
---
v2: say what a built-in module shows (Mike), Acked-by collected
v1: https://lore.kernel.org/r/20260906171523.3009-1-kmehltretter@gmail.com/

 mm/secretmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/secretmem.c b/mm/secretmem.c
index 384f5cfc457f..4e32bf55a599 100644
--- a/mm/secretmem.c
+++ b/mm/secretmem.c
@@ -39,7 +39,7 @@
 
 static bool secretmem_enable __ro_after_init = 1;
 module_param_named(enable, secretmem_enable, bool, 0400);
-MODULE_PARM_DESC(secretmem_enable,
+MODULE_PARM_DESC(enable,
 		 "Enable secretmem and memfd_secret(2) system call");
 
 static atomic_t secretmem_users;

base-commit: 986c24e0fe44f844b44d365b71ce831947f50298
-- 
2.53.0