From: Roman Gushchin <roman.gushchin@linux.dev>
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>,
Ridong Chen <ridong.chen@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
David Hildenbrand <david@kernel.org>,
Qi Zheng <qi.zheng@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Kairui Song <kasong@tencent.com>,
Barry Song <baohua@kernel.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Ridong Chen <chenridong@xiaomi.com>
Subject: Re: [RFC PATCH 0/4] mm/vmscan: honour node reclaim limits per type
Date: Fri, 21 Aug 2026 21:35:04 +0000 [thread overview]
Message-ID: <7ia4tsonw41j.fsf@castle.c.googlers.com> (raw)
In-Reply-To: <aogQ6iDA7RkuTtDG@gremlin> (Lorenzo Stoakes's message of "Fri, 21 Aug 2026 09:58:52 +0100")
"Lorenzo Stoakes (ARM)" <ljs@kernel.org> writes:
> +cc Roman for suggestion.
>
> On Fri, Aug 21, 2026 at 10:31:06AM +0200, Michal Hocko wrote:
>> You are explaining what but missing the most important part _Why_ do we
>> need to have this addressed? Is this just addressing Sashiko review
>> refernced below? Is there any real usecase where the current behavior
>> matters?
>
> This is exactly the issue with these 'unrelated to your patch but' suggestions
> from sashiko.
>
> You end up in loops:
>
> AI generated patch ---------------> AI generated review
> ^ |
> | |
> | v
> AI generated 'unrelated to your patch but'
>
> And _at every stage_ reviewers have to do _additional work_ (with ~50% signal/noise).
>
> This isn't sustainable.
>
> We already had _too much work_ prior to the slopgeddon. Now we have a multiple
> of that.
>
> Roman - I really think we a way of switching off the 'unrelated to your patch
> but' stuff per-subsystem would be useful.
I thought about it, but switching it off completely looks dubious to
me. So maybe moderating it a bit can help? Like not reporting completely
unrelated issues or at least do not report them more than once?
Even if it's only 50% accurate, 50% chance of missing a critical/high severity
bug (other are not reported) sounds bad.
But also I feel like there should be no expectations on fixing
pre-existing issues as something _required_ to land a patch.
It's always a best effort thing.
> Maybe we could figure out a way of funnelling this stuff somewhere separately
> longer term.
Yes, there will be a database available to maintainers soon.
>
> (I have I think 2 slopped fixes to rewrite after the previous what like 7 or 8
> this cycle? So forgive the grumpiness :)
No problems :)
next prev parent reply other threads:[~2026-08-21 21:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 8:17 [RFC PATCH 0/4] mm/vmscan: honour node reclaim limits per type Ridong Chen
2026-08-21 8:17 ` [RFC PATCH 1/4] mm/vmscan: only reclaim slab in node reclaim when over min_slab_pages Ridong Chen
2026-08-21 8:17 ` [RFC PATCH 2/4] mm/vmscan: only reclaim file pages in node reclaim when over min_unmapped_pages Ridong Chen
2026-08-21 8:17 ` [RFC PATCH 3/4] mm/vmscan: drop the combined limit gate in __node_reclaim() Ridong Chen
2026-08-21 12:49 ` Johannes Weiner
2026-08-21 8:17 ` [RFC PATCH 4/4] mm/vmscan: do not skip node reclaim when only anon is reclaimable Ridong Chen
2026-08-21 8:31 ` [RFC PATCH 0/4] mm/vmscan: honour node reclaim limits per type Michal Hocko
2026-08-21 8:58 ` Lorenzo Stoakes (ARM)
2026-08-21 9:21 ` Michal Hocko
2026-08-21 11:16 ` Lorenzo Stoakes (ARM)
2026-08-21 11:26 ` Michal Hocko
2026-08-21 13:43 ` Lorenzo Stoakes (ARM)
2026-08-21 21:35 ` Roman Gushchin [this message]
2026-08-21 21:44 ` John Hubbard
2026-08-21 21:49 ` Roman Gushchin
2026-08-21 9:07 ` Ridong Chen
2026-08-21 9:24 ` Michal Hocko
2026-08-21 10:52 ` Ridong Chen
2026-08-21 11:02 ` Michal Hocko
2026-08-21 11:10 ` Ridong Chen
2026-08-21 11:20 ` Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2026-08-21 8:16 Ridong Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ia4tsonw41j.fsf@castle.c.googlers.com \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=chenridong@xiaomi.com \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=qi.zheng@linux.dev \
--cc=ridong.chen@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox