Re: [PATCH RFC v10 01/22] mm: Introduce kpkeys

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mm: kpkeys: use DEFINE_CLASS_IS_UNCONDITIONAL() in KPKEYS_GUARD
  macros
--

commit fedb14faa9a0bdbbf2b6d66e78122c92692259b9
Author: Kevin Brodsky <kevin.brodsky@arm.com>

mm: Introduce kpkeys

This commit introduces the kpkeys header API, context switching helpers,
and guard class macros for kernel protection keys.

> diff --git a/include/linux/kpkeys.h b/include/linux/kpkeys.h
> new file mode 100644
> index 0000000000000..69ec4808d850d
> --- /dev/null
> +++ b/include/linux/kpkeys.h
> @@ -0,0 +1,107 @@
[ ... ]
> +#define KPKEYS_GUARD_NOOP(name)						\
> +	__DEFINE_CLASS_IS_CONDITIONAL(name, false);			\
> +	DEFINE_CLASS(name, bool, (void)_T, false, void);		\
> +	static inline void *class_##name##_lock_ptr(bool *_T)		\
> +	{ return _T; }
> +
> +#ifdef CONFIG_ARCH_HAS_KPKEYS
> +
> +#include <asm/kpkeys.h>
> +
> +/**
> + * KPKEYS_GUARD_COND() - helper to define a guard type that conditionally
> + *                       switches to a given kpkeys context
> + * @name: the name of the guard type
> + * @ctx: the kpkeys context to switch to
> + * @cond: an expression that is evaluated as condition
> + *
> + * Define a guard type that switches to @ctx if @cond evaluates to true,
> + * and does nothing otherwise.
> + */
> +#define KPKEYS_GUARD_COND(name, ctx, cond)				\
> +	__DEFINE_CLASS_IS_CONDITIONAL(name, false);			\
> +	DEFINE_CLASS(name, struct kpkeys_state,				\
> +		     kpkeys_leave_context(&_T),				\
> +		     (cond) ? kpkeys_enter_context(ctx) :		\
> +			      (struct kpkeys_state) {}, void);		\
> +	static inline							\
> +	void *class_##name##_lock_ptr(struct kpkeys_state *_T)		\
> +	{ return _T; }

[Severity: Low]
Could KPKEYS_GUARD_NOOP() and KPKEYS_GUARD_COND() use
DEFINE_CLASS_IS_UNCONDITIONAL(name) after DEFINE_CLASS() instead of
open-coding __DEFINE_CLASS_IS_CONDITIONAL() and class_##name##_lock_ptr()?
include/linux/cleanup.h already provides DEFINE_CLASS_IS_UNCONDITIONAL() for
this purpose, avoiding reliance on internal cleanup.h helpers.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-kpkeys-v10-0-aa6c4d9603bc@arm.com?part=1