Build breakage in sdhci-s3c

Build breakage in sdhci-s3c

[Mark Brown]

The mmc and therefore -next currently fail to build on Samsung platforms
due to commit 666b6a (mmc: sdhci-s3c: Add pm_caps into SD/MMC host)
which added use of a new field pm_caps in the platform data without
actually adding that field to the struct.  I guess there's a separate
patch floating about somewhere which adds the field but it's not in
-next and both commits should be going in via the same tree to avoid
bisection breakage - ideally both the field and its use should be added
as part of a single commit.

Re: Build breakage in sdhci-s3c

[Sangwook Lee]

Hi Kukjin

I checked out your git to look into Mark's email.

git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for-next

and I found out that the following patch wasn't applied This  patch
was acked by you and Thomas.

http://comments.gmane.org/gmane.linux.kernel.samsung-soc/7832
This patch has the title : [PATCH v2 1/2] ARM: SAMSUNG: Add pm_caps
into platform data

Could you help me to solve the below problem ?

Thanks
Sangwook


On 2 December 2011 11:58, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> The mmc and therefore -next currently fail to build on Samsung platforms
> due to commit 666b6a (mmc: sdhci-s3c: Add pm_caps into SD/MMC host)
> which added use of a new field pm_caps in the platform data without
> actually adding that field to the struct.  I guess there's a separate
> patch floating about somewhere which adds the field but it's not in
> -next and both commits should be going in via the same tree to avoid
> bisection breakage - ideally both the field and its use should be added
> as part of a single commit.

Re: Build breakage in sdhci-s3c

[Mark Brown]

On Fri, Dec 02, 2011 at 12:59:42PM +0000, Sangwook Lee wrote:

> and I found out that the following patch wasn't applied This  patch
> was acked by you and Thomas.

> http://comments.gmane.org/gmane.linux.kernel.samsung-soc/7832
> This patch has the title : [PATCH v2 1/2] ARM: SAMSUNG: Add pm_caps
> into platform data

> Could you help me to solve the below problem ?

Probably the simplest/best solution here is for Chris to apply this
patch with Kukjin and Thomas' acks to the mmc tree.

Re: Build breakage in sdhci-s3c

[Sangwook Lee]

+Thomas


On 2 December 2011 13:04, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, Dec 02, 2011 at 12:59:42PM +0000, Sangwook Lee wrote:
>
>> and I found out that the following patch wasn't applied This  patch
>> was acked by you and Thomas.
>
>> http://comments.gmane.org/gmane.linux.kernel.samsung-soc/7832
>> This patch has the title : [PATCH v2 1/2] ARM: SAMSUNG: Add pm_caps
>> into platform data
>
>> Could you help me to solve the below problem ?
>
> Probably the simplest/best solution here is for Chris to apply this
> patch with Kukjin and Thomas' acks to the mmc tree.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Build breakage in sdhci-s3c

[Kukjin Kim]

Mark Brown wrote:
> 
> On Fri, Dec 02, 2011 at 12:59:42PM +0000, Sangwook Lee wrote:
> 
> > and I found out that the following patch wasn't applied This  patch
> > was acked by you and Thomas.
> 
> > http://comments.gmane.org/gmane.linux.kernel.samsung-soc/7832
> > This patch has the title : [PATCH v2 1/2] ARM: SAMSUNG: Add pm_caps
> > into platform data
> 
> > Could you help me to solve the below problem ?
> 
> Probably the simplest/best solution here is for Chris to apply this
> patch with Kukjin and Thomas' acks to the mmc tree.

Uhm...it is due to late pushing from my local, I need to sort out my tree
now :(

Anyway, Mark's suggestion makes sense, in this case. Because it can be
happened during merge window even though I solve/push it now.

Hi Chris,
Could you please pick up Sangwook Lee's '[PATCH v2 1/2] ARM: SAMSUNG: Add
pm_caps into platform data' with my ack?

If any problems, please let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.