* [PATCH] mmc: dw_mmc: convert the variable type of irq
@ 2012-09-28 5:21 Seungwon Jeon
2012-09-28 10:00 ` Will Newton
0 siblings, 1 reply; 3+ messages in thread
From: Seungwon Jeon @ 2012-09-28 5:21 UTC (permalink / raw)
To: linux-mmc
Cc: 'Chris Ball', 'Will Newton',
'James Hogan'
Even though platform_get_irq returns error, 'host->irq'
always has an unsigned value. Less-than-zero comparison
of an unsigned value is never true. Type of 'unsigned int'
will be changed for 'int'.
Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
---
include/linux/mmc/dw_mmc.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
index 7c6a113..3141676 100644
--- a/include/linux/mmc/dw_mmc.h
+++ b/include/linux/mmc/dw_mmc.h
@@ -186,7 +186,7 @@ struct dw_mci {
struct regulator *vmmc; /* Power regulator */
unsigned long irq_flags; /* IRQ flags */
- unsigned int irq;
+ int irq;
};
/* DMA ops for Internal/External DMAC interface */
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: dw_mmc: convert the variable type of irq
2012-09-28 5:21 [PATCH] mmc: dw_mmc: convert the variable type of irq Seungwon Jeon
@ 2012-09-28 10:00 ` Will Newton
2012-10-23 21:03 ` Chris Ball
0 siblings, 1 reply; 3+ messages in thread
From: Will Newton @ 2012-09-28 10:00 UTC (permalink / raw)
To: Seungwon Jeon; +Cc: linux-mmc, Chris Ball, Will Newton, James Hogan
On Fri, Sep 28, 2012 at 6:21 AM, Seungwon Jeon <tgih.jun@samsung.com> wrote:
> Even though platform_get_irq returns error, 'host->irq'
> always has an unsigned value. Less-than-zero comparison
> of an unsigned value is never true. Type of 'unsigned int'
> will be changed for 'int'.
>
> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
> ---
> include/linux/mmc/dw_mmc.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Acked-by: Will Newton <will.newton@imgtec.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: dw_mmc: convert the variable type of irq
2012-09-28 10:00 ` Will Newton
@ 2012-10-23 21:03 ` Chris Ball
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ball @ 2012-10-23 21:03 UTC (permalink / raw)
To: Will Newton; +Cc: Seungwon Jeon, linux-mmc, Will Newton, James Hogan
Hi,
On Fri, Sep 28 2012, Will Newton wrote:
> On Fri, Sep 28, 2012 at 6:21 AM, Seungwon Jeon <tgih.jun@samsung.com> wrote:
>> Even though platform_get_irq returns error, 'host->irq'
>> always has an unsigned value. Less-than-zero comparison
>> of an unsigned value is never true. Type of 'unsigned int'
>> will be changed for 'int'.
>>
>> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
>> ---
>> include/linux/mmc/dw_mmc.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Acked-by: Will Newton <will.newton@imgtec.com>
Thanks, pushed to mmc-next for 3.8.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-23 21:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-28 5:21 [PATCH] mmc: dw_mmc: convert the variable type of irq Seungwon Jeon
2012-09-28 10:00 ` Will Newton
2012-10-23 21:03 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox