* [patch] mmc: sdhci-of-at91: remove a line of dead code
@ 2015-09-16 6:19 Dan Carpenter
2015-09-17 6:46 ` Ludovic Desroches
2015-09-17 8:49 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-09-16 6:19 UTC (permalink / raw)
To: Ludovic Desroches; +Cc: Ulf Hansson, linux-mmc, kernel-janitors
The goto is correct and the unreachable "return -EINVAL" should be
removed.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
index d155664..d3df786 100644
--- a/drivers/mmc/host/sdhci-of-at91.c
+++ b/drivers/mmc/host/sdhci-of-at91.c
@@ -110,7 +110,6 @@ static int sdhci_at91_probe(struct platform_device *pdev)
if (ret < 0) {
dev_err(&pdev->dev, "failed to set gck");
goto hclock_disable_unprepare;
- return -EINVAL;
}
/*
* We need to check if we have the requested rate for gck because in
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] mmc: sdhci-of-at91: remove a line of dead code
2015-09-16 6:19 [patch] mmc: sdhci-of-at91: remove a line of dead code Dan Carpenter
@ 2015-09-17 6:46 ` Ludovic Desroches
2015-09-17 8:49 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Desroches @ 2015-09-17 6:46 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Ludovic Desroches, Ulf Hansson, linux-mmc, kernel-janitors
On Wed, Sep 16, 2015 at 09:19:49AM +0300, Dan Carpenter wrote:
> The goto is correct and the unreachable "return -EINVAL" should be
> removed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Of course
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Thanks
>
> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
> index d155664..d3df786 100644
> --- a/drivers/mmc/host/sdhci-of-at91.c
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> @@ -110,7 +110,6 @@ static int sdhci_at91_probe(struct platform_device *pdev)
> if (ret < 0) {
> dev_err(&pdev->dev, "failed to set gck");
> goto hclock_disable_unprepare;
> - return -EINVAL;
> }
> /*
> * We need to check if we have the requested rate for gck because in
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] mmc: sdhci-of-at91: remove a line of dead code
2015-09-16 6:19 [patch] mmc: sdhci-of-at91: remove a line of dead code Dan Carpenter
2015-09-17 6:46 ` Ludovic Desroches
@ 2015-09-17 8:49 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2015-09-17 8:49 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Ludovic Desroches, linux-mmc, kernel-janitors
On 16 September 2015 at 08:19, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The goto is correct and the unreachable "return -EINVAL" should be
> removed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied for next!
Kind regards
Uffe
>
> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
> index d155664..d3df786 100644
> --- a/drivers/mmc/host/sdhci-of-at91.c
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> @@ -110,7 +110,6 @@ static int sdhci_at91_probe(struct platform_device *pdev)
> if (ret < 0) {
> dev_err(&pdev->dev, "failed to set gck");
> goto hclock_disable_unprepare;
> - return -EINVAL;
> }
> /*
> * We need to check if we have the requested rate for gck because in
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-17 8:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 6:19 [patch] mmc: sdhci-of-at91: remove a line of dead code Dan Carpenter
2015-09-17 6:46 ` Ludovic Desroches
2015-09-17 8:49 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox