From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, Faiz Abbas <faiz_abbas@ti.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Thierry Reding <treding@nvidia.com>
Subject: [PATCH v2 3/3] mmc: sdhci-tegra: drop ->get_ro() implementation
Date: Mon, 11 Feb 2019 14:23:42 +0100 [thread overview]
Message-ID: <20190211132342.31009-4-thomas.petazzoni@bootlin.com> (raw)
In-Reply-To: <20190211132342.31009-1-thomas.petazzoni@bootlin.com>
The SDHCI core is know properly checking for the state of a WP GPIO,
so there is no longer any need for the sdhci-tegra code to implement
->get_ro() using mmc_gpio_get_ro().
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Tested-by: Thierry Reding <treding@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
---
Changes since v1:
- Added Tested-by/Acked-by from Thierry Reding
Note: this patch has only been compiled tested, as I don't have the
hardware to test it.
---
drivers/mmc/host/sdhci-tegra.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index e6ace31e2a41..6ed7323bf030 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -237,11 +237,6 @@ static void tegra210_sdhci_writew(struct sdhci_host *host, u16 val, int reg)
}
}
-static unsigned int tegra_sdhci_get_ro(struct sdhci_host *host)
-{
- return mmc_gpio_get_ro(host->mmc);
-}
-
static bool tegra_sdhci_is_pad_and_regulator_valid(struct sdhci_host *host)
{
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
@@ -837,7 +832,6 @@ static void tegra_sdhci_voltage_switch(struct sdhci_host *host)
}
static const struct sdhci_ops tegra_sdhci_ops = {
- .get_ro = tegra_sdhci_get_ro,
.read_w = tegra_sdhci_readw,
.write_l = tegra_sdhci_writel,
.set_clock = tegra_sdhci_set_clock,
@@ -893,7 +887,6 @@ static const struct sdhci_tegra_soc_data soc_data_tegra30 = {
};
static const struct sdhci_ops tegra114_sdhci_ops = {
- .get_ro = tegra_sdhci_get_ro,
.read_w = tegra_sdhci_readw,
.write_w = tegra_sdhci_writew,
.write_l = tegra_sdhci_writel,
@@ -947,7 +940,6 @@ static const struct sdhci_tegra_soc_data soc_data_tegra124 = {
};
static const struct sdhci_ops tegra210_sdhci_ops = {
- .get_ro = tegra_sdhci_get_ro,
.read_w = tegra_sdhci_readw,
.write_w = tegra210_sdhci_writew,
.write_l = tegra_sdhci_writel,
@@ -980,7 +972,6 @@ static const struct sdhci_tegra_soc_data soc_data_tegra210 = {
};
static const struct sdhci_ops tegra186_sdhci_ops = {
- .get_ro = tegra_sdhci_get_ro,
.read_w = tegra_sdhci_readw,
.write_l = tegra_sdhci_writel,
.set_clock = tegra_sdhci_set_clock,
--
2.20.1
next prev parent reply other threads:[~2019-02-11 13:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 13:23 [PATCH v2 0/3] mmc: Introduce support for WP GPIO in the core SDHCI Thomas Petazzoni
2019-02-11 13:23 ` [PATCH v2 1/3] mmc: sdhci: use WP GPIO in sdhci_check_ro() Thomas Petazzoni
2019-02-12 8:08 ` Adrian Hunter
2019-02-11 13:23 ` [PATCH v2 2/3] mmc: sdhci-omap: drop ->get_ro() implementation Thomas Petazzoni
2019-02-12 8:11 ` Adrian Hunter
2019-02-12 8:13 ` Kishon Vijay Abraham I
2019-02-11 13:23 ` Thomas Petazzoni [this message]
2019-02-12 8:11 ` [PATCH v2 3/3] mmc: sdhci-tegra: " Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211132342.31009-4-thomas.petazzoni@bootlin.com \
--to=thomas.petazzoni@bootlin.com \
--cc=adrian.hunter@intel.com \
--cc=faiz_abbas@ti.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox