From: Kishon Vijay Abraham I <kishon@ti.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, Faiz Abbas <faiz_abbas@ti.com>,
Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH v2 2/3] mmc: sdhci-omap: drop ->get_ro() implementation
Date: Tue, 12 Feb 2019 13:43:33 +0530 [thread overview]
Message-ID: <2f0ccc6c-9d35-ccf1-7587-7ad0ebfe6e97@ti.com> (raw)
In-Reply-To: <0af919d0-3a35-7aa1-bdd1-4d42128809c9@intel.com>
On 12/02/19 1:41 PM, Adrian Hunter wrote:
> On 11/02/19 3:23 PM, Thomas Petazzoni wrote:
>> The SDHCI core is now properly checking for the state of a WP GPIO,
>> so there is no longer any need for the sdhci-omap code to implement
>> ->get_ro() using mmc_gpio_get_ro().
>>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>> Reviewed-by: Thierry Reding <treding@nvidia.com>
>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>
>> ---
>> Changes since v1:
>> - Added Reviewed-by from Thierry Reding
>> - Fix typo in commit log s/know/now/ noticed by Thierry Reding
>>
>> Note: this patch has only been compiled tested, as I don't have the
>> hardware to test it.
>> ---
>> drivers/mmc/host/sdhci-omap.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
>> index d264391616f9..c2a28930086f 100644
>> --- a/drivers/mmc/host/sdhci-omap.c
>> +++ b/drivers/mmc/host/sdhci-omap.c
>> @@ -987,7 +987,6 @@ static int sdhci_omap_probe(struct platform_device *pdev)
>> goto err_put_sync;
>> }
>>
>> - host->mmc_host_ops.get_ro = mmc_gpio_get_ro;
>> host->mmc_host_ops.start_signal_voltage_switch =
>> sdhci_omap_start_signal_voltage_switch;
>> host->mmc_host_ops.set_ios = sdhci_omap_set_ios;
>>
>
next prev parent reply other threads:[~2019-02-12 8:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 13:23 [PATCH v2 0/3] mmc: Introduce support for WP GPIO in the core SDHCI Thomas Petazzoni
2019-02-11 13:23 ` [PATCH v2 1/3] mmc: sdhci: use WP GPIO in sdhci_check_ro() Thomas Petazzoni
2019-02-12 8:08 ` Adrian Hunter
2019-02-11 13:23 ` [PATCH v2 2/3] mmc: sdhci-omap: drop ->get_ro() implementation Thomas Petazzoni
2019-02-12 8:11 ` Adrian Hunter
2019-02-12 8:13 ` Kishon Vijay Abraham I [this message]
2019-02-11 13:23 ` [PATCH v2 3/3] mmc: sdhci-tegra: " Thomas Petazzoni
2019-02-12 8:11 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f0ccc6c-9d35-ccf1-7587-7ad0ebfe6e97@ti.com \
--to=kishon@ti.com \
--cc=adrian.hunter@intel.com \
--cc=faiz_abbas@ti.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=treding@nvidia.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox