public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: rashmi.a@intel.com
To: linux-drivers-review-request@eclists.intel.com,
	michal.simek@xilinx.com, ulf.hansson@linaro.org,
	linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kishon@ti.com, vkoul@kernel.org,
	andriy.shevchenko@linux.intel.com, linux-phy@lists.infradead.org
Cc: mgross@linux.intel.com, kris.pan@linux.intel.com,
	furong.zhou@intel.com, mallikarjunappa.sangannavar@intel.com,
	adrian.hunter@intel.com, mahesh.r.vaidya@intel.com,
	nandhini.srikandan@intel.com,
	lakshmi.bai.raja.subramanian@intel.com, rashmi.a@intel.com
Subject: [“PATCH” 2/2] phy: intel: Fix for warnings due to EMMC clock 175Mhz change in FIP
Date: Thu,  3 Jun 2021 23:52:42 +0530	[thread overview]
Message-ID: <20210603182242.25733-3-rashmi.a@intel.com> (raw)
In-Reply-To: <20210603182242.25733-1-rashmi.a@intel.com>

From: Rashmi A <rashmi.a@intel.com>

Since the EMMC clock was changed from 200Mhz to 175Mhz in FIP,
there were some warnings introduced, as the frequency values
being checked was still wrt 200Mhz in code. Hence, the frequency
checks are now updated based on the current 175Mhz EMMC clock changed
in FIP.

Spamming kernel log msg:
"phy phy-20290000.mmc_phy.2: Unsupported rate: 43750000"

Signed-off-by: Rashmi A <rashmi.a@intel.com>
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
---
 drivers/phy/intel/phy-intel-keembay-emmc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/phy/intel/phy-intel-keembay-emmc.c b/drivers/phy/intel/phy-intel-keembay-emmc.c
index eb7c635ed89a..0eb11ac7c2e2 100644
--- a/drivers/phy/intel/phy-intel-keembay-emmc.c
+++ b/drivers/phy/intel/phy-intel-keembay-emmc.c
@@ -95,7 +95,8 @@ static int keembay_emmc_phy_power(struct phy *phy, bool on_off)
 	else
 		freqsel = 0x0;
 
-	if (mhz < 50 || mhz > 200)
+	/* Check for EMMC clock rate*/
+	if (mhz > 175)
 		dev_warn(&phy->dev, "Unsupported rate: %d MHz\n", mhz);
 
 	/*
-- 
2.17.1


  parent reply	other threads:[~2021-06-03 18:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 18:22 [“PATCH” 0/2] [KMB] mmc clock-frequency property update and rashmi.a
2021-06-03 18:22 ` [“PATCH” 1/2] mmc: sdhci-of-arasan: Use clock-frequency property to update clk_xin rashmi.a
2021-06-04  6:13   ` Michal Simek
2021-06-17 10:04     ` Ulf Hansson
2021-06-17 10:18       ` Sai Krishna Potthuri
2021-06-03 18:22 ` rashmi.a [this message]
2021-06-08 12:52   ` [“PATCH” 2/2] phy: intel: Fix for warnings due to EMMC clock 175Mhz change in FIP Ulf Hansson
2021-06-09  3:40     ` Vinod Koul
2021-06-29 15:08 ` [“PATCH” 0/2] [KMB] mmc clock-frequency property update and Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210603182242.25733-3-rashmi.a@intel.com \
    --to=rashmi.a@intel.com \
    --cc=adrian.hunter@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=furong.zhou@intel.com \
    --cc=kishon@ti.com \
    --cc=kris.pan@linux.intel.com \
    --cc=lakshmi.bai.raja.subramanian@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-drivers-review-request@eclists.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mahesh.r.vaidya@intel.com \
    --cc=mallikarjunappa.sangannavar@intel.com \
    --cc=mgross@linux.intel.com \
    --cc=michal.simek@xilinx.com \
    --cc=nandhini.srikandan@intel.com \
    --cc=ulf.hansson@linaro.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox