* [PATCH] dt-bindings: mmc: PL18x stop relying on order of dma-names
@ 2021-12-24 19:25 David Heidelberg
2021-12-26 3:31 ` Linus Walleij
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: David Heidelberg @ 2021-12-24 19:25 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Linus Walleij, Thierry Reding
Cc: ~okias/devicetree, David Heidelberg, Rob Herring, linux-mmc,
devicetree, linux-kernel
We don't care in which order are "rx" and "tx" DMA names supplied.
Fixes: 4df297aaeb9c ("dt-bindings: mmc: Add missing properties used in examples")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
index f0a44b2cfa79..a4f74bec68a3 100644
--- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
+++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
@@ -70,9 +70,13 @@ properties:
maxItems: 2
dma-names:
- items:
- - const: rx
- - const: tx
+ oneOf:
+ - items:
+ - const: tx
+ - const: rx
+ - items:
+ - const: rx
+ - const: tx
power-domains: true
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: mmc: PL18x stop relying on order of dma-names
2021-12-24 19:25 [PATCH] dt-bindings: mmc: PL18x stop relying on order of dma-names David Heidelberg
@ 2021-12-26 3:31 ` Linus Walleij
2021-12-28 16:58 ` Ulf Hansson
2022-01-04 18:53 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2021-12-26 3:31 UTC (permalink / raw)
To: David Heidelberg
Cc: Ulf Hansson, Rob Herring, Thierry Reding, ~okias/devicetree,
Rob Herring, linux-mmc, devicetree, linux-kernel
On Fri, Dec 24, 2021 at 8:25 PM David Heidelberg <david@ixit.cz> wrote:
> We don't care in which order are "rx" and "tx" DMA names supplied.
>
> Fixes: 4df297aaeb9c ("dt-bindings: mmc: Add missing properties used in examples")
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
Good catch!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: mmc: PL18x stop relying on order of dma-names
2021-12-24 19:25 [PATCH] dt-bindings: mmc: PL18x stop relying on order of dma-names David Heidelberg
2021-12-26 3:31 ` Linus Walleij
@ 2021-12-28 16:58 ` Ulf Hansson
2022-01-04 18:53 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2021-12-28 16:58 UTC (permalink / raw)
To: David Heidelberg
Cc: Rob Herring, Linus Walleij, Thierry Reding, ~okias/devicetree,
Rob Herring, linux-mmc, devicetree, linux-kernel
On Fri, 24 Dec 2021 at 20:25, David Heidelberg <david@ixit.cz> wrote:
>
> We don't care in which order are "rx" and "tx" DMA names supplied.
>
> Fixes: 4df297aaeb9c ("dt-bindings: mmc: Add missing properties used in examples")
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> index f0a44b2cfa79..a4f74bec68a3 100644
> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> @@ -70,9 +70,13 @@ properties:
> maxItems: 2
>
> dma-names:
> - items:
> - - const: rx
> - - const: tx
> + oneOf:
> + - items:
> + - const: tx
> + - const: rx
> + - items:
> + - const: rx
> + - const: tx
>
> power-domains: true
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: mmc: PL18x stop relying on order of dma-names
2021-12-24 19:25 [PATCH] dt-bindings: mmc: PL18x stop relying on order of dma-names David Heidelberg
2021-12-26 3:31 ` Linus Walleij
2021-12-28 16:58 ` Ulf Hansson
@ 2022-01-04 18:53 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-01-04 18:53 UTC (permalink / raw)
To: David Heidelberg
Cc: Ulf Hansson, Linus Walleij, Thierry Reding, ~okias/devicetree,
linux-mmc, devicetree, linux-kernel
On Fri, Dec 24, 2021 at 08:25:45PM +0100, David Heidelberg wrote:
> We don't care in which order are "rx" and "tx" DMA names supplied.
>
I do. Other than avoiding dts changes, why do we need undefined order
here?
> Fixes: 4df297aaeb9c ("dt-bindings: mmc: Add missing properties used in examples")
>
Drop the blank line.
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> index f0a44b2cfa79..a4f74bec68a3 100644
> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> @@ -70,9 +70,13 @@ properties:
> maxItems: 2
>
> dma-names:
> - items:
> - - const: rx
> - - const: tx
> + oneOf:
> + - items:
> + - const: tx
> + - const: rx
> + - items:
> + - const: rx
> + - const: tx
For future reference, the concise way to express this is:
maxItems: 2
items:
enum: [ rx, tx ]
>
> power-domains: true
>
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-04 18:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-24 19:25 [PATCH] dt-bindings: mmc: PL18x stop relying on order of dma-names David Heidelberg
2021-12-26 3:31 ` Linus Walleij
2021-12-28 16:58 ` Ulf Hansson
2022-01-04 18:53 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox