From: Victor Shih <victorshihgli@gmail.com>
To: ulf.hansson@linaro.org, adrian.hunter@intel.com
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
benchuanggli@gmail.com, Lucas.Lai@genesyslogic.com.tw,
HL.Liu@genesyslogic.com.tw, Greg.tu@genesyslogic.com.tw,
dlunev@chromium.org, Victor Shih <victorshihgli@gmail.com>,
Victor Shih <victor.shih@genesyslogic.com.tw>
Subject: [PATCH V20 06/22] mmc: core: Add New function to re-factoring the code
Date: Thu, 5 Sep 2024 18:19:44 +0800 [thread overview]
Message-ID: <20240905102000.5020-7-victorshihgli@gmail.com> (raw)
In-Reply-To: <20240905102000.5020-1-victorshihgli@gmail.com>
From: Victor Shih <victor.shih@genesyslogic.com.tw>
Add __mmc_go_idle function to re-factoring mmc_go_idle function.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Victor Shih <victor.shih@genesyslogic.com.tw>
---
drivers/mmc/core/mmc_ops.c | 24 ++++++++++++++++--------
drivers/mmc/core/mmc_ops.h | 1 +
2 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
index 3b3adbddf664..5c8e62e8f331 100644
--- a/drivers/mmc/core/mmc_ops.c
+++ b/drivers/mmc/core/mmc_ops.c
@@ -144,10 +144,24 @@ int mmc_set_dsr(struct mmc_host *host)
return mmc_wait_for_cmd(host, &cmd, MMC_CMD_RETRIES);
}
+int __mmc_go_idle(struct mmc_host *host)
+{
+ struct mmc_command cmd = {};
+ int err;
+
+ cmd.opcode = MMC_GO_IDLE_STATE;
+ cmd.arg = 0;
+ cmd.flags = MMC_RSP_SPI_R1 | MMC_RSP_NONE | MMC_CMD_BC;
+
+ err = mmc_wait_for_cmd(host, &cmd, 0);
+ mmc_delay(1);
+
+ return err;
+}
+
int mmc_go_idle(struct mmc_host *host)
{
int err;
- struct mmc_command cmd = {};
/*
* Non-SPI hosts need to prevent chipselect going active during
@@ -163,13 +177,7 @@ int mmc_go_idle(struct mmc_host *host)
mmc_delay(1);
}
- cmd.opcode = MMC_GO_IDLE_STATE;
- cmd.arg = 0;
- cmd.flags = MMC_RSP_SPI_R1 | MMC_RSP_NONE | MMC_CMD_BC;
-
- err = mmc_wait_for_cmd(host, &cmd, 0);
-
- mmc_delay(1);
+ err = __mmc_go_idle(host);
if (!mmc_host_is_spi(host)) {
mmc_set_chip_select(host, MMC_CS_DONTCARE);
diff --git a/drivers/mmc/core/mmc_ops.h b/drivers/mmc/core/mmc_ops.h
index 06017110e1b0..0df3ebd900d1 100644
--- a/drivers/mmc/core/mmc_ops.h
+++ b/drivers/mmc/core/mmc_ops.h
@@ -25,6 +25,7 @@ struct mmc_command;
int mmc_select_card(struct mmc_card *card);
int mmc_deselect_cards(struct mmc_host *host);
int mmc_set_dsr(struct mmc_host *host);
+int __mmc_go_idle(struct mmc_host *host);
int mmc_go_idle(struct mmc_host *host);
int mmc_send_op_cond(struct mmc_host *host, u32 ocr, u32 *rocr);
int mmc_set_relative_addr(struct mmc_card *card);
--
2.25.1
next prev parent reply other threads:[~2024-09-05 10:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 10:19 [PATCH V20 00/22] Add support UHS-II for GL9755 and GL9767 Victor Shih
2024-09-05 10:19 ` [PATCH V20 01/22] mmc: core: Cleanup printing of speed mode at card insertion Victor Shih
2024-09-05 10:19 ` [PATCH V20 02/22] mmc: core: Prepare to support SD UHS-II cards Victor Shih
2024-09-05 10:19 ` [PATCH V20 03/22] mmc: core: Announce successful insertion of an SD UHS-II card Victor Shih
2024-09-05 10:19 ` [PATCH V20 04/22] mmc: core: Extend support for mmc regulators with a vqmmc2 Victor Shih
2024-09-05 10:19 ` [PATCH V20 05/22] mmc: core: Add definitions for SD UHS-II cards Victor Shih
2024-09-05 10:19 ` Victor Shih [this message]
2024-09-05 10:19 ` [PATCH V20 07/22] mmc: core: Support UHS-II card control and access Victor Shih
2024-09-05 10:19 ` [PATCH V20 08/22] mmc: sdhci: add UHS-II related definitions in headers Victor Shih
2024-09-05 10:19 ` [PATCH V20 09/22] mmc: sdhci: add UHS-II module and add a kernel configuration Victor Shih
2024-09-05 10:19 ` [PATCH V20 10/22] mmc: sdhci-uhs2: dump UHS-II registers Victor Shih
2024-09-05 10:19 ` [PATCH V20 11/22] mmc: sdhci-uhs2: add reset function Victor Shih
2024-09-05 10:19 ` [PATCH V20 12/22] mmc: sdhci-uhs2: add set_power() to support vdd2 Victor Shih
2024-09-05 10:19 ` [PATCH V20 13/22] mmc: sdhci-uhs2: add set_timeout() Victor Shih
2024-09-05 10:19 ` [PATCH V20 14/22] mmc: sdhci-uhs2: add set_ios() Victor Shih
2024-09-05 10:19 ` [PATCH V20 15/22] mmc: sdhci-uhs2: add uhs2_control() to initialise the interface Victor Shih
2024-09-05 10:19 ` [PATCH V20 16/22] mmc: sdhci-uhs2: add request() and others Victor Shih
2024-09-05 10:19 ` [PATCH V20 17/22] mmc: sdhci-uhs2: add irq() " Victor Shih
2024-09-05 10:19 ` [PATCH V20 18/22] mmc: sdhci-uhs2: add add_host() and others to set up the driver Victor Shih
2024-09-05 10:19 ` [PATCH V20 19/22] mmc: sdhci-uhs2: add pre-detect_init hook Victor Shih
2024-09-05 10:19 ` [PATCH V20 20/22] mmc: sdhci-pci: add UHS-II support framework Victor Shih
2024-09-05 10:19 ` [PATCH V20 21/22] mmc: sdhci-pci-gli: enable UHS-II mode for GL9755 Victor Shih
2024-09-05 13:55 ` Adrian Hunter
2024-09-06 9:58 ` Victor Shih
2024-09-05 10:20 ` [PATCH V20 22/22] mmc: sdhci-pci-gli: enable UHS-II mode for GL9767 Victor Shih
2024-09-05 13:58 ` [PATCH V20 00/22] Add support UHS-II for GL9755 and GL9767 Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905102000.5020-7-victorshihgli@gmail.com \
--to=victorshihgli@gmail.com \
--cc=Greg.tu@genesyslogic.com.tw \
--cc=HL.Liu@genesyslogic.com.tw \
--cc=Lucas.Lai@genesyslogic.com.tw \
--cc=adrian.hunter@intel.com \
--cc=benchuanggli@gmail.com \
--cc=dlunev@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=victor.shih@genesyslogic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox