From: Marek Vasut <marex@denx.de>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Avri Altman <avri.altman@wdc.com>, Bo Liu <liubo03@inspur.com>,
Deren Wu <deren.wu@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Pierre Ossman <pierre@ossman.eu>,
Russell King <linux@armlinux.org.uk>,
Yang Yingliang <yangyingliang@huawei.com>
Subject: Re: [PATCH 01/11] mmc: core: Use BIT() macro
Date: Wed, 21 Jun 2023 04:36:17 +0200 [thread overview]
Message-ID: <289cd876-e6e1-8610-bcb6-b0259c68fd89@denx.de> (raw)
In-Reply-To: <CAPDyKFqZ_r=gjpRm833ax4LwASCTGAuO0a0ABXo-kN8dtYje-Q@mail.gmail.com>
On 6/20/23 13:15, Ulf Hansson wrote:
> On Tue, 20 Jun 2023 at 12:47, Marek Vasut <marex@denx.de> wrote:
>>
>> Use the BIT(n) macro instead of (1<<n), no functional change.
>> Regex 's@(1 \?<< \?\([0-9A-Z_]\+\))@BIT(\1)' .
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>
> I don't think the benefit of this change is worth it. For example,
> it's quite useful to run a git blame to see the history of what has
> happened.
Understood.
git blame does allow you to specify either --since or revision range though.
> So, sorry, but I am not going to pick this up - or any other similar
> changes, at least for the core layer.
Is this a policy of the mmc subsystem to reject all code clean ups then ?
next prev parent reply other threads:[~2023-06-21 2:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 10:47 [PATCH 01/11] mmc: core: Use BIT() macro Marek Vasut
2023-06-20 10:47 ` [PATCH 02/11] mmc: card: " Marek Vasut
2023-06-20 10:47 ` [PATCH 03/11] mmc: host: " Marek Vasut
2023-06-20 10:47 ` [PATCH 04/11] mmc: mmc: " Marek Vasut
2023-06-20 10:47 ` [PATCH 05/11] mmc: sd: " Marek Vasut
2023-06-20 10:47 ` [PATCH 06/11] mmc: sdio: " Marek Vasut
2023-06-20 10:47 ` [PATCH 07/11] mmc: mmci: " Marek Vasut
2023-06-20 10:47 ` [PATCH 08/11] mmc: pxav3: " Marek Vasut
2023-06-20 10:47 ` [PATCH 09/11] mmc: sdhci: " Marek Vasut
2023-06-20 10:47 ` [PATCH 10/11] mmc: vub300: " Marek Vasut
2023-06-20 10:47 ` [PATCH 11/11] mmc: wbsd: " Marek Vasut
2023-06-20 11:15 ` [PATCH 01/11] mmc: core: " Ulf Hansson
2023-06-21 2:36 ` Marek Vasut [this message]
2023-06-21 9:18 ` Ulf Hansson
2023-06-21 10:28 ` Marek Vasut
2023-06-21 11:23 ` Christian Loehle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=289cd876-e6e1-8610-bcb6-b0259c68fd89@denx.de \
--to=marex@denx.de \
--cc=adrian.hunter@intel.com \
--cc=avri.altman@wdc.com \
--cc=deren.wu@mediatek.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liubo03@inspur.com \
--cc=p.zabel@pengutronix.de \
--cc=pierre@ossman.eu \
--cc=ulf.hansson@linaro.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox