* Re: [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h
2017-07-17 1:23 [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h Jean-Francois Dagenais
@ 2017-07-17 6:33 ` Michal Simek
2017-07-17 13:26 ` Jean-Francois Dagenais
2017-07-21 13:35 ` Adrian Hunter
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Michal Simek @ 2017-07-17 6:33 UTC (permalink / raw)
To: Jean-Francois Dagenais, adrian.hunter, michal.simek, ulf.hansson
Cc: linux-mmc
On 17.7.2017 03:23, Jean-Francois Dagenais wrote:
> This increases consistency of the code across the sdhci family.
>
> v2: rebased onto ulfh/mmc/next and tweaked headline accordingly.
Information about patch version shouldn't be the part of commit message
but they should be placed below ---.
Thanks,
Michal
>
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index b13c0a7d50e4..528a5d24c0bc 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -216,13 +216,13 @@ static void sdhci_arasan_hs400_enhanced_strobe(struct mmc_host *mmc,
> u32 vendor;
> struct sdhci_host *host = mmc_priv(mmc);
>
> - vendor = readl(host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> + vendor = sdhci_readl(host, SDHCI_ARASAN_VENDOR_REGISTER);
> if (ios->enhanced_strobe)
> vendor |= VENDOR_ENHANCED_STROBE;
> else
> vendor &= ~VENDOR_ENHANCED_STROBE;
>
> - writel(vendor, host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> + sdhci_writel(host, vendor, SDHCI_ARASAN_VENDOR_REGISTER);
> }
>
> static void sdhci_arasan_reset(struct sdhci_host *host, u8 mask)
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h
2017-07-17 6:33 ` Michal Simek
@ 2017-07-17 13:26 ` Jean-Francois Dagenais
0 siblings, 0 replies; 6+ messages in thread
From: Jean-Francois Dagenais @ 2017-07-17 13:26 UTC (permalink / raw)
To: Michal Simek; +Cc: linux-mmc
> On Jul 17, 2017, at 02:33, Michal Simek <michal.simek@xilinx.com> wrote:
>
> Information about patch version shouldn't be the part of commit message
> but they should be placed below ---.
Sorry, still perfecting this mailing patches art. Wish it was merge requests on
github... less decorum and chances to get it wrong!
I had put the "-v2" switch on "git send-email" but it didn't appear in the
commit msg??
Also, I got a "kbuild test robot" build regression notice, but the contained
errors seem unrelated to my patch... Should I do anything about that?
Should I formulate a v3?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h
2017-07-17 1:23 [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h Jean-Francois Dagenais
2017-07-17 6:33 ` Michal Simek
@ 2017-07-21 13:35 ` Adrian Hunter
2017-07-22 13:17 ` Shawn Lin
2017-07-27 14:48 ` Ulf Hansson
3 siblings, 0 replies; 6+ messages in thread
From: Adrian Hunter @ 2017-07-21 13:35 UTC (permalink / raw)
To: Jean-Francois Dagenais, michal.simek, ulf.hansson; +Cc: linux-mmc
On 17/07/17 04:23, Jean-Francois Dagenais wrote:
> This increases consistency of the code across the sdhci family.
>
> v2: rebased onto ulfh/mmc/next and tweaked headline accordingly.
As mentioned elsewhere, v2 comment doesn't belong in commit message.
>
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Otherwise:
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index b13c0a7d50e4..528a5d24c0bc 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -216,13 +216,13 @@ static void sdhci_arasan_hs400_enhanced_strobe(struct mmc_host *mmc,
> u32 vendor;
> struct sdhci_host *host = mmc_priv(mmc);
>
> - vendor = readl(host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> + vendor = sdhci_readl(host, SDHCI_ARASAN_VENDOR_REGISTER);
> if (ios->enhanced_strobe)
> vendor |= VENDOR_ENHANCED_STROBE;
> else
> vendor &= ~VENDOR_ENHANCED_STROBE;
>
> - writel(vendor, host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> + sdhci_writel(host, vendor, SDHCI_ARASAN_VENDOR_REGISTER);
> }
>
> static void sdhci_arasan_reset(struct sdhci_host *host, u8 mask)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h
2017-07-17 1:23 [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h Jean-Francois Dagenais
2017-07-17 6:33 ` Michal Simek
2017-07-21 13:35 ` Adrian Hunter
@ 2017-07-22 13:17 ` Shawn Lin
2017-07-27 14:48 ` Ulf Hansson
3 siblings, 0 replies; 6+ messages in thread
From: Shawn Lin @ 2017-07-22 13:17 UTC (permalink / raw)
To: Jean-Francois Dagenais, ulf.hansson
Cc: adrian.hunter, michal.simek, shawn.lin, linux-mmc
在 2017/7/17 9:23, Jean-Francois Dagenais 写道:
> This increases consistency of the code across the sdhci family.
>
> v2: rebased onto ulfh/mmc/next and tweaked headline accordingly.
>
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Apart from the msg above,
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
And I included your patch for my other test for sdhci-of-arasan this
afternoon, so
Tested-by: Shawn Lin <shawn.lin@rock-chips.com>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index b13c0a7d50e4..528a5d24c0bc 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -216,13 +216,13 @@ static void sdhci_arasan_hs400_enhanced_strobe(struct mmc_host *mmc,
> u32 vendor;
> struct sdhci_host *host = mmc_priv(mmc);
>
> - vendor = readl(host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> + vendor = sdhci_readl(host, SDHCI_ARASAN_VENDOR_REGISTER);
> if (ios->enhanced_strobe)
> vendor |= VENDOR_ENHANCED_STROBE;
> else
> vendor &= ~VENDOR_ENHANCED_STROBE;
>
> - writel(vendor, host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> + sdhci_writel(host, vendor, SDHCI_ARASAN_VENDOR_REGISTER);
> }
>
> static void sdhci_arasan_reset(struct sdhci_host *host, u8 mask)
>
--
Best Regards
Shawn Lin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h
2017-07-17 1:23 [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h Jean-Francois Dagenais
` (2 preceding siblings ...)
2017-07-22 13:17 ` Shawn Lin
@ 2017-07-27 14:48 ` Ulf Hansson
3 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2017-07-27 14:48 UTC (permalink / raw)
To: Jean-Francois Dagenais
Cc: Adrian Hunter, Michal Simek, linux-mmc@vger.kernel.org
On 17 July 2017 at 03:23, Jean-Francois Dagenais
<jeff.dagenais@gmail.com> wrote:
> This increases consistency of the code across the sdhci family.
>
> v2: rebased onto ulfh/mmc/next and tweaked headline accordingly.
>
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Thanks applied for next, by dropping the version history from the change log.
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index b13c0a7d50e4..528a5d24c0bc 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -216,13 +216,13 @@ static void sdhci_arasan_hs400_enhanced_strobe(struct mmc_host *mmc,
> u32 vendor;
> struct sdhci_host *host = mmc_priv(mmc);
>
> - vendor = readl(host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> + vendor = sdhci_readl(host, SDHCI_ARASAN_VENDOR_REGISTER);
> if (ios->enhanced_strobe)
> vendor |= VENDOR_ENHANCED_STROBE;
> else
> vendor &= ~VENDOR_ENHANCED_STROBE;
>
> - writel(vendor, host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> + sdhci_writel(host, vendor, SDHCI_ARASAN_VENDOR_REGISTER);
> }
>
> static void sdhci_arasan_reset(struct sdhci_host *host, u8 mask)
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread