* mmc-utils: Completion of error handling
@ 2025-06-25 14:28 Markus Elfring
2025-06-26 7:03 ` Avri Altman
0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2025-06-25 14:28 UTC (permalink / raw)
To: linux-mmc; +Cc: Avri Altman, Ulf Hansson
Hello,
I have taken also another look at implementation details.
Thus I have noticed that the error detection is incomplete so far.
How do you think about to add more error handling for return values from functions
like printf() (for example)?
https://git.kernel.org/pub/scm/utils/mmc/mmc-utils.git/tree/mmc.c?h=v1.0#n515
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: mmc-utils: Completion of error handling
2025-06-25 14:28 mmc-utils: Completion of error handling Markus Elfring
@ 2025-06-26 7:03 ` Avri Altman
2025-06-26 10:10 ` Markus Elfring
0 siblings, 1 reply; 3+ messages in thread
From: Avri Altman @ 2025-06-26 7:03 UTC (permalink / raw)
To: Markus Elfring, linux-mmc@vger.kernel.org; +Cc: Avri Altman, Ulf Hansson
Markus hi,
> Hello,
>
> I have taken also another look at implementation details.
Also? I am lacking some context here.
> Thus I have noticed that the error detection is incomplete so far.
>
> How do you think about to add more error handling for return values from
> functions like printf() (for example)?
> https://git.kernel.org/pub/scm/utils/mmc/mmc-
> utils.git/tree/mmc.c?h=v1.0#n515
You are most welcome to send your patches over. We can discuss your ideas over the code.
Thanks,
Avri
>
> Regards,
> Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mmc-utils: Completion of error handling
2025-06-26 7:03 ` Avri Altman
@ 2025-06-26 10:10 ` Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2025-06-26 10:10 UTC (permalink / raw)
To: Avri Altman, linux-mmc; +Cc: Avri Altman, Ulf Hansson
>> I have taken also another look at implementation details.
> Also? I am lacking some context here.
I am just another code reviewer here.
>> Thus I have noticed that the error detection is incomplete so far.
Various source code analysis tools can point remaining open issues out.
>> How do you think about to add more error handling for return values from
>> functions like printf() (for example)?
>> https://git.kernel.org/pub/scm/utils/mmc/mmc-
>> utils.git/tree/mmc.c?h=v1.0#n515
> You are most welcome to send your patches over.
Several software design options can be clarified accordingly.
> We can discuss your ideas over the code.
How will chances evolve to benefit any more also from the means of
aspect-oriented software development?
https://en.wikipedia.org/wiki/Aspect-oriented_programming
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-26 10:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-25 14:28 mmc-utils: Completion of error handling Markus Elfring
2025-06-26 7:03 ` Avri Altman
2025-06-26 10:10 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox