Linux Modules
 help / color / mirror / Atom feed
From: Alan Maguire <alan.maguire@oracle.com>
To: Nicolas Schier <n.schier@fritz.com>
Cc: ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net,
	eddyz87@gmail.com, jolsa@kernel.org, ihor.solodrai@linux.dev,
	yonghong.song@linux.dev, song@kernel.org, qmo@kernel.org,
	martin.lau@linux.dev, memxor@gmail.com, emil@etsalapatis.com,
	mcgrof@kernel.org, petr.pavlu@suse.com, tj@kernel.org,
	kees@kernel.org, bpf@vger.kernel.org, nathan@kernel.org,
	arnd@arndb.de, puranjay@kernel.org, yatsenko@meta.com,
	atenart@kernel.org, ojeda@kernel.org,
	linux-modules@vger.kernel.org
Subject: Re: [PATCH v2 bpf-next 13/18] kbuild: Add support for BTF inline information
Date: Wed, 16 Sep 2026 08:42:44 +0100	[thread overview]
Message-ID: <bf1473a4-7a07-4a93-905f-fd1ff46b9533@oracle.com> (raw)
In-Reply-To: <20260914-axiomatic-meaty-lynx-8a5dc7@l-nschier-aarch64>

On 14/09/2026 08:50, Nicolas Schier wrote:
> On Tue, Sep 01, 2026 at 05:57:52PM +0100, Alan Maguire wrote:
>> Add CONFIG_DEBUG_INFO_BTF_INLINE to generate BTF inline-location
>> information with pahole v1.31 and later.
>> 
>> Enable pahole's inline feature and pass --inline to resolve_btfids.
>> This extracts LOC_PARAM, LOC_PROTO, and LOCSEC types into a split BTF
>> blob named <output>.BTF.inline while the ordinary BTF remains in .BTF.
>> 
>> Embed the resulting blob in a .BTF.inline ELF section for vmlinux and
>> modules.  Add the vmlinux linker-script output section to avoid it
>> being treated as an orphan.
>> 
>> Use the inline pahole feature unconditionally for both in-tree and
>> external modules; the generated split BTF has the same format in both
>> cases.
>> 
>> Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
>> ---
>>  include/asm-generic/vmlinux.lds.h | 11 +++++++++++
>>  lib/Kconfig.debug                 | 17 +++++++++++++++++
>>  scripts/Makefile.btf              |  7 +++++++
>>  scripts/gen-btf.sh                | 17 +++++++++++++++--
>>  4 files changed, 50 insertions(+), 2 deletions(-)
>> 
> 
> [...]
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index 1244dcac2294..dd1b2d9ebe99 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -425,6 +425,12 @@ config PAHOLE_HAS_LANG_EXCLUDE
>>  	  otherwise it would emit malformed kernel and module binaries when
>>  	  using DEBUG_INFO_BTF_MODULES.
>>  
>> +config PAHOLE_HAS_INLINE
>> +	def_bool PAHOLE_VERSION >= 131
> [...]
>> +config DEBUG_INFO_BTF_INLINE
>> +	bool "Provide information about inline sites in BTF"
>> +	default n
>> +	depends on DEBUG_INFO_BTF && PAHOLE_HAS_INLINE && SYSFS
> 
> [...]
>> diff --git a/scripts/Makefile.btf b/scripts/Makefile.btf
>> index a1812985a61a..d42dbc8d7199 100644
>> --- a/scripts/Makefile.btf
>> +++ b/scripts/Makefile.btf
>> @@ -22,7 +22,14 @@ endif
>>  
>>  pahole-flags-$(CONFIG_PAHOLE_HAS_LANG_EXCLUDE)		+= --lang_exclude=rust
>>  
>> +btf-inline := $(CONFIG_DEBUG_INFO_BTF_INLINE)
>> +ifneq ($(btf-inline),)
>> +btf-inline-feat := inline
>> +pahole-flags-$(call test-ge, $(pahole-ver), 131) += --btf_features=$(btf-inline-feat)
>> +endif
>> +
>>  export PAHOLE_FLAGS := $(pahole-flags-y)
>> +export BTF_INLINE := $(btf-inline)
> 
> 
> As btf-inline and btf-inline-feat are not used anywhere else, and 
> CONFIG_DEBUG_INFO_BTF_INLINE can only be set for PAHOLE_VERSION >= 131, 
> this looks a bit noisy to me.  I think it would be good to keep that 
> change in scripts/Makefile.btf as short as possible, e.g.:
> 
>     pahole-flags-$(CONFIG_DEBUG_INFO_BTF_INLINE) += --btf_features=inline
> 
> and for scripts/gen-btf.sh something like:
> 
>     if is_enabled CONFIG_DEBUG_INFO_BTF_INLINE; then
>     	BTF_INLINE=inline
>     fi
> 
>

looks good, I'll make that change for the next revision (splitting this into multiple
series so the kbuild aspects will follow a bit later). Thanks again for taking a look!

Alan

  reply	other threads:[~2026-09-16  7:43 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 16:57 [PATCH v2 bpf-next 00/18] Support inline functions in BTF Alan Maguire
2026-09-01 16:57 ` [PATCH v2 bpf-next 01/18] btf: Extend UAPI to support BTF location (inline site) info Alan Maguire
2026-09-01 17:17   ` sashiko-bot
2026-09-14 17:26     ` Alan Maguire
2026-09-01 17:55   ` bot+bpf-ci
2026-09-09 22:26   ` Eduard Zingerman
2026-09-14 15:38     ` Alan Maguire
2026-09-11 19:26   ` Jiri Olsa
2026-09-14 14:29     ` Alan Maguire
2026-09-15  8:13       ` Jiri Olsa
2026-09-01 16:57 ` [PATCH v2 bpf-next 02/18] libbpf: Add support for BTF kinds LOC[_PARAM|_PROTO|SEC] Alan Maguire
2026-09-01 17:11   ` sashiko-bot
2026-09-09 22:26   ` Eduard Zingerman
2026-09-01 16:57 ` [PATCH v2 bpf-next 03/18] libbpf: Support moving permuted BTF types into split BTF Alan Maguire
2026-09-01 17:15   ` sashiko-bot
2026-09-01 18:14   ` bot+bpf-ci
2026-09-10  9:37   ` Eduard Zingerman
2026-09-16  7:33     ` Alan Maguire
2026-09-16  7:45       ` Eduard Zingerman
2026-09-01 16:57 ` [PATCH v2 bpf-next 04/18] selftests/bpf: Test helper support for BTF_KIND_LOC[_PARAM|_PROTO|SEC] Alan Maguire
2026-09-01 17:06   ` sashiko-bot
2026-09-01 16:57 ` [PATCH v2 bpf-next 05/18] selftests/bpf: Add LOC_PARAM, LOC_PROTO, LOCSEC to field iter tests Alan Maguire
2026-09-01 16:57 ` [PATCH v2 bpf-next 06/18] selftests/bpf: Add LOC_PARAM, LOC_PROTO, LOCSEC to dedup split tests Alan Maguire
2026-09-01 17:55   ` bot+bpf-ci
2026-09-01 16:57 ` [PATCH v2 bpf-next 07/18] selftests/bpf: BTF distill tests to ensure LOC[_PARAM|_PROTO] add to split BTF Alan Maguire
2026-09-01 17:55   ` bot+bpf-ci
2026-09-01 16:57 ` [PATCH v2 bpf-next 08/18] selftests/bpf: Validate that btf__permute transfer works Alan Maguire
2026-09-01 17:16   ` sashiko-bot
2026-09-01 17:55   ` bot+bpf-ci
2026-09-01 16:57 ` [PATCH v2 bpf-next 09/18] bpftool: Handle multi-split BTF by supporting multiple base BTFs Alan Maguire
2026-09-01 17:13   ` sashiko-bot
2026-09-01 16:57 ` [PATCH v2 bpf-next 10/18] bpftool: Document support for multi-split BTF Alan Maguire
2026-09-01 17:12   ` sashiko-bot
2026-09-01 16:57 ` [PATCH v2 bpf-next 11/18] bpftool: Add ability to dump LOC_PARAM, LOC_PROTO and LOCSEC Alan Maguire
2026-09-01 17:16   ` sashiko-bot
2026-09-01 17:55   ` bot+bpf-ci
2026-09-07 19:30   ` Alexei Starovoitov
2026-09-01 16:57 ` [PATCH v2 bpf-next 12/18] resolve_btfids: Extract inline BTF Alan Maguire
2026-09-01 17:23   ` sashiko-bot
2026-09-01 16:57 ` [PATCH v2 bpf-next 13/18] kbuild: Add support for BTF inline information Alan Maguire
2026-09-01 17:55   ` bot+bpf-ci
2026-09-14  7:50   ` Nicolas Schier
2026-09-16  7:42     ` Alan Maguire [this message]
2026-09-01 16:57 ` [PATCH v2 bpf-next 14/18] btf: Make vmlinux, module inline info available in /sys/kernel/btf Alan Maguire
2026-09-07 19:34   ` Alexei Starovoitov
2026-09-07 19:50     ` Alan Maguire
2026-09-07 20:00       ` Alexei Starovoitov
2026-09-01 16:57 ` [PATCH v2 bpf-next 15/18] btf: Support CONFIG_DEBUG_INFO_BTF_INLINE=m Alan Maguire
2026-09-01 17:24   ` sashiko-bot
2026-09-01 16:57 ` [PATCH v2 bpf-next 16/18] btf: Relocate inline BTF for modules with distilled base BTF Alan Maguire
2026-09-01 17:29   ` sashiko-bot
2026-09-01 17:55   ` bot+bpf-ci
2026-09-01 16:57 ` [PATCH v2 bpf-next 17/18] selftests/bpf: Test BTF sysfs inline representations Alan Maguire
2026-09-01 17:22   ` sashiko-bot
2026-09-01 17:55   ` bot+bpf-ci
2026-09-01 16:57 ` [PATCH v2 bpf-next 18/18] selftests/bpf: Add a test verifying inline information Alan Maguire
2026-09-01 17:28   ` sashiko-bot
2026-09-01 17:55   ` bot+bpf-ci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf1473a4-7a07-4a93-905f-fd1ff46b9533@oracle.com \
    --to=alan.maguire@oracle.com \
    --cc=andrii@kernel.org \
    --cc=arnd@arndb.de \
    --cc=ast@kernel.org \
    --cc=atenart@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=jolsa@kernel.org \
    --cc=kees@kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mcgrof@kernel.org \
    --cc=memxor@gmail.com \
    --cc=n.schier@fritz.com \
    --cc=nathan@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=puranjay@kernel.org \
    --cc=qmo@kernel.org \
    --cc=song@kernel.org \
    --cc=tj@kernel.org \
    --cc=yatsenko@meta.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox