* Re: [MTD] Basic NAND driver for AMD/NatSemi CS5535/CS5536 Geode companion chip
[not found] <E1FeJBW-0002Du-BX@pentafluge.infradead.org>
@ 2006-05-11 22:39 ` Jörn Engel
2006-05-11 23:39 ` David Woodhouse
0 siblings, 1 reply; 2+ messages in thread
From: Jörn Engel @ 2006-05-11 22:39 UTC (permalink / raw)
To: Linux-MTD Mailing List; +Cc: David Woodhouse
On Thu, 11 May 2006 22:59:02 +0100, Linux-MTD Mailing List wrote:
>
> +static int cs553x_device_ready(struct mtd_info *mtd)
> +{
> + struct nand_chip *this = mtd->priv;
> + void __iomem *mmio_base = this->IO_ADDR_R;
> + unsigned char foo = readb(mmio_base + MM_NAND_STS);
> +
> + return (foo & CS_NAND_STS_FLASH_RDY) && !(foo & CS_NAND_CTLR_BUSY);
Foo?
> + /* Initialize structures */
> + memset((char *) new_mtd, 0, sizeof(struct mtd_info));
> + memset((char *) this, 0, sizeof(struct nand_chip));
Why the cast?
> + kfree (new_mtd);
Extra space.
Jörn
--
Invincibility is in oneself, vulnerability is in the opponent.
-- Sun Tzu
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [MTD] Basic NAND driver for AMD/NatSemi CS5535/CS5536 Geode companion chip
2006-05-11 22:39 ` [MTD] Basic NAND driver for AMD/NatSemi CS5535/CS5536 Geode companion chip Jörn Engel
@ 2006-05-11 23:39 ` David Woodhouse
0 siblings, 0 replies; 2+ messages in thread
From: David Woodhouse @ 2006-05-11 23:39 UTC (permalink / raw)
To: Jörn Engel; +Cc: Linux-MTD Mailing List
On Fri, 2006-05-12 at 00:39 +0200, Jörn Engel wrote:
> On Thu, 11 May 2006 22:59:02 +0100, Linux-MTD Mailing List wrote:
> >
> > +static int cs553x_device_ready(struct mtd_info *mtd)
> > +{
> > + struct nand_chip *this = mtd->priv;
> > + void __iomem *mmio_base = this->IO_ADDR_R;
> > + unsigned char foo = readb(mmio_base + MM_NAND_STS);
> > +
> > + return (foo & CS_NAND_STS_FLASH_RDY) && !(foo & CS_NAND_CTLR_BUSY);
>
> Foo?
Spot the removed debugging printk :)
> Why the cast?
> Extra space.
Inherited from autcpu12.c and then in turn from spia.c I believe. I'll
clean them all up.
--
dwmw2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-05-11 23:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1FeJBW-0002Du-BX@pentafluge.infradead.org>
2006-05-11 22:39 ` [MTD] Basic NAND driver for AMD/NatSemi CS5535/CS5536 Geode companion chip Jörn Engel
2006-05-11 23:39 ` David Woodhouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox