From: Artem Bityutskiy <dedekind1@gmail.com>
To: Joel Reardon <joel@clambassador.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] UBI: add lnum to struct ubi_work
Date: Tue, 15 May 2012 14:14:58 +0300 [thread overview]
Message-ID: <1337080498.2528.161.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205142046080.12448@eristoteles.iwoars.net>
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
On Mon, 2012-05-14 at 20:47 +0200, Joel Reardon wrote:
> @@ -1086,13 +1090,14 @@ out_ro:
> * @ubi: UBI device description object
> * @pnum: physical eraseblock to return
> * @torture: if this physical eraseblock has to be tortured
> + * @lnum: the last used logical eraseblock number for the PEB
> *
> * This function is called to return physical eraseblock @pnum to the pool of
> * free physical eraseblocks. The @torture flag has to be set if an I/O error
> * occurred to this @pnum and it has to be tested. This function returns zero
> * in case of success, and a negative error code in case of failure.
> */
> -int ubi_wl_put_peb(struct ubi_device *ubi, int pnum, int torture)
> +int ubi_wl_put_peb(struct ubi_device *ubi, int pnum, int torture, int lnum)
Joel, am sorry for nitpicking again, but could you please put the "lnum"
argument between "ubi" and "lnum" instead? Just feels more natural.
Otherwise the patch is OK. Thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-15 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 18:47 [PATCH v2] UBI: add lnum to struct ubi_work Joel Reardon
2012-05-15 11:14 ` Artem Bityutskiy [this message]
2012-05-15 11:26 ` Artem Bityutskiy
2012-05-15 11:47 ` Joel Reardon
2012-05-15 12:15 ` Artem Bityutskiy
2012-05-15 11:48 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337080498.2528.161.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=joel@clambassador.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox