From: Artem Bityutskiy <dedekind1@gmail.com>
To: Joel Reardon <joel@clambassador.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] UBI: add lnum to struct ubi_work
Date: Tue, 15 May 2012 15:15:31 +0300 [thread overview]
Message-ID: <1337084131.2528.189.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205151339020.18866@eristoteles.iwoars.net>
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
On Tue, 2012-05-15 at 13:47 +0200, Joel Reardon wrote:
> For vol_id, its straightforward everywhere except: ubi_wl_init_scan()
>
> where scheduling erase on the:
>
> struct ubi_scan_leb *seb
>
> appears to lack access to the volume id. Should we add vol_id to
> ubi_scan_leb, and in ubi_scan() run:
>
> ubi_rb_for_each_entry(rb1, sv, &si->volumes, rb) {
> ubi_rb_for_each_entry(rb2, seb, &sv->root, u.rb)
> seb->vol_id = sv->vol_id;
>
> Or is there a simpler way?
I guess yes. Add this field as a separate patch please.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-15 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 18:47 [PATCH v2] UBI: add lnum to struct ubi_work Joel Reardon
2012-05-15 11:14 ` Artem Bityutskiy
2012-05-15 11:26 ` Artem Bityutskiy
2012-05-15 11:47 ` Joel Reardon
2012-05-15 12:15 ` Artem Bityutskiy [this message]
2012-05-15 11:48 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337084131.2528.189.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=joel@clambassador.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox